Re: Status of new compiler plugin for Maven 4

2024-08-07 Thread Konrad Windszus
Hi Martin, First of all thanks a lot for the hard work. Much appreciated. However there is other compilers like the Groovy Eclipse Compiler (https://github.com/groovy/groovy-eclipse/blob/d6ac73c6ba4adadbd67c60bf130ad68f2284890f/extras/groovy-eclipse-compiler/src/main/java/org/codehaus/groovy/eclip

Re: [VOTE] Release Maven Resolver 1.9.22

2024-08-07 Thread Slawomir Jaranowski
+1 pon., 5 sie 2024 o 16:09 Tamás Cservenák napisał(a): > Howdy, > > This Resolver 1.9.22 release is a release with memory usage improvements in > collectors. > > Maven 4.x is picking up Resolver 2.x, while Maven 3.x remains at Resolver > 1.x lineage. The two major versions, as far as client cod

Re: [VOTE] Release Maven Resolver 2.0.1

2024-08-07 Thread Slawomir Jaranowski
+1 pon., 5 sie 2024 o 16:08 Tamás Cservenák napisał(a): > Howdy, > > This Resolver 2.0.1 release is a bugfix release with several improvements > as well: a bugfix in JDK transport, JDK and Jetty transport improvements, > and memory usage improvements in collectors and finally IPC named locks > (

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Guillaume Nodet
I thought we set the default encoding in the root pom a while ago ? Le lun. 5 août 2024 à 13:30, Tamás Cservenák a écrit : > > +1 for removing this warning > > On Mon, Aug 5, 2024 at 1:22 PM Martin Desruisseaux < > martin.desruisse...@geomatys.com> wrote: > > > In Maven 3, if the configuration p

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Le mar. 6 août 2024 à 11:08, Martin Desruisseaux a écrit : > > Le 2024-08-05 à 14 h 19, Tamás Cservenák a écrit : > > > You are on the right track and Guillame and I had a lot of discussions > > about this. IMO, best would be to wait for him (is on PTO I think) and > > have a chat face to face? >

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 12 h 55, Guillaume Nodet a écrit : I'm not a big fan of reducing the visibility of implementation classes. The API is well defined, i.e. all org.apache.maven.api.* packages. It is because while the API does not expose Eclipse Aether, the implementation does. If, in the future

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 12 h 49, Guillaume Nodet a écrit : I thought we set the default encoding in the root pom a while ago ? Apparently not. The default encoding is ${project.build.sourceEncoding}. But if this property is not explicitly set in user's project, we get the warning (tested with Maven 3

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 13 h 42, Martin Desruisseaux a écrit : Note: I would not recommend to change that. I mean, the fact that the encoding is apparently not specified in the root POM. I still suggest to remove the warning except on Java 17.     Martin --

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Gary Gregory
I think COMPAT is going away in Java 23: https://inside.java/2024/07/11/quality-heads-up/ Gary On Wed, Aug 7, 2024, 7:43 AM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > Le 2024-08-07 à 12 h 49, Guillaume Nodet a écrit : > > > > I thought we set the default encoding in the roo

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Guillaume Nodet Le mer. 7 août 2024 à 13:24, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-08-07 à 12 h 55, Guillaume Nodet a écrit : > > > I'm not a big fan of reducing the visibility of implementation > > classes. The API is well defined,

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
I’ll reply to that one later… Guillaume Nodet Le lun. 5 août 2024 à 14:07, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Maven 4 has two very similar public interfaces for dependencies: > > * Dependency > * DependencyCoordinate > > They both h

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Guillaume Nodet
https://github.com/apache/maven/blob/c0012c08aaad27473770fc39ab7e39026238c7e1/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.1.0.xml#L27 Guillaume Nodet Le mer. 7 août 2024 à 13:44, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit :

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 13 h 56, Gary Gregory a écrit : I think COMPAT is going away in Java 23: https://inside.java/2024/07/11/quality-heads-up/ Thanks for the link. But it seems to be a different `COMPAT`. The above link mentions only the `java.locale.providers` property value, while the `COMPAT`

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Gary Gregory
Hm, good point! There must be different toggles. Gary On Wed, Aug 7, 2024, 8:27 AM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > Le 2024-08-07 à 13 h 56, Gary Gregory a écrit : > > > > I think COMPAT is going away in Java 23: > > https://inside.java/2024/07/11/quality-heads-up

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 14 h 26, Guillaume Nodet a écrit : https://github.com/apache/maven/blob/c0012c08aaad27473770fc39ab7e39026238c7e1/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.1.0.xml#L27 My bad. Re-testing again, I get the warning with Maven 3.9.6 (the version provided b

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 14 h 21, Guillaume Nodet a écrit : Why do we care ? If we provide a well defined API (with a known set of jars), people should be aware if they use maven-core jar directly…. It is a matter of reputation for the Maven project. A Murphy law is that given a sufficiently large am

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Le mer. 7 août 2024 à 15:30, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-08-07 à 14 h 21, Guillaume Nodet a écrit : > > > > Why do we care ? If we provide a well defined API (with a known set of > > jars), people should be aware if they use maven-core jar directly….

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 17 h 38, Guillaume Nodet a écrit : Did I miss something ? We need to load plugins at runtime, I thought JPMS was static… JPMS can load plugins at runtime as well. However, the way to do that is very different. It is no longer with ClassLoader, we have to use ModuleLayer instead

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Can it load non JPMS jars too ? Maybe this has changed, but my understanding is that everything had to be JPMS modules, meaning that any plugin that has a dependency which is not a JPMS module would not be loadable… That’s a too big constraint imho. Guillaume Nodet Le m

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 18 h 25, Guillaume Nodet a écrit : Can it load non JPMS jars too ? Yes, as an "automatic" or "unnamed" module.     Martin - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands,

Re: Should the Dependency interface contains a getPath() method?

2024-08-07 Thread Guillaume Nodet
Le lun. 5 août 2024 à 14:07, Martin Desruisseaux a écrit : > > Maven 4 has two very similar public interfaces for dependencies: > > * Dependency > * DependencyCoordinate > > They both have groupId, artifactId, classifier, version, extension, type > and scope. Differences that I observed are: >

Re: [VOTE] Release Maven Resolver 2.0.1

2024-08-07 Thread Jermaine Hua
+1 Slawomir Jaranowski 于2024年8月7日周三 16:18写道: > > +1 > > pon., 5 sie 2024 o 16:08 Tamás Cservenák napisał(a): > > > Howdy, > > > > This Resolver 2.0.1 release is a bugfix release with several improvements > > as well: a bugfix in JDK transport, JDK and Jetty transport improvements, > > and memory

Re: [VOTE] Release Maven Resolver 1.9.22

2024-08-07 Thread Jermaine Hua
+1 Slawomir Jaranowski 于2024年8月7日周三 16:17写道: > > +1 > > pon., 5 sie 2024 o 16:09 Tamás Cservenák napisał(a): > > > Howdy, > > > > This Resolver 1.9.22 release is a release with memory usage improvements in > > collectors. > > > > Maven 4.x is picking up Resolver 2.x, while Maven 3.x remains at R

Re: [VOTE] Release Maven Resolver 2.0.1

2024-08-07 Thread Sylwester Lachiewicz
+1 czw., 8 sie 2024, 01:18 użytkownik Jermaine Hua napisał: > +1 > > Slawomir Jaranowski 于2024年8月7日周三 16:18写道: > > > > +1 > > > > pon., 5 sie 2024 o 16:08 Tamás Cservenák > napisał(a): > > > > > Howdy, > > > > > > This Resolver 2.0.1 release is a bugfix release with several > improvements > >

Re: [VOTE] Release Maven Resolver 1.9.22

2024-08-07 Thread Sylwester Lachiewicz
+1 czw., 8 sie 2024, 01:19 użytkownik Jermaine Hua napisał: > +1 > > Slawomir Jaranowski 于2024年8月7日周三 16:17写道: > > > > +1 > > > > pon., 5 sie 2024 o 16:09 Tamás Cservenák > napisał(a): > > > > > Howdy, > > > > > > This Resolver 1.9.22 release is a release with memory usage > improvements in >