Cannot create LocalRepositoryManager with Maven Artifact Resolver 2.0

2024-07-12 Thread Nick Hensel
Hi, I'm currently migrating my Maven Artifact Resolver 1.x code to 2.0. As of version 2.0 the recommend way to create a RepositorySystemSession is through a SessionBuilder. In my case, I need to set an own LocalRepositoryManager, which wraps two EnhancedLocalRepositoryManager instanced. The pro

Re: Cannot create LocalRepositoryManager with Maven Artifact Resolver 2.0

2024-07-12 Thread Tamás Cservenák
Howdy, see here and below: https://github.com/apache/maven-resolver/blob/d13019ce5fa38c0951ca0fb0c62a3f5f1254cffc/maven-resolver-api/src/main/java/org/eclipse/aether/RepositorySystemSession.java#L439 T On Fri, Jul 12, 2024 at 11:29 AM Nick Hensel wrote: > Hi, > I'm currently migrating my Mave

Re: Cannot create LocalRepositoryManager with Maven Artifact Resolver 2.0

2024-07-12 Thread Tamás Cservenák
Also, check out demo snippets: https://github.com/apache/maven-resolver/blob/d13019ce5fa38c0951ca0fb0c62a3f5f1254cffc/maven-resolver-demos/maven-resolver-demo-snippets/src/main/java/org/apache/maven/resolver/examples/util/Booter.java#L68 T On Fri, Jul 12, 2024 at 11:45 AM Tamás Cservenák wrote:

Re: Cannot create LocalRepositoryManager with Maven Artifact Resolver 2.0

2024-07-12 Thread Nick Hensel
Thanks for the fast reply :) Actually the examples set the paths of the local repository instead of the LocalRepositoryManager directly. My problem here is, that I'm actually using an own implementation of LocalRepositoryManager that wraps 2 instances of EnhancedLocalRepositoryManager. I forg

Re: Cannot create LocalRepositoryManager with Maven Artifact Resolver 2.0

2024-07-12 Thread Tamás Cservenák
Yes, in that case, if you want to go "full resolver 2" way in Jack, I'd do following: - create a "root" session - derive your own session from root (nested/derived session) - used derived session - once done, close derived and close root session I don't see what CacheLocalRepositoryManager does, I

Re: Cannot create LocalRepositoryManager with Maven Artifact Resolver 2.0

2024-07-12 Thread Nick Hensel
I switched to Codeberg actually, the class would be here: https://codeberg.org/goldmensch/jack/src/branch/dependencies-and-lockfile/src/main/java/io/github/goldmensch/cache/CacheLocalRepositoryManager.java So, I have to create a root session, without any LocalRepositoryManager set and then crea

Re: Cannot create LocalRepositoryManager with Maven Artifact Resolver 2.0

2024-07-12 Thread Nick Hensel
I switched to Codeberg actually, the class would be here: https://codeberg.org/goldmensch/jack/src/branch/dependencies-and-lockfile/src/main/java/io/github/goldmensch/cache/CacheLocalRepositoryManager.java So, I have to create a root session, without any LocalRepositoryManager set and then crea

Re: Cannot create LocalRepositoryManager with Maven Artifact Resolver 2.0

2024-07-12 Thread Tamás Cservenák
Created https://issues.apache.org/jira/browse/MRESOLVER-585 On Fri, Jul 12, 2024 at 12:36 PM Nick Hensel wrote: > I switched to Codeberg actually, the class would be here: > https://codeberg.org/goldmensch/jack/src/branch/dependencies-and-lockfile/src/main/java/io/github/goldmensch/cache/CacheLo

[DISCUSS] Move some mojohaus plugins to the ASF

2024-07-12 Thread Guillaume Nodet
I've been working on migrating the build-helper-maven-plugin to the Maven 4.x API. The work is available at [1] (PR is red, but that's a CI configuration problem). While doing so, I've had a hard time figuring out why some plugins are hosted at the ASF while some others are hosted at MojoHaus. This

Re: [DISCUSS] Move some mojohaus plugins to the ASF

2024-07-12 Thread Elliotte Rusty Harold
Meta-question: how do you plan to change group IDs and licenses? Presumably everything would now be under the Apache license instead of MIT or whatever they're currently using. I hope the licenses are all compatible with this shift. Should the group IDs change too? Ideally they wouldn't, but we'd

Re: [DISCUSS] Move some mojohaus plugins to the ASF

2024-07-12 Thread Martin Desruisseaux
Le 2024-07-12 à 15 h 26, Guillaume Nodet a écrit : I've been working on migrating the build-helper-maven-plugin to the Maven 4.x API. (…snip…). This plugin in particular is used a lot (to add generated source/resources and attach artifacts) and there's no other way to do it. This is essentiall

Re: [DISCUSS] Move some mojohaus plugins to the ASF

2024-07-12 Thread Guillaume Nodet
Le ven. 12 juil. 2024 à 15:55, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit : > Le 2024-07-12 à 15 h 26, Guillaume Nodet a écrit : > > > I've been working on migrating the build-helper-maven-plugin to the > > Maven 4.x API. (…snip…). This plugin in particular is used a lot (to >

Re: [VOTE] Release Maven Release version 3.1.1

2024-07-12 Thread Basil Crow
+1 On Thu, Jul 11, 2024 at 11:36 PM Michael Osipov wrote: > > +1 > > On 2024/07/11 18:21:40 Michael Osipov wrote: > > Hi, > > > > we solved 3 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317824&version=12354890 > > > > There are still a couple of issues left in J

Re: [DISCUSS] Move some mojohaus plugins to the ASF

2024-07-12 Thread Martin Desruisseaux
Le 2024-07-12 à 19 h 00, Guillaume Nodet a écrit : I like it a lot. This could also prove very useful to better support multi-release JARs. Yes, I had that purpose in mind as well, and multi-releases is one of the reasons for the proposal. It would also be useful for Module Source Hierarchy,

Re: [DISCUSS] Move some mojohaus plugins to the ASF

2024-07-12 Thread Karl Heinz Marbaise
Hi, good questions. On 12.07.24 15:53, Elliotte Rusty Harold wrote: Meta-question: how do you plan to change group IDs and licenses? Presumably everything would now be under the Apache license instead of MIT or whatever they're currently using. I hope the licenses are all compatible with this s

Re: [VOTE] Release Maven Release version 3.1.1

2024-07-12 Thread Sylwester Lachiewicz
+1 pt., 12 lip 2024, 08:36 użytkownik Michael Osipov napisał: > +1 > > On 2024/07/11 18:21:40 Michael Osipov wrote: > > Hi, > > > > we solved 3 issues: > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317824&version=12354890 > > > > There are still a couple of issues left

Re: [VOTE] Release Maven Release version 3.1.1

2024-07-12 Thread Olivier Lamy
+1 On Fri, 12 Jul 2024 at 4:21 AM, Michael Osipov wrote: > Hi, > > we solved 3 issues: > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317824&version=12354890 > > There are still a couple of issues left in JIRA: > https://issues.apache.org/jira/projects/MRELEASE/issues > >

Re: [DISCUSS] Move some mojohaus plugins to the ASF

2024-07-12 Thread Grzegorz Grzybek
Hello My 2¢. Big +1 for bringing in build-helper-maven-plugin under org.apache.maven.plugins - its add-[test]-(re)source goals are really the "core" of Maven. But also attach-artifact. I don't quite like using attributes for configuration - these were historically (at least since Maven 2) meta co