Re: wondering if setting the base version belongs in a get/is method

2005-11-09 Thread Brett Porter
for the setting of base version - I think it works internally, but has some quirks when used externally as encountered here. AFAICT this wasn't a reference to a bug when running Maven. for the design - yes, it's still there. - Brett John Casey wrote: -BEGIN PGP SIGNED MESSAGE- Hash:

Re: wondering if setting the base version belongs in a get/is method

2005-11-09 Thread John Casey
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 is there an issue for this yet? Brett Porter wrote: | This is a poorly encapsulated class that needs some work. | | base version should always be "-SNAPSHOT", while version should be | "-2005..." | | - Brett | | Donszelmann, Mark wrote: | |> Hi |> |>

Re: wondering if setting the base version belongs in a get/is method

2005-11-09 Thread Brett Porter
This is a poorly encapsulated class that needs some work. base version should always be "-SNAPSHOT", while version should be "-2005..." - Brett Donszelmann, Mark wrote: Hi the following code in DefaultArtifact.java changes the behaviour of the getBaseVersion() method. -- public boolea

wondering if setting the base version belongs in a get/is method

2005-11-09 Thread Donszelmann, Mark
Hi the following code in DefaultArtifact.java changes the behaviour of the getBaseVersion() method. -- public boolean isSnapshot() { if ( version != null || baseVersion != null ) { Matcher m = VERSION_FILE_PATTERN.matcher( getBaseVersion() ); if (