Re: Next shade release: 2.1 or 3.0?

2012-11-24 Thread Stephen Connolly
Well if we need to get a supporting change into core, and this feature only works on newer versions of maven, falling back to the old way. I think we can live with that. If anything it would be a driver for people to upgrade ;-) On Saturday, 24 November 2012, Benson Margulies wrote: > I'm having

Re: Next shade release: 2.1 or 3.0?

2012-11-24 Thread Benson Margulies
I'm having a bit of a pause figuring out how to implement Stephen's idea. The crux here is to tell the reactor that the official output of shade should function in the reactor as the primary result artifact of the current project, *without* overwriting the usual file name. Since the jar plugin wil

Re: Next shade release: 2.1 or 3.0?

2012-11-24 Thread Benson Margulies
I'm having a bit of a pause figuring out how to implement Stephen's idea. The crux here is to tell the reactor that the official output of shade should function in the reactor as the primary result artifact of the current project, *without* overwriting the usual file name. My initial thought is t

Re: Next shade release: 2.1 or 3.0?

2012-11-24 Thread Jochen Wiedmann
In that case, it's got to be 3.0, IMO. On Fri, Nov 23, 2012 at 11:06 PM, Benson Margulies wrote: > On Fri, Nov 23, 2012 at 4:57 PM, Jochen Wiedmann > wrote: > > This would be an incompatible change, would it? > > Yes, indeed, insofar as anyone who scripted to expect the shaded > version to be

Re: Next shade release: 2.1 or 3.0?

2012-11-23 Thread Benson Margulies
On Fri, Nov 23, 2012 at 7:22 PM, Stephen Connolly wrote: > And you'll recall my vote is for 3.0 (assuming the idea works and you > decide to go ahead with it, that is) I have no objection to 3. I sent this message because (1) the recent release of 2.0 made me feel some risk of silliness, and (b)

Re: Next shade release: 2.1 or 3.0?

2012-11-23 Thread Stephen Connolly
And you'll recall my vote is for 3.0 (assuming the idea works and you decide to go ahead with it, that is) [Briefly, for anyone who is interested, the idea is to replace the artifact attached to the reactor, rather than replace the file... Thus jar:jar's output will be the responsibility of jar:ja

Re: Next shade release: 2.1 or 3.0?

2012-11-23 Thread Benson Margulies
On Fri, Nov 23, 2012 at 4:57 PM, Jochen Wiedmann wrote: > This would be an incompatible change, would it? Yes, indeed, insofar as anyone who scripted to expect the shaded version to be sitting in target under finalName would be broken > > > > On Fri, Nov 23, 2012 at 10:38 PM, Benson Margulies

Re: Next shade release: 2.1 or 3.0?

2012-11-23 Thread Jochen Wiedmann
This would be an incompatible change, would it? On Fri, Nov 23, 2012 at 10:38 PM, Benson Margulies wrote: > I want to take up a suggestion of Stephen Connolly and fix the > interactions between shade and jar by changing the default file name > of 'replacing' shaded jars. I'd like incremental ja

Next shade release: 2.1 or 3.0?

2012-11-23 Thread Benson Margulies
I want to take up a suggestion of Stephen Connolly and fix the interactions between shade and jar by changing the default file name of 'replacing' shaded jars. I'd like incremental jar-ing to work by default, so I want to change the default behavior. 2.1 or 3.0? ---

Re: Next shade release 2.0

2012-11-23 Thread Benson Margulies
Please ignore this, I'll send a coherent alternative in a moment with a different subject. On Fri, Nov 23, 2012 at 4:35 PM, Benson Margulies wrote: > I want to take up a suggestion of Stephen Connolly and fix the > interactions between shade and jar by changing the default file name > of 'replaci

Next shade release 2.0

2012-11-23 Thread Benson Margulies
I want to take up a suggestion of Stephen Connolly and fix the interactions between shade and jar by changing the default file name of 'replacing' shaded jars. Since no one has marked fixed anything since the last release, I'm just going to set the version to be 2.0-SNAPSHOT. -

Re: shade release

2011-10-29 Thread Robert Burrell Donkin
On Fri, Oct 28, 2011 at 10:55 PM, Stephen Connolly wrote: > go for it +1 Robert - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: shade release

2011-10-28 Thread Stephen Connolly
go for it On 28 October 2011 22:41, Benson Margulies wrote: > A user is asking for one. Anyone mind if I tee it up? > > - > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@mave

shade release

2011-10-28 Thread Benson Margulies
A user is asking for one. Anyone mind if I tee it up? - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

Re: shade release?

2008-10-15 Thread Jason van Zyl
correct On 15-Oct-08, at 3:42 PM, Brett Porter wrote: http://mail-archives.apache.org/mod_mbox/maven-dev/200809.mbox/[EMAIL PROTECTED] AFAICT, this passed the vote, but hasn't been pushed out yet? Cheers, Brett -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ -

shade release?

2008-10-15 Thread Brett Porter
http://mail-archives.apache.org/mod_mbox/maven-dev/200809.mbox/[EMAIL PROTECTED] AFAICT, this passed the vote, but hasn't been pushed out yet? Cheers, Brett -- Brett Porter [EMAIL PROTECTED] http://blogs.exist.com/bporter/ -