platform dependent newline is a feature, to respect user platform
I see your preference and agree to disagree: it's definitely a no for me on
this
Le dimanche 17 janvier 2021, 18:41:33 CET Elliotte Rusty Harold a écrit :
> On Sun, Jan 17, 2021 at 3:41 PM Hervé BOUTEMY wrote:
> > there is a chec
On Sun, Jan 17, 2021 at 3:41 PM Hervé BOUTEMY wrote:
>
> there is a checkError() method we should probably check before closing, that
> seems a good idea
>
Remembering (and forgetting) to call an error checking method at the
right time is the unreliable anti-pattern IOException was created to
avo
there is a checkError() method we should probably check before closing, that
seems a good idea
Le samedi 16 janvier 2021, 20:49:53 CET Elliotte Rusty Harold a écrit :
> On Sat, Jan 16, 2021 at 8:31 AM Hervé BOUTEMY wrote:
> > I see this objection more and more lately.
> > I don't really understa
On Sat, Jan 16, 2021 at 8:31 AM Hervé BOUTEMY wrote:
>
> I see this objection more and more lately.
> I don't really understand it, I consider it vaguely theoretical, and don't see
> any concrete issue.
>
This is very much a concrete issue. I/O is unreliable. Sometimes it
fails. When it does an I
I don't remember the discussion.
What do you think about JSR-330 in plugin code?
sob., 16 sty 2021 o 09:37 Hervé BOUTEMY napisał(a):
> my strategy in this plugin was to use maven-shared-utils, of course when
> no
> API exists in JDK
> If I did it wrong in some cases, don't hesitate to provide a
my strategy in this plugin was to use maven-shared-utils, of course when no
API exists in JDK
If I did it wrong in some cases, don't hesitate to provide a PR
And if there is a newer version of JDK that provides APIs to replace maven-
shared-utils, we should document it in maven-shared-utils, and t
PR welcome: yes, that would be nice
Le vendredi 15 janvier 2021, 12:54:36 CET Elliotte Rusty Harold a écrit :
> There are some good integration tests. Unit tests would help round this out.
>
> Most classes and method appear public by default. It's not obvious
> they need to be. I think almost all
I see this objection more and more lately.
I don't really understand it, I consider it vaguely theoretical, and don't see
any concrete issue.
but I see a concrete issue on using OutputStreamWriter API instead of
PrintWriter: I don't have "println(...)"
perhaps something should be reported to th
PR welcome for deprecation removal
on JDK 8, I'm -1 because I know that it's a one char update in a pom file, but
I don't see any benefit, I only see drawback: it can be used in less cases.
And concretely, on Reproducible Central [1], if I upgrade JDK prerequisite to
JDK 8, I have 16 releases th
thank you Matthieu
on splitting buildinfo generation and check, everybody starts with this logic
when thinking, even me. Then during implementation, I discovered that in
reality we don't check against a downloaded reference buildinfo file, but we
check against a reference buildinfo that we buil
Hi,
I use
org.apache.maven.repository.RepositorySystem#createArtifactWithClassifier -
it is not
Maybe the java version can also be upgraded to 1.8 New plugin and start
with 1.7 is a special requirement for it?
pt., 15 sty 2021 o 12:50 Elliotte Rusty Harold
napisał(a):
> I noticed this code i
We've already discussed this.
The name is intended to be generic and can be seen as a "brother" of the
maven-dependency-plugin.
Where the dependency plugin handles the (dependency) graph, the artifact plugin
is about the (artifact) file.
I expect more goals to be added.
thanks,
Robert
On 15-1-20
Where possible I'd try to replace plexus utils such as StringUtils and
FileUtils with better maintained JDK or Apache commons alternatives.
On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote:
>
> I want to release Maven Artifact Plugin soon, version 0.1
>
> I did a first documentation:
> https:/
There are some good integration tests. Unit tests would help round this out.
Most classes and method appear public by default. It's not obvious
they need to be. I think almost all of them could be private or
package private instead. They can always be made public later if a
need is uncovered, but
The use of PrintWriter in BuildInfoWriter is error prone because it
swallows exceptions. This should be replaced with an
OutputStreamWriter.
On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote:
>
> I want to release Maven Artifact Plugin soon, version 0.1
>
> I did a first documentation:
> https:
I noticed this code in ReferenceBuildInfo:
Artifact buildinfo =
artifactFactory.createArtifactWithClassifier(
project.getGroupId(), project.getArtifactId(),
project.getVersion(), "buildinfo", "" );
The problem is that ArtifactFactory is deprecated and has been fo
The name of this plugin, Maven Artifact Plugin, seems very generic. It
really gives no indication of its purpose. Perhaps consider a rename
at this early stage to maven-buildinfo-plugin or
maven-reproduce-plugin.
On Thu, Jan 14, 2021 at 7:10 PM Hervé BOUTEMY wrote:
>
> I want to release Maven Art
Hi Hervé,
As far as I understood the docs, the _buildinfo_ goal has 2 purposes:
1. generate the .buildinfo file
2. optionally check it against some reference
Shouldn't these two use cases be provided by two different goals?
By having them in the same goal the "reference.repo" property "pollutes"
I want to release Maven Artifact Plugin soon, version 0.1
I did a first documentation:
https://maven.apache.org/plugins-archives/maven-artifact-plugin-LATEST/
review, feedback, PRs welcome
Regards,
Hervé
-
To unsubscribe,
On 08/07/2008, at 3:28 AM, Igor Fedorenko wrote:
Brett,
Out of curiosity. It seems that your fix for MARTIFACT-25 only
caches missing pom.xml lookup. Where is the logic that will prevent
maven from repeatedly hitting remote repositories for actual
artifacts?
I'd looked at the linked is
Brett,
Out of curiosity. It seems that your fix for MARTIFACT-25 only caches
missing pom.xml lookup. Where is the logic that will prevent maven from
repeatedly hitting remote repositories for actual artifacts?
Brett Porter wrote:
Hi Oleg,
I think you are good to go now for the release. I've
Igor just found another problem, in the Wagon manager downloading
things repeatedly. We're going to take a look at that.
On 7-Jul-08, at 1:08 PM, Brett Porter wrote:
Hi Oleg,
I think you are good to go now for the release. I've fixed the
additional issues that I'd found.
I'm just running
Hi Oleg,
I think you are good to go now for the release. I've fixed the
additional issues that I'd found.
I'm just running the integration tests again locally to confirm, but
I'd say go for it whenever you're ready. All the instructions are on
the site for setting up settings, signatures,
On 05/07/2008, at 1:51 AM, Oleg Gusakov wrote:
John - are you looking into this? Need it resolved for MNG-3185
I've done it in the way John was suggesting - it's not the perfect
solution but it's the best one available I think.
I stumbled upon an API regression that breaks one of servicem
On 05/07/2008, at 1:44 AM, Jason van Zyl wrote:
Are you dropping new files into the local repository or integrating
this as part of the metadata? Do these files only work locally?
The current impl, from what I've seen of it, drops properties files
into the local repository only, and doesn'
John - are you looking into this? Need it resolved for MNG-3185
Thanks,
Oleg
Brett Porter wrote:
On 04/07/2008, at 3:40 AM, John Casey wrote:
Not to distract from the higher-level discussion, but I'd like to get
into the nuts and bolts of MARTIFACT-25 a bit...in case someone beats
me to it.
Are you dropping new files into the local repository or integrating
this as part of the metadata? Do these files only work locally?
Also in the case of 2.1 we should also consider just not allowing the
state where there is no POM. Consider the artifact not complete
without a POM.
On 4-Jul
On 04/07/2008, at 3:40 AM, John Casey wrote:
Not to distract from the higher-level discussion, but I'd like to
get into the nuts and bolts of MARTIFACT-25 a bit...in case someone
beats me to it.
We introduced a properties file that tracks resolution attempts for
artifacts that weren't fo
Oleg,
Do you want to try and do this Sunday/Monday. Even though it's alpha-1
and really only affects 2.1-alpha we should let it bake for the week
and possibly spit out an RC or two. If this goes out Monday and we do
some vetting I can make the proposed schedule of 14 July for 2.1-
alpha-1.
Brett Porter wrote:
Hi all,
As I indicated a couple of weeks back, moving towards a 2.1 alpha
release, I was looking at releasing an alpha of maven-artifact. Brian
was able to locate the issue he was referring to a couple of weeks
back about re-resolving (now MARTIFACT-25), so I've postpone
Not to distract from the higher-level discussion, but I'd like to get
into the nuts and bolts of MARTIFACT-25 a bit...in case someone beats me
to it.
We introduced a properties file that tracks resolution attempts for
artifacts that weren't found on the remote repository, and I'd like to
see
Hi all,
As I indicated a couple of weeks back, moving towards a 2.1 alpha
release, I was looking at releasing an alpha of maven-artifact. Brian
was able to locate the issue he was referring to a couple of weeks
back about re-resolving (now MARTIFACT-25), so I've postponed.
Once that's fix
Correct.
On 29-Feb-08, at 3:28 AM, Brett Porter wrote:
I assume this is the current trunk and not the CAP branch?
On 29/02/2008, at 5:34 PM, Jason van Zyl wrote:
John/Mark,
You have anything that you want to put in maven-artifact as I'm
going to start making alphas. I'll take a look at th
I assume this is the current trunk and not the CAP branch?
On 29/02/2008, at 5:34 PM, Jason van Zyl wrote:
John/Mark,
You have anything that you want to put in maven-artifact as I'm
going to start making alphas. I'll take a look at the one issue
scheduled for m-a, let you guys add anything
Nope, go for it!
Mark
On 29/02/2008, Jason van Zyl <[EMAIL PROTECTED]> wrote:
> John/Mark,
>
> You have anything that you want to put in maven-artifact as I'm going
> to start making alphas. I'll take a look at the one issue scheduled
> for m-a, let you guys add anything you were working on an
John/Mark,
You have anything that you want to put in maven-artifact as I'm going
to start making alphas. I'll take a look at the one issue scheduled
for m-a, let you guys add anything you were working on and then
squeeze it out to prepare for a 2.1-alpha-1.
Thanks,
Jason
---
36 matches
Mail list logo
