Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-09 Thread Tibor Digana
One more hint. What if the start element was added as NULL by an accident? What if the impl of LinkedList ignores such element and then there are N - 1 elements to remove. Adding an asset may help to find it. On Sun, Dec 9, 2018 at 8:00 PM Tibor Digana wrote: > I have checked everything, includi

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-09 Thread Tibor Digana
I have checked everything, including the commit hash, the change, trigger and log. It's undeterministic run as you said. What happens if you simply use ArrayDeque instead of LinkedList? How can we identify it's the problem of strings conc and List impl? Perhaps only by giving a try several times an

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-09 Thread Robert Scholte
For your interest, just hit it again: https://builds.apache.org/job/maven-box/job/maven-javadoc-plugin/job/MJAVADOC-543/ First run only fails for Build windows-jdk7-m3.2.x_build, with the j.u.NoSuchElementException A rerun without any changes,now it luckily succeeds. Robert On Sun, 09 Dec 2

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-09 Thread Robert Scholte
I've found a few NoSuchElementException + LinkedList issues, although not in combination with removeLast() But this made it clear for me there have been issues with LinkedList... Robert On Sun, 09 Dec 2018 17:35:45 +0100, Tibor Digana wrote: Is the issue found on Oracle Jira or bug repor

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-09 Thread Tibor Digana
Is the issue found on Oracle Jira or bug report? This might to do with some build version in Java 1.7. Usually they fix it right after since this bug hits the JVM stability and Oracle is paying an attention to JIT stability. On Sun, Dec 9, 2018 at 4:36 PM Robert Scholte wrote: > I have to admi

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-09 Thread Robert Scholte
I have to admit that it still looks weird, but the open and close tags are balanced. Also notice that only Java 7 (sometimes) hits this issue. Gabriel was able to provide a test that always fails on Java 7, not on the other JDKs. It must have to do with optimization when the JVM is warmed up.

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-08 Thread Enrico Olivelli
+1 for Tibor's explanation. Enrico Il sab 8 dic 2018, 12:29 Tibor Digana ha scritto: > PluginDescriptorGenerator.writeDescriptor does not use Threads so it must > be the problem that the number of calls "endElement" is greater than calls > "startElement". > > https://github.com/apache/maven-plug

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-08 Thread Tibor Digana
PluginDescriptorGenerator.writeDescriptor does not use Threads so it must be the problem that the number of calls "endElement" is greater than calls "startElement". https://github.com/apache/maven-plugin-tools/blob/master/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/gen

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-12-08 Thread Tibor Digana
I do not think it can be such JVM issue with string concatenations, otherwise all the world has the same problem. This type of issue is usually caused by multiple writes from multiple threads. Try to log every method with Thread id and we should see multiple ids. The java.io is supposed to be synch

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-11-30 Thread Gabriel Belingueres
I'll go for a minimal patch commenting with the rationale, and then build upon that. I also tested it will work if execute maven disabling string concatenation optimization: MAVEN_OPTS=-XX:-OptimizeStringConcat which could used as a workaround for the short term. El vie., 30 de nov. de 2018 a la(

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-11-30 Thread Robert Scholte
Interesting if that works, but if the concatenation is the issue, we could also try: write( "" ); If this doesn't work but your proposed code does, it must have a good comment that this is a Java 7 workaround and can only be optimized once we require Java 8. I have also another idea: rep

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-11-29 Thread Hervé BOUTEMY
wow, nice idea I noticed the issue for a long time, but never figured out the link with Java 7 nor this idea of fix that is so "magic"... thank you for the help Regards, Hervé Le vendredi 30 novembre 2018, 05:11:56 CET Gabriel Belingueres a écrit : > Indeed, that seems to be the case. It magic

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-11-29 Thread Gabriel Belingueres
Indeed, that seems to be the case. It magically worked after replacing the following line: http://codehaus-plexus.github.io/plexus-utils/xref/org/codehaus/plexus/util/xml/PrettyPrintXMLWriter.html#L307 with this: String element = elementStack.removeLast(); write( "" ); I will soon create the issu

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-11-29 Thread Robert Scholte
At builds.apache.org: Java version: 1.7.0_79, vendor: Oracle Corporation Local Java version: 1.7.0_80, vendor: Oracle Corporation does seem to be Java7 only... I need to check this for a longer period, but might be a good conclusion. thanks, Robert On Thu, 29 Nov 2018 04:54:59 +0100, Gabriel

Re: plugin:descriptor fails with java.util.NoSuchElementException

2018-11-28 Thread Gabriel Belingueres
Hi Robert: I'm testing it and getting *consistently* the same exception with this config: Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T15:41:47-03:00) Maven home: C:\productos\apache-maven-3.6.0\bin\.. Java version: 1.7.0_80, vendor: Oracle Corporation, runtime: C:\Pro

plugin:descriptor fails with java.util.NoSuchElementException

2018-11-27 Thread Robert Scholte
Hi, sometimes the maven-plugin-plugin fails to write the plugin descriptor and exits with the exception below. I see the same unreliable behavior on our Jenkins servers too, re-running often fixes the issue. I have seen the issue several times locally when running with mvn.cmd, so far never