Re: opinions on MJAVADOC-451

2016-08-06 Thread Richard Sand
Hi all - the request for the skip-parameter started as a requirement to break an infinite loop. When I discovered how the plugin was used and told that binding the plugin to a different phase, the loop was gone. Even though, the request for the skip parameter stayed. Untrue. I opened MJAV

Re: opinions on MJAVADOC-451

2016-08-06 Thread Christian Schulte
Am 06.08.2016 um 11:35 schrieb Robert Scholte: fooled. So it must be javadoc:fix + compiler:compile + scm:commit. The Maven-way would be a lifecycle for things like that, right? Like the clean or site lifecycle. A general purpose "manage source code" lifecycle with phases like "prepare-main-s

Re: opinions on MJAVADOC-451

2016-08-06 Thread Christian Schulte
Am 08/06/16 um 11:35 schrieb Robert Scholte: > I consider the javadoc:fix goal in the same range as the release:prepare > release:perform combination (why as is everything executed twice) and > cobertura-maven-plugin (why are the tests executed twice) and the fix-goal > is probably even worse

Re: opinions on MJAVADOC-451

2016-08-06 Thread Robert Scholte
Hi all, the request for the skip-parameter started as a requirement to break an infinite loop. When I discovered how the plugin was used and told that binding the plugin to a different phase, the loop was gone. Even though, the request for the skip parameter stayed. I consider the javadoc

Re: opinions on MJAVADOC-451

2016-08-05 Thread Chas Honton
; >> From: "Richard Sand" >> To: dev@maven.apache.org >> Sent: 8/1/2016 6:33:30 PM >> Subject: opinions on MJAVADOC-451 >> >>> Hi all, >>> >>> I'd like to ask for opinions on >>> https://issues.apache.org/jira/browse/MJAV

Re: opinions on MJAVADOC-451

2016-08-05 Thread Gary Gregory
On Fri, Aug 5, 2016 at 3:51 PM, Christopher wrote: > On Fri, Aug 5, 2016 at 11:19 AM Gary Gregory > wrote: > > > On Aug 5, 2016 7:41 AM, "Benson Margulies" > wrote: > > > > > > On Fri, Aug 5, 2016 at 10:37 AM, Christopher > > wrote: > > > > I'm always in favor of adding skip properties. They a

Re: opinions on MJAVADOC-451

2016-08-05 Thread Richard Sand
What about putting the skip option into an abstract base plugin class? Just thinking out loud Sent from my iPhone > On Aug 5, 2016, at 6:51 PM, Christopher wrote: > >> On Fri, Aug 5, 2016 at 11:19 AM Gary Gregory wrote: >> >>> On Aug 5, 2016 7:41 AM, "Benson Margulies" wrote: >>> >>> On Fr

Re: opinions on MJAVADOC-451

2016-08-05 Thread Christopher
On Fri, Aug 5, 2016 at 11:19 AM Gary Gregory wrote: > On Aug 5, 2016 7:41 AM, "Benson Margulies" wrote: > > > > On Fri, Aug 5, 2016 at 10:37 AM, Christopher > wrote: > > > I'm always in favor of adding skip properties. They are very useful for > > > manipulating builds for debugging, running on

Re: opinions on MJAVADOC-451

2016-08-05 Thread Gary Gregory
ard > >> > >> ------ Original Message -- > >> > >> From: "Richard Sand" > >> To: dev@maven.apache.org > >> Sent: 8/1/2016 6:33:30 PM > >> Subject: opinions on MJAVADOC-451 > >> > >> >Hi all, > >>

Re: opinions on MJAVADOC-451

2016-08-05 Thread Benson Margulies
; Anyone want to give this a quick read/opinion? :-) >> >> -Richard >> >> -- Original Message -- >> >> From: "Richard Sand" >> To: dev@maven.apache.org >> Sent: 8/1/2016 6:33:30 PM >> Subject: opinions on MJAVADOC-451 >> &

Re: opinions on MJAVADOC-451

2016-08-05 Thread Christopher
4, 2016, 11:47 Richard Sand wrote: > Anyone want to give this a quick read/opinion? :-) > > -Richard > > -- Original Message -- > > From: "Richard Sand" > To: dev@maven.apache.org > Sent: 8/1/2016 6:33:30 PM > Subject: opinions on MJAVADOC-451 >

Re: opinions on MJAVADOC-451

2016-08-04 Thread Richard Sand
Anyone want to give this a quick read/opinion? :-) -Richard -- Original Message -- From: "Richard Sand" To: dev@maven.apache.org Sent: 8/1/2016 6:33:30 PM Subject: opinions on MJAVADOC-451 Hi all, I'd like to ask for opinions on https://issues.apache.org/jira/brow

opinions on MJAVADOC-451

2016-08-01 Thread Richard Sand
Hi all, I'd like to ask for opinions on https://issues.apache.org/jira/browse/MJAVADOC-451. Robert Scholte and I have been discussing this off list and essentially disagree on it. The request is very simple - to add a "skip" parameter to the javadoc:fix goal. In my projects we are using the