Re: merging MNG-6115-2 branch to master

2017-03-12 Thread Hervé BOUTEMY
MNG-6186 created to track the issue https://issues.apache.org/jira/browse/MNG-6186 Le dimanche 12 mars 2017, 17:18:06 CET Hervé BOUTEMY a écrit : > Le samedi 11 mars 2017, 15:05:18 CET Stephen Connolly a écrit : > > +1 from me. > > > > Obviously would be better if upstream was fixed that we didn

Re: merging MNG-6115-2 branch to master

2017-03-12 Thread Hervé BOUTEMY
Le samedi 11 mars 2017, 15:05:18 CET Stephen Connolly a écrit : > +1 from me. > > Obviously would be better if upstream was fixed that we didn't need the > copy&paste but pragmatism says this is the fix for 3.5.0 > > Extra brownie points for raising the issue upstream and fencing the > additions

Re: merging MNG-6115-2 branch to master

2017-03-11 Thread Karl Heinz Marbaise
+1 from me.. Kind regards Karl Heinz On 11/03/17 17:47, Robert Scholte wrote: +1 On Sat, 11 Mar 2017 16:05:18 +0100, Stephen Connolly wrote: +1 from me. Obviously would be better if upstream was fixed that we didn't need the copy&paste but pragmatism says this is the fix for 3.5.0 Extra b

Re: merging MNG-6115-2 branch to master

2017-03-11 Thread Robert Scholte
+1 On Sat, 11 Mar 2017 16:05:18 +0100, Stephen Connolly wrote: +1 from me. Obviously would be better if upstream was fixed that we didn't need the copy&paste but pragmatism says this is the fix for 3.5.0 Extra brownie points for raising the issue upstream and fencing the additions with co

Re: merging MNG-6115-2 branch to master

2017-03-11 Thread Stephen Connolly
+1 from me. Obviously would be better if upstream was fixed that we didn't need the copy&paste but pragmatism says this is the fix for 3.5.0 Extra brownie points for raising the issue upstream and fencing the additions with comments to say "TODO rework/remove when jansi fixes XYZ-123" On Sat 11

merging MNG-6115-2 branch to master

2017-03-11 Thread Hervé BOUTEMY
there has been some discussion about the way to solve temp file creation for native libs used by JAnsi https://issues.apache.org/jira/browse/MNG-6115 Is it ok to merge MNG-6115-2 branch with this commit http://git-wip-us.apache.org/repos/asf/maven/commit/c36cf425 to master? Regards, Hervé