Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Jason van Zyl
+1 On Feb 21, 2015, at 12:24 PM, Robert Scholte wrote: > multiModuleProjectDirectory sounds indeed good enough > > Op Sat, 21 Feb 2015 17:48:10 +0100 schreef Igor Fedorenko > : > >> Not sure. "top level" and "base" don't sound that much different to me. >> And, frankly, don't add much clarify

Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Robert Scholte
multiModuleProjectDirectory sounds indeed good enough Op Sat, 21 Feb 2015 17:48:10 +0100 schreef Igor Fedorenko : Not sure. "top level" and "base" don't sound that much different to me. And, frankly, don't add much clarify to the term either. Maybe it should be "multiModuleProjectDirectory",

Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Igor Fedorenko
Not sure. "top level" and "base" don't sound that much different to me. And, frankly, don't add much clarify to the term either. Maybe it should be "multiModuleProjectDirectory", i.e. without "base" or "top level" adjective? -- Regards, Igor On 2015-02-21 11:27, Robert Scholte wrote: It's len

Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Robert Scholte
It's lengthly, but indeed better. And now that we don't care about its length, how about TopLevelDirectory instead of BaseDirectory, just to reflect that it is has nothing to with the location of uber module-parent like in a flattened multimodule structure? Robert Op Sat, 21 Feb 2015 16:4

Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Igor Fedorenko
Correct. What I called "projectBaseDirectory" represents root directory of a multimodule project. It is not related to parent/child relationship among project modules. And it is not the same as "reactor base directory" as it is currently implemented, but I agree reactor build should behave like yo

Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Jason van Zyl
Technically the reactor right now are the projects in modules from where you start the build. I think what this variable is trying to represent is the base directory of the multi-module project. I would argue that, ultimately, the reactor base directory should be the same as the multi-module p

Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Robert Scholte
Op Sat, 21 Feb 2015 14:12:22 +0100 schreef Igor Fedorenko : On 2015-02-21 7:02, Robert Scholte wrote: Hi Igor, I agree that something like MNG-5767 can indeed help with the experience. Looking at the implementation I find the name projectBaseDirectory confusing, I would have thought tha

Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Igor Fedorenko
On 2015-02-21 7:02, Robert Scholte wrote: Hi Igor, I agree that something like MNG-5767 can indeed help with the experience. Looking at the implementation I find the name projectBaseDirectory confusing, I would have thought that this is a per project(module) baseDirectory. We already have thin

Re: maven git commit: MNG-5767 .mvn/ for project specific jvm options and maven parameters

2015-02-21 Thread Robert Scholte
Hi Igor, I agree that something like MNG-5767 can indeed help with the experience. Looking at the implementation I find the name projectBaseDirectory confusing, I would have thought that this is a per project(module) baseDirectory. We already have things like project.basedir and project.exe