Re: maven-jar-plugin fixes to be reviewed committed

2006-05-15 Thread jerome lacoste
On 5/15/06, Brett Porter <[EMAIL PROTECTED]> wrote: Heh, this was 13/4 not 14/5 as I thought. Time flies, right? Are these still needing to be looked at? Yes So here's a little update :) patch management - review MJAR-27 - let me know if you really want a test case or apply. - review

Re: maven-jar-plugin fixes to be reviewed committed

2006-05-14 Thread Brett Porter
Heh, this was 13/4 not 14/5 as I thought. Are these still needing to be looked at? Brett Porter wrote: I'm not going to have time this week (and I'm utterly sick of working on plugins right now :) Anyone else available? jerome lacoste wrote: On 4/12/06, jerome lacoste <[EMAIL PROTECTED]> wr

Re: maven-jar-plugin fixes to be reviewed committed

2006-05-14 Thread Brett Porter
I'm not going to have time this week (and I'm utterly sick of working on plugins right now :) Anyone else available? jerome lacoste wrote: On 4/12/06, jerome lacoste <[EMAIL PROTECTED]> wrote: Hi Fellow Riders of the Lost good code, Message to the commiters of the plexus-archiver and maven-

Re: maven-jar-plugin fixes to be reviewed committed

2006-04-13 Thread jerome lacoste
On 4/12/06, jerome lacoste <[EMAIL PROTECTED]> wrote: > Hi Fellow Riders of the Lost good code, Message to the commiters of the plexus-archiver and maven-jar-plugin. patch management - please apply MJAR-32, MJAR-35, MJAR-6, PLX-185 - review MJAR-27 - let me know if you really want a test case or

Re: maven-jar-plugin fixes to be reviewed committed

2006-04-12 Thread jerome lacoste
On 4/13/06, Tim Kettler <[EMAIL PROTECTED]> wrote: > I just deleted my local repo and checked out the latest versions of the jar > and webstart > plugins from svn and can't reproduce the second NPE from MJAR-31 anymore. So > this is fixed > somehow already (at least for me). Thanks for the repor

Re: maven-jar-plugin fixes to be reviewed committed

2006-04-12 Thread Tim Kettler
I just deleted my local repo and checked out the latest versions of the jar and webstart plugins from svn and can't reproduce the second NPE from MJAR-31 anymore. So this is fixed somehow already (at least for me). -Tim jerome lacoste schrieb: On 4/13/06, Brett Porter <[EMAIL PROTECTED]> wrot

Re: maven-jar-plugin fixes to be reviewed committed

2006-04-12 Thread jerome lacoste
On 4/13/06, Brett Porter <[EMAIL PROTECTED]> wrote: > jerome lacoste wrote: > > There were 2 potential NPE reported in that issue. One was already > > fixed as a side effect to another bug fix. The other one, I want to be > > able to understand how it can happen (e.g. if the NPE is just caused > >

Re: maven-jar-plugin fixes to be reviewed committed

2006-04-12 Thread Brett Porter
jerome lacoste wrote: There were 2 potential NPE reported in that issue. One was already fixed as a side effect to another bug fix. The other one, I want to be able to understand how it can happen (e.g. if the NPE is just caused by a user configuration/usage error, I won't push the proposed patch

Re: maven-jar-plugin fixes to be reviewed committed

2006-04-12 Thread jerome lacoste
On 4/12/06, Carlos Sanchez <[EMAIL PROTECTED]> wrote: > Jerome, the way to go with bugs is first create a test case that > exploits the bug, so test fails, and then fix it. When i don't see a > test case patch I cannot be sure that the patch is really fixing that > problem, and that it won't happen

Re: maven-jar-plugin fixes to be reviewed committed

2006-04-12 Thread Carlos Sanchez
Jerome, the way to go with bugs is first create a test case that exploits the bug, so test fails, and then fix it. When i don't see a test case patch I cannot be sure that the patch is really fixing that problem, and that it won't happen again. If you follow this guidelines I'm pretty sure that an

maven-jar-plugin fixes to be reviewed committed

2006-04-12 Thread jerome lacoste
Hi Fellow Riders of the Lost good code, Would appreciate if someone was to review/commit patches attached to MJAR-32 and MJAR-27 and maybe comment on http://tinyurl.com/fle9y so that I can identify if the last bit in the issue really needs to be fixed (if so please apply the fix pasted in the comm