Re: maven-compat in public API

2020-07-04 Thread Elliotte Rusty Harold
maven-file-management seems much more broadly used. I'm not sure we can get rid of it. I tried pulling it out of maven-jar-plugin but it seems more critical there, unless there's some other way to manage filesets and patterns I don't know about. INFO] +- org.apache.maven.shared:file-management:jar

Re: maven-compat in public API

2020-07-03 Thread Robert Scholte
That good news. Call me Dr Deprecator of Maven Git Repos, I can call a vote soon. Robert On 3-7-2020 21:56:40, Elliotte Rusty Harold wrote: Indeed it does seem possible to remove maven-assembly-plugin's dependency on maven-shared-io by copying a few classes from one into the other and making the

Re: maven-compat in public API

2020-07-03 Thread Elliotte Rusty Harold
Indeed it does seem possible to remove maven-assembly-plugin's dependency on maven-shared-io by copying a few classes from one into the other and making them non-public. Removing file-management from the maven-dependency-plugin was even easier. We should probably formally deprecate maven-shared-i

Re: maven-compat in public API

2020-07-03 Thread Elliotte Rusty Harold
Looks like we can also remove the dependency from file-management to maven-shared-io, again by copying a few classes into file-management. I don't know if we can remove file-management completely. On Thu, Jul 2, 2020 at 5:05 PM Robert Scholte wrote: > > The migration guide is about plugins, not a

Re: maven-compat in public API

2020-07-03 Thread Elliotte Rusty Harold
I think we can remove it from the maven-assembly-pluign by copying two or three classes into that plugin and making them non-public. On Thu, Jul 2, 2020 at 5:05 PM Robert Scholte wrote: > > The migration guide is about plugins, not about libraries. > For libraries it can be tricky. > > However, b

Re: maven-compat in public API

2020-07-02 Thread Robert Scholte
The migration guide is about plugins, not about libraries. For libraries it can be tricky. However, based on  https://mvnrepository.com/artifact/org.apache.maven.shared/maven-shared-io [https://mvnrepository.com/artifact/org.apache.maven.shared/maven-shared-io]  the usage is quite low. There are

maven-compat in public API

2020-07-02 Thread Elliotte Rusty Harold
MSHARED-931 is a specific example of a problem I've run into in many plugins while trying to upgrade to Maven 3. https://issues.apache.org/jira/projects/MSHARED/issues/MSHARED-931 Per https://cwiki.apache.org/confluence/display/MAVEN/Plugin+migration+to+Maven3+dependencies part of this work is t