Re: maven-assembly-plugin / Maven default folder layout

2014-03-14 Thread Mirko Friedenhagen
Hello Karl-Heinz, I thought you said appassembler would put configs wrongly into src/main/config instead of src/config. Now it seems the stuff is included in the artifact. IMO stuff going into the artifact should be beneath src/main while configs for e.g. plugins should go to src/config (say check

Re: maven-assembly-plugin / Maven default folder layout

2014-03-14 Thread Dennis Lundberg
Hi, Did you change from src/main/config to src/config on purpose? In this case (i.e. when using the appassembler plugin) it really should be src/main/config, because the contents of that directory will end up in the main artifact. Similar to resources which might not be required at compile time,

Re: maven-assembly-plugin / Maven default folder layout

2014-03-14 Thread Karl Heinz Marbaise
Hi Mirko, so someone should maybe file an issue in the appassembler-maven-plugin, I think the layout you provided is reasonable. Why for the appassembler-maven-plugin ? It currently uses src/config ? Should appassembler-maven-plugin stop using src/config ? Hm... Kind regards Karl-Heinz Marb

Re: maven-assembly-plugin / Maven default folder layout

2014-03-14 Thread Karl Heinz Marbaise
Hi Mirko, > Karl-Heinz, so someone should maybe file an issue in the appassembler-maven-plugin, I think the layout you provided is reasonable. done so. http://jira.codehaus.org/browse/MNGSITE-195 Kind regards Karl-Heinz Marbaise Regards Mirko -- http://illegalstateexception.blogspot.com/

Re: maven-assembly-plugin / Maven default folder layout

2014-03-14 Thread Mirko Friedenhagen
Karl-Heinz, so someone should maybe file an issue in the appassembler-maven-plugin, I think the layout you provided is reasonable. Regards Mirko -- http://illegalstateexception.blogspot.com/ https://github.com/mfriedenhagen/ (http://osrc.dfm.io/mfriedenhagen) https://bitbucket.org/mfriedenhagen/

Re: maven-assembly-plugin / Maven default folder layout

2014-03-14 Thread Karl Heinz Marbaise
Hello Dennis, > src/main/config is used as the default value for configuration files in appassembler-maven-plugin @Mojo. Ah damn...Just forgot about that...;-) Thanks for that hint. On Tue, Mar 11, 2014 at 9:57 PM, Karl Heinz Marbaise wrote: Hi, On 3/9/14 9:02 PM, Karl Heinz Marbaise w

Re: maven-assembly-plugin / Maven default folder layout

2014-03-14 Thread Karl Heinz Marbaise
Hi, so based on the discussion we can conclude the result as follows: src/main * are files required during compile time (production) src/main/java src/main/resources src/main/filters src/test * are files required during test time (unit testing; based on naming s

Re: maven-assembly-plugin / Maven default folder layout

2014-03-12 Thread Dennis Lundberg
src/main/config is used as the default value for configuration files in appassembler-maven-plugin @Mojo. On Tue, Mar 11, 2014 at 9:57 PM, Karl Heinz Marbaise wrote: > Hi, > > > On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: >> >> So based on the discussion could we go with the following: >> >> /sr

Re: maven-assembly-plugin / Maven default folder layout

2014-03-12 Thread Robert Scholte
It could be used for build-time configuration files, which are not part of the artifact / shouldn't be available on the classpath. I've never used it. I think it's too rare, so I agree that it can be removed. Robert Op Tue, 11 Mar 2014 21:57:43 +0100 schreef Karl Heinz Marbaise : Hi, On

Re: maven-assembly-plugin / Maven default folder layout

2014-03-11 Thread Karl Heinz Marbaise
Hi, On 3/9/14 9:02 PM, Karl Heinz Marbaise wrote: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integrat

Re: maven-assembly-plugin / Maven default folder layout

2014-03-11 Thread Karl Heinz Marbaise
Hi Michael, You forgot: src/site. No, cause it's already part of the default folder layout. Kind Regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h..

Re: maven-assembly-plugin / Maven default folder layout

2014-03-10 Thread Karl Heinz Marbaise
Hi Michael, > Always use a relative path in the docs otherwise it could be misinterpreted. Of course you are right.. Kind regards Karl-Heinz Marbaise - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional c

Re: maven-assembly-plugin / Maven default folder layout

2014-03-10 Thread Dennis Lundberg
Hi Michael, I do not want to enforce any real or precieved connection between a phase and an assembly. As you say, there is no such thing for assemblies. They are either triggered implicitly during the package phase och explicitly using an execution. On Sun, Mar 9, 2014 at 11:41 AM, Michael Osip

Re: maven-assembly-plugin / Maven default folder layout

2014-03-10 Thread Dennis Lundberg
Hi Robert, I think we are talking past each other here. From what you are writing we seem to agree that having an assembly for stuff in the src/test directory doesn't make little sense. I'm not opposed to changing things that are not working well. I'm just trying to make sure that the change will

Re: maven-assembly-plugin / Maven default folder layout

2014-03-09 Thread Michael-O
Am 2014-03-09 21:02, schrieb Karl Heinz Marbaise: So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integrati

Re: maven-assembly-plugin / Maven default folder layout

2014-03-09 Thread Anders Hammar
Sounds good to me. /Anders On Sun, Mar 9, 2014 at 9:02 PM, Karl Heinz Marbaise wrote: > So based on the discussion could we go with the following: > > /src/main >* are files required during compile time (production) > > /src/test >* are files required during test time (unit testing; bas

Re: maven-assembly-plugin / Maven default folder layout

2014-03-09 Thread Karl Heinz Marbaise
So based on the discussion could we go with the following: /src/main * are files required during compile time (production) /src/test * are files required during test time (unit testing; based on naming schema we could also have integration tests here) /src/it * are files required dur

Re: maven-assembly-plugin / Maven default folder layout

2014-03-09 Thread Michael Osipov
Am 2014-03-08 22:24, schrieb Dennis Lundberg: Hi I agree with Karl Heinz that the Assembly Plugin should support the documented default directory. It seems that we disagree about what the preferred directory should be. I think it should be src/main/assembly/ because almost all assemblies I have

Re: maven-assembly-plugin / Maven default folder layout

2014-03-09 Thread Robert Scholte
I would call it advancing insight. I can't think of an assembly which is only for unittesting (due to the src/test folder) and won't be attached the the MavenProject for deployment. For users it would make it clear: everything under /src/main are files required during compile time everything

Re: maven-assembly-plugin / Maven default folder layout

2014-03-08 Thread Dennis Lundberg
Hi Robert, I was not thinking about scope here, just the directory structure of the project. We've used src/main/assembly for years now. Maven-core has its assembly descriptors in src/main/assembly. It seems strange to suddenly change it. In what way would our users benefit from this change? On

Re: maven-assembly-plugin / Maven default folder layout

2014-03-08 Thread Robert Scholte
Hi Dennis, an assembly will always result in an attachment, but there's no such thing as attaching with a scope. For that reason I wouldn't separate the assembly descriptors, it might cause invalid assumptions. Robert Op Sat, 08 Mar 2014 22:24:10 +0100 schreef Dennis Lundberg : Hi I

Re: maven-assembly-plugin / Maven default folder layout

2014-03-08 Thread Dennis Lundberg
Hi I agree with Karl Heinz that the Assembly Plugin should support the documented default directory. It seems that we disagree about what the preferred directory should be. I think it should be src/main/assembly/ because almost all assemblies I have ever seen are for the main part of a project. I

Re: maven-assembly-plugin / Maven default folder layout

2014-03-08 Thread Karl Heinz Marbaise
Hi Robert, > I've changed the location and published the site Robert You have been faster than I ;-) Kind regards Karl-Heinz Op Sat, 08 Mar 2014 00:14:02 +0100 schreef Hervé BOUTEMY : +1 Regards, Hervé Le vendredi 7 mars 2014 20:25:04 Robert Scholte a écrit : Hi, This is the standard

Re: maven-assembly-plugin / Maven default folder layout

2014-03-08 Thread Robert Scholte
I've changed the location and published the site Robert Op Sat, 08 Mar 2014 00:14:02 +0100 schreef Hervé BOUTEMY : +1 Regards, Hervé Le vendredi 7 mars 2014 20:25:04 Robert Scholte a écrit : Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I

Re: maven-assembly-plugin / Maven default folder layout

2014-03-07 Thread Hervé BOUTEMY
+1 Regards, Hervé Le vendredi 7 mars 2014 20:25:04 Robert Scholte a écrit : > Hi, > > This is the standard (preferred) directory layout, so it doesn't have to > be the default. > I actually think that src/main/assembly/ should be src/assembly/, > otherwise it would imply that there can also be

Re: maven-assembly-plugin / Maven default folder layout

2014-03-07 Thread Michael Osipov
Am 2014-03-07 20:25, schrieb Robert Scholte: Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate th

Re: maven-assembly-plugin / Maven default folder layout

2014-03-07 Thread Michael Osipov
Am 2014-03-07 20:25, schrieb Robert Scholte: Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate th

Re: maven-assembly-plugin / Maven default folder layout

2014-03-07 Thread Robert Scholte
Hi, This is the standard (preferred) directory layout, so it doesn't have to be the default. I actually think that src/main/assembly/ should be src/assembly/, otherwise it would imply that there can also be a src/test/assembly/. I wouldn't separate the descriptors into different folders.

maven-assembly-plugin / Maven default folder layout

2014-03-07 Thread Karl Heinz Marbaise
Hi, I stumbled over a small thing. The page about the default folder layout https://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html mentioned a location for the maven-assembly-plugin descriptors: src/main/assembly/ So the location is a suggestion to loc