Re: jvm.config and spaces

2021-02-01 Thread Romain Manni-Bucau
Why? This is not about changing IFS for maven opts but for jvm.config read then all the script still uses the default. It is very close to just writing the jvm.config parsing instead of just handling it with a pipe bypassing needed escaping, no? Romain Manni-Bucau @rmannibucau

Re: jvm.config and spaces

2021-02-01 Thread Michael Osipov
Am 2021-02-01 um 11:47 schrieb Benjamin Marwell: Eval is probably needed, just look at how open liberty merges those lines [1]. As a user, I would expect spaces and comments to be supported. [1]: https://github.com/OpenLiberty/open-liberty/blob/bd54569d3322c4321a7dda4fcf94d65f85bf13bf/dev/com.

Re: jvm.config and spaces

2021-02-01 Thread Romain Manni-Bucau
+1 to do something close to IBM script or have a graalvm light launcher (if we manage to make it < 10M but I doubt :(). Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github

Re: jvm.config and spaces

2021-02-01 Thread Benjamin Marwell
Eval is probably needed, just look at how open liberty merges those lines [1]. As a user, I would expect spaces and comments to be supported. [1]: https://github.com/OpenLiberty/open-liberty/blob/bd54569d3322c4321a7dda4fcf94d65f85bf13bf/dev/com.ibm.ws.kernel.boot.ws-server/publish/bin/server#L69

Re: jvm.config and spaces

2021-02-01 Thread Michael Osipov
Am 2021-01-29 um 21:51 schrieb Romain Manni-Bucau: Hi all, Is it intended our jvm.config impl does not support spaces? -Dfoo=bar dummy "-Dfoo=bar dummy" '-Dfoo=bar dummy' -Dfoo=bar\ dummy Likely related to https://issues.apache.org/jira/browse/MNG-4559. I see no way to solve this with POSIX s

jvm.config and spaces

2021-01-29 Thread Romain Manni-Bucau
Hi all, Is it intended our jvm.config impl does not support spaces? -Dfoo=bar dummy "-Dfoo=bar dummy" '-Dfoo=bar dummy' -Dfoo=bar\ dummy All these options don't work - which can be surprising when you are used to bash. Fun thing is that if you take of them which should work and append echo befor