Re: https://github.com/apache/maven-scm/pull/17

2014-09-16 Thread Chris Graham
Hi Benson, Perfect! Exactly what I was looking for! Thanks! -Chris On Mon, Sep 15, 2014 at 8:16 PM, Benson Margulies wrote: > Chris, See > > http://maven.apache.org/developers/conventions/git.html. > > I didn't know it existed until yesterday. > > > On Mon, Sep 15, 2014 at 1:26 AM, Chris Gra

Re: https://github.com/apache/maven-scm/pull/17

2014-09-15 Thread Benson Margulies
Chris, See http://maven.apache.org/developers/conventions/git.html. I didn't know it existed until yesterday. On Mon, Sep 15, 2014 at 1:26 AM, Chris Graham wrote: > So, if the scm stuff is in git, my original question still remains > unanswered. > > What are the process steps needed to go thr

Re: https://github.com/apache/maven-scm/pull/17

2014-09-14 Thread Chris Graham
So, if the scm stuff is in git, my original question still remains unanswered. What are the process steps needed to go through to be able to perform meaningful work in terms of working on the maven-scm modules? Has anyone actually documented what needs doing on the git side of things? Creating a

Re: https://github.com/apache/maven-scm/pull/17

2014-09-14 Thread Benson Margulies
Here is the situation, as I've documented in MRELEASE-875: Using the trunk of the maven-release-plugin + SCM 1.9.1, and using either git 1.8.5.2 or git 2.1, the problem is fixed as I see it. The contents of the pull request suggest that it was not fixed for the person who made the pull request, bu

Re: https://github.com/apache/maven-scm/pull/17

2014-09-11 Thread Benson Margulies
Robert has looked into this in more detail, and think the trail points back into SCM. As per info I've added to the JIRA, it is not caused by git barking at the release.properties and pom.xml.xxx file; if you add those to .gitignore, they disappear from the scene, but it still does not work. I'm ho

Re: https://github.com/apache/maven-scm/pull/17

2014-09-11 Thread Benson Margulies
A mixture. The release plugin had not moved. On Sep 10, 2014 11:46 PM, "Chris Graham" wrote: > Sorry, I thought that the plugins, the scm ones in this case, had moved to > git? Still in SVN? If so, then no issues. > > -Chris > > On Thu, Sep 11, 2014 at 11:43 AM, Benson Margulies > wrote: > > > F

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Chris Graham
Sorry, I thought that the plugins, the scm ones in this case, had moved to git? Still in SVN? If so, then no issues. -Chris On Thu, Sep 11, 2014 at 11:43 AM, Benson Margulies wrote: > For plugins, you need mostly to make an account on Codehaus JIRA, then you > svn checkout as per the informatio

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Benson Margulies
For plugins, you need mostly to make an account on Codehaus JIRA, then you svn checkout as per the information in the plugin's page, and then you can attach a patch to a JIRA. On Wed, Sep 10, 2014 at 9:37 PM, Chris Graham wrote: > Whilst not strictly related to this thread... > > Is there a do

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Chris Graham
Whilst not strictly related to this thread... Is there a document that tells us what we need to do to contribute? How/what repos we need to clone/setup, how to generate a patch/pull request etc? Thanks, -Chris On Thu, Sep 11, 2014 at 7:04 AM, Benson Margulies wrote: > Of course; I'm just tryi

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Benson Margulies
Of course; I'm just trying to help you get off the ground; is there something else you'd like me to do? On Wed, Sep 10, 2014 at 4:58 PM, Robert Scholte wrote: > I don't want to depend on external systems. > you could add me (rfscholte) but that'll only be for reproducing the issue. > and then I

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Robert Scholte
I don't want to depend on external systems. you could add me (rfscholte) but that'll only be for reproducing the issue. and then I need isolate the problem and translate it to a unittest. Op Wed, 10 Sep 2014 22:53:38 +0200 schreef Benson Margulies : Well, you'll need to push a clone where y

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Benson Margulies
Well, you'll need to push a clone where you can write, or tell me your github ID so I can add you as a collaborator. On Wed, Sep 10, 2014 at 4:45 PM, Robert Scholte wrote: > The first step already fails on my machine. > > mvn release:prepare release:perform -B -DpushChanges=false > > I'm a bit s

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Robert Scholte
The first step already fails on my machine. mvn release:prepare release:perform -B -DpushChanges=false I'm a bit surprised, because I see: [INFO] Executing: cmd.exe /X /C "git push g...@github.com:bimargulies/pom-file-name-tc.git refs/heads/master:refs/heads/master" Actual failure: [ERROR]

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Benson Margulies
Step 1: in the top level dir of the example, run mvn --batch-mode release:prepare release:perform. All will be well. A repo will populate in /tmp. Step 2: modify pom in 'second' directory to use the just-release parent pom, commit, push. Step 3: mvn release:prepare in second directory. No errors

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Robert Scholte
that's just the beginning... so: how did you execute it? what did you get? what would you expect? Op Wed, 10 Sep 2014 20:54:49 +0200 schreef Benson Margulies : Aha, I have one for you. https://github.com/bimargulies/pom-file-name-tc. I attached it to a dup JIRA which I closed, or you can ta

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Benson Margulies
Aha, I have one for you. https://github.com/bimargulies/pom-file-name-tc. I attached it to a dup JIRA which I closed, or you can take it as you see it. You may in general find MRELEASE-887 helpful in this respect. On Wed, Sep 10, 2014 at 2:53 PM, Robert Scholte wrote: > Hi, > > IIRC I didn't hav

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Robert Scholte
Hi, IIRC I didn't have enough info to make a unittest, i.e. reproduce what they get right now and what they would expect to be able to fix it. That would take me too much time to find out, so I left this one open for now. thanks, Robert Op Wed, 10 Sep 2014 20:23:07 +0200 schreef Benson Mar

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Benson Margulies
Yes, the remarks which dribbled off pointed to adapting the fix back into the m-r-p. On Wed, Sep 10, 2014 at 2:21 PM, Karl Heinz Marbaise wrote: > Hi Benson, > > > Is anyone working on a fix to MRELEASE-875? > >> >> > Based on JIRA it is assigned to Dominik Bartholdi which requested reviews > f

Re: https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Karl Heinz Marbaise
Hi Benson, > Is anyone working on a fix to MRELEASE-875? Based on JIRA it is assigned to Dominik Bartholdi which requested reviews from others on Github... BTW: Not working on that... Kind regards Karl-Heinz Marbaise --

https://github.com/apache/maven-scm/pull/17

2014-09-10 Thread Benson Margulies
Is anyone working on a fix to MRELEASE-875?