Re: git commit: MNG-5530 Introduced mojo execution guice component scope

2013-11-27 Thread Igor Fedorenko
On 11/27/2013, 3:08, Hervé BOUTEMY wrote: Le samedi 23 novembre 2013 11:43:54 Igor Fedorenko a écrit : but it's good to see a new idea like that tell me if I can help more than with this feedback Do you have any specific maven plugin in mind where this feature can be useful? Not for the mo

Re: git commit: MNG-5530 Introduced mojo execution guice component scope

2013-11-27 Thread Hervé BOUTEMY
Le samedi 23 novembre 2013 11:43:54 Igor Fedorenko a écrit : > > but it's good to see a new idea like that > > > > tell me if I can help more than with this feedback > > Do you have any specific maven plugin in mind where this feature can be > useful? Not for the moment. That's exactly why i was

Re: git commit: MNG-5530 Introduced mojo execution guice component scope

2013-11-23 Thread Igor Fedorenko
On 11/23/2013, 10:57, Hervé BOUTEMY wrote: nice new feature a few remarks: - IMHO, such a feature deserve a 3.2 Maven version instead of 3.1.2 I don't feel particularly strong about this. On one hand, this does not introduce any user-visible change in behaviour, so from user point of view t

Re: git commit: MNG-5530 Introduced mojo execution guice component scope

2013-11-23 Thread Hervé BOUTEMY
nice new feature a few remarks: - IMHO, such a feature deserve a 3.2 Maven version instead of 3.1.2 - explanations in the commit comment are a good start for a documentation page in the component, no? - for the TODOs in MojoExecutionListener interface, I think both methods should be added, be