Re: annotations support in compiler mojo

2010-03-30 Thread Milos Kleint
to me, projects that have their own annotation processors are a bit corner-case. We should have a documented approach for that situation for sure. To me the workaround with resource:copy goal that copies the META-INF/services/xxx entry *after* compilation sounds like the best solution. Milos On

Re: annotations support in compiler mojo

2010-03-30 Thread Mark Hobson
On 29 March 2010 10:35, Milos Kleint wrote: > yes, one place when this issue arises is when your own project defines a > annotation processor of it's own. See > http://jira.codehaus.org/browse/MCOMPILER-97 Hmm, maybe we'll have to split the compiler plugin up into two different executions for pro

Re: annotations support in compiler mojo

2010-03-29 Thread Milos Kleint
Hello Mark, On Mon, Mar 29, 2010 at 10:39 AM, Mark Hobson wrote: > >> Obviously this is complicated if we're also compiling too. > > > > Yes, you would have to somehow recognize this upfront and pass -proc:none > to > > avoid processing? but how do you figure? > > > > the current netbeans ann

Re: annotations support in compiler mojo

2010-03-29 Thread Mark Hobson
Hi Milos, Sorry for the delay again, I've been away from code for a while. On 6 March 2010 13:27, Milos Kleint wrote: > I see. I think the regular compilation classpath shall be the default >  though. The question is how to encode this special processor path? is there > a way to encode elements

Re: annotations support in compiler mojo

2010-03-06 Thread Milos Kleint
On Fri, Mar 5, 2010 at 6:38 PM, Mark Hobson wrote: > Hi Milos, > > Apologies for the delayed reply. See my responses inline: > > On 25 February 2010 09:10, Milos Kleint wrote: > > Hello Mark, > > > > what are the required feaures you are after? From the glimpse at the apt > > plugin, I got the

Re: annotations support in compiler mojo

2010-03-05 Thread Mark Hobson
Hi Milos, Apologies for the delayed reply. See my responses inline: On 25 February 2010 09:10, Milos Kleint wrote: > Hello Mark, > > what are the required feaures you are after? From the glimpse at the apt > plugin, I got the impression that it has quite a lot of configuration, some > I didn't

Re: annotations support in compiler mojo

2010-02-25 Thread Milos Kleint
Hello Mark, what are the required feaures you are after? From the glimpse at the apt plugin, I got the impression that it has quite a lot of configuration, some I didn't completely understand.. here's what already implemented in code -proc parameter to turn aannotation processing off, or enable it

Re: annotations support in compiler mojo

2010-02-25 Thread Milos Kleint
Well, the javac executable is caapable of doing both jobs (compile and process annotations) simultaneously. And with reasonable defaults we can make the annotation processing work out of the box for majority of people. Having a special plugin for it, with comfiguration etc would make it more compli

Re: annotations support in compiler mojo

2010-02-10 Thread Mark Hobson
Late reply on this one, but I'm certainly interested in seeing apt support added to maven-compiler-plugin. There is already a separate plugin for apt over at Mojo, apt-maven-plugin [1]. I worked on this a while back to get it into shape and am currently using it in production. I'd be happy to se

Re: annotations support in compiler mojo

2010-02-10 Thread nicolas de loof
Would such a dedicated plugin only apply annotation processing or replace compiler plugin ? This may implies duplicate configuration for compiler + annotation-processing plugins. Also consider slower build process as javac will need to parse source code 2 times. (late) +1 for annotations support i

Re: annotations support in compiler mojo

2010-02-10 Thread Brian Fox
Does it make sense to create a plugin specifically for annotation processing? On Sat, Jan 30, 2010 at 3:06 AM, Milos Kleint wrote: > can I read silence as lazy consensus to add annotation processing to the > compiler plugin? > > Milos > > On Mon, Jan 25, 2010 at 2:48 PM, Milos Kleint wrote: > >>

Re: annotations support in compiler mojo

2010-01-30 Thread Milos Kleint
can I read silence as lazy consensus to add annotation processing to the compiler plugin? Milos On Mon, Jan 25, 2010 at 2:48 PM, Milos Kleint wrote: > Hello, > > I'd like to start a discussion about how annotations are supported in maven > builds. I'm currently trying to use some NetBeans Platf

annotations support in compiler mojo

2010-01-25 Thread Milos Kleint
Hello, I'd like to start a discussion about how annotations are supported in maven builds. I'm currently trying to use some NetBeans Platform based annotations in maven projects and I'm encountering some problems. 1. http://jira.codehaus.org/browse/MCOMPILER-98 - -sourcepath needs to be always se