Re: WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-20 Thread Neeme Praks
Ok, I'm on vacation next week, but when I get back in the beginning of Feb, I will check back here to see if you have reached some conclusion about the best approach to take. Thanks, Neeme Stephane Nicoll wrote: There are a set of pending issues in the war plugin that really should be address

Re: WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-19 Thread Jörg Schaible
Stephane Nicoll wrote at Dienstag, 19. Januar 2010 08:49: > The old behavior can be re-worked in a way it is mostly backward > compatible. Regarding the naming issues, we can change it in a way the > bundled jar file follows the same convention as the "attached" jar file > (this is purely automate

Re: WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-18 Thread Stephane Nicoll
The old behavior can be re-worked in a way it is mostly backward compatible. Regarding the naming issues, we can change it in a way the bundled jar file follows the same convention as the "attached" jar file (this is purely automated so it shouldn't make a single difference unless people are hackin

Re: WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-18 Thread Jason van Zyl
I honestly don't have time to look right now, but I would be fine with 2 provided there were tests. You can't break the old behavior even if you think it's wrong. Document it, let people try it and if folks agree we can make it the default in the next major release. On 2010-01-18, at 8:35 AM, N

Re: WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-18 Thread Neeme Praks
I wrote the following comment in JIRA, but there is no response, so I will send it also here. --- quote --- I can rework the patch, I just need to know, what the behavior should be: 1. by default turn on the consistent behavior (as the old behavior seems quite broken to me) and the user can en

Re: WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-11 Thread Neeme Praks
Thanks, created issue: http://jira.codehaus.org/browse/MWAR-215 Stephane Nicoll wrote: Please create a Jira issue[1] if none has been created already and attach your patch. The inconsistency is coming from the way those settings were implemented and to preserve backward compatibility. The check

Re: WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-11 Thread Stephane Nicoll
Please create a Jira issue[1] if none has been created already and attach your patch. The inconsistency is coming from the way those settings were implemented and to preserve backward compatibility. The checksum issue was overlooked truth be told. Thanks, Stéphane [1] http://jira.codehaus.org/br

Re: WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-11 Thread Neeme Praks
Hi again, It's now been 6 days since I wrote this e-mail and no response so far. Does anybody care about the WAR plugin or is it homeless and abandoned? :-P Or, maybe someone can form an opinion, based on some sort of gut feeling or some best-practice for Maven plugins? I would love to get

WAR plugin and class file handling (archiveClasses and attachClasses options)

2010-01-05 Thread Neeme Praks
Hi all, I have a couple of issues with the current WAR plugin and the way it packages class files in JAR files (archiveClasses and attachClasses configuration options), as these two options work independently of each other: * archiveClasses moves all class files (and related resources) from