Re: Upcoming Maven Resolver 1.9.8

2023-04-12 Thread Tamás Cservenák
Howdy, ok, then I see no other impediment for 1.9.8, release is about to happen soon. Thanks T On Sun, Apr 9, 2023 at 5:18 PM Elliotte Rusty Harold wrote: > I think so, assuming there's a new cut > > On Wed, Apr 5, 2023 at 11:58 AM Tamás Cservenák > wrote: > > > > Eliotte, > > > > I hope all

Re: Upcoming Maven Resolver 1.9.8

2023-04-09 Thread Elliotte Rusty Harold
I think so, assuming there's a new cut On Wed, Apr 5, 2023 at 11:58 AM Tamás Cservenák wrote: > > Eliotte, > > I hope all your concerns are addressed. > Please approve PR if so, and with that, assume you "lifted" your -1 :) > > Thanks > T > > On Wed, Apr 5, 2023 at 1:35 PM Guillaume Nodet wrote:

Re: Upcoming Maven Resolver 1.9.8

2023-04-05 Thread Tamás Cservenák
Eliotte, I hope all your concerns are addressed. Please approve PR if so, and with that, assume you "lifted" your -1 :) Thanks T On Wed, Apr 5, 2023 at 1:35 PM Guillaume Nodet wrote: > I've raised a new PR to re-deprecate StringUtils and inline it's usages: > > https://github.com/apache/maven-

Re: Upcoming Maven Resolver 1.9.8

2023-04-05 Thread Guillaume Nodet
I've raised a new PR to re-deprecate StringUtils and inline it's usages: https://github.com/apache/maven-resolver/pull/277 Le mer. 5 avr. 2023 à 13:30, Elliotte Rusty Harold a écrit : > That's still a halfway measure. And we shouldn't move the public > StringUtils package without a deprecation

Re: Upcoming Maven Resolver 1.9.8

2023-04-05 Thread Elliotte Rusty Harold
That's still a halfway measure. And we shouldn't move the public StringUtils package without a deprecation cycle anyway. This is public API that can be used in projects that are not part of this repo or the Apache Maven project. So I propose: 1. Keep StringUtils in deprecated form for now, to be r

Re: Upcoming Maven Resolver 1.9.8

2023-04-05 Thread Tamás Cservenák
I agree with you regarding duplication, this really adds "yet another" StringUtils to classpath. OTOH, I do see a value to drop non trivial (by size) dependency for sparse use. How about this proposal: given un-deprecated StringUtils is used ONLY in (and below) package org.eclipse.aether.internal

Re: Upcoming Maven Resolver 1.9.8

2023-04-05 Thread Elliotte Rusty Harold
I'm -1 on this release. I specifically disagree with the undeprecation of maven-resolver-util/src/main/java/org/eclipse/aether/util/StringUtils.java in https://github.com/apache/maven-resolver/pull/275 We need fewer duplicate StringUtils classes in random packages, not more of them. If we don't wa

Upcoming Maven Resolver 1.9.8

2023-04-05 Thread Tamás Cservenák
Howdy, The Resolver 1.9.8 is done: https://issues.apache.org/jira/issues/?jql=project%20%3D%20MRESOLVER%20AND%20fixVersion%20%3D%201.9.8 If anyone has/knows/feels there is more to be done in 1.9.8, yell here please. Also, if anyone has free cycles, and this mail has no "more to be done" response