Re: The direct use of shaded classes

2008-07-11 Thread Hilco Wijbenga
On Fri, Jul 11, 2008 at 6:09 PM, Brett Porter <[EMAIL PROTECTED]> wrote: > IIRC, you're not able to use them at compile time with that name (which is > why anonymous inner classes are xxx$1, ...) That's just a convention. You can use $ in your class names. Not advisable but completely valid.

Re: The direct use of shaded classes

2008-07-11 Thread Brett Porter
IIRC, you're not able to use them at compile time with that name (which is why anonymous inner classes are xxx$1, ...) On 12/07/2008, at 3:10 AM, John Casey wrote: not sure I follow...how would that be different than changing the packaging? Brett Porter wrote: Is it possible to shade to so

Re: The direct use of shaded classes

2008-07-11 Thread John Casey
not sure I follow...how would that be different than changing the packaging? Brett Porter wrote: Is it possible to shade to something that would be illegal to use directly, like appending $shade to the class name, and still have it all work? - Brett On 11/07/2008, at 1:08 AM, Jason van Zyl w

Re: The direct use of shaded classes

2008-07-10 Thread Brett Porter
Is it possible to shade to something that would be illegal to use directly, like appending $shade to the class name, and still have it all work? - Brett On 11/07/2008, at 1:08 AM, Jason van Zyl wrote: I found two references to classes in Maven like: import hidden.org.codehaus.plexus... M

Re: The direct use of shaded classes

2008-07-10 Thread Benjamin Bentmann
Jason van Zyl wrote: import hidden.org.codehaus.plexus... Side note: The Checkstyle rule "IllegalImport" [0] could help to ban this. Benjamin [0] http://checkstyle.sourceforge.net/config_imports.html#IllegalImport - To un

Re: The direct use of shaded classes

2008-07-10 Thread John Casey
Not intentional at all. I have two of the classes revised here to use plexus interpolation directly, but if you've got the changes on trunk and 2.0.x already, I'll let you commit it. -john Jason van Zyl wrote: I found two references to classes in Maven like: import hidden.org.codehaus.plexus

Re: The direct use of shaded classes

2008-07-10 Thread Jason van Zyl
I found two references to classes in Maven like: import hidden.org.codehaus.plexus... Maybe your refactoring stuff grabbed hold of it. If that wasn't intentional I'll check in my changes. On 10-Jul-08, at 10:34 AM, John Casey wrote: I'm not sure what you're talking about, but I'll look into

Re: The direct use of shaded classes

2008-07-10 Thread John Casey
I'm not sure what you're talking about, but I'll look into it. Jason van Zyl wrote: John, I would just put the separated plexus utils in new packages. That shading along the way is going to be a nasty problem. Importing processed/shaded classes can only be a recipe for trouble. On 10-Jul-08

Re: The direct use of shaded classes

2008-07-10 Thread Jason van Zyl
John, I would just put the separated plexus utils in new packages. That shading along the way is going to be a nasty problem. Importing processed/shaded classes can only be a recipe for trouble. On 10-Jul-08, at 7:09 AM, Jason van Zyl wrote: John, I am assuming it's a mistake that you ar

The direct use of shaded classes

2008-07-10 Thread Jason van Zyl
John, I am assuming it's a mistake that you are directly using a shaded class in the FileProfileActivator? It was never intended that any source code actually import processed classes directly. There seems to be shaded bits all along the dependency chain now which was never my original in