Re: Synchronization issue with parallel downloads

2009-03-04 Thread Brett Porter
ok, next? :) (sorry, I should have picked this up the first time - it was a clear gap in the test coverage for the class since those exceptions were never being hit). - Brett On 03/03/2009, at 10:09 PM, Brett Porter wrote: This should be easy to replicate, I'll reopen the issue. On 03/0

Re: Synchronization issue with parallel downloads

2009-03-03 Thread Brett Porter
This should be easy to replicate, I'll reopen the issue. On 03/03/2009, at 10:07 PM, Benjamin Bentmann wrote: Hi, I just stumbled upon another issue with the parallel artifact resolution in 2.1.x: + Error stacktraces are turned on. [INFO] Scanning for projects... [INFO]

Re: Synchronization issue with parallel downloads

2009-03-03 Thread Benjamin Bentmann
Hi, I just stumbled upon another issue with the parallel artifact resolution in 2.1.x: + Error stacktraces are turned on. [INFO] Scanning for projects... [INFO] [INFO] Building Maven Integration Test :: Boostrap [INFO]

Re: Synchronization issue with parallel downloads

2009-02-25 Thread Brett Porter
This is resolved now. On 24/02/2009, at 1:49 AM, Brett Porter wrote: Thanks for pointing this out. I'll take a closer look tomorrow. My initial thoughts: - we might need to double check if it occurs more often on windows due to timing variance (I expect that got much less testing than othe

Re: Synchronization issue with parallel downloads

2009-02-23 Thread Brett Porter
Thanks for pointing this out. I'll take a closer look tomorrow. My initial thoughts: - we might need to double check if it occurs more often on windows due to timing variance (I expect that got much less testing than others :) - it was odd in the output that there seemed to be a lot of download

Re: Synchronization issue with parallel downloads

2009-02-21 Thread Paul Benedict
I just want to add that if the parallel resolution is delegating the dependency managing to a shared object, it would make more sense to synchronize the methods. Paul On Sat, Feb 21, 2009 at 8:09 AM, Paul Benedict wrote: > Benjamin, > > I suppose the result makes sense. In essence, Maven is beco

Re: Synchronization issue with parallel downloads

2009-02-21 Thread Paul Benedict
Benjamin, I suppose the result makes sense. In essence, Maven is becoming multi-threaded. What about wrapping the LinkedHashMap instances with Collections.synchronizedList()? Perhaps it is a natural progression of Maven's stability: 2.0.9 introduced one LinkedHashMap, 2.0.10 converted them all, an

Synchronization issue with parallel downloads

2009-02-21 Thread Benjamin Bentmann
Hi, seems like our fears have come true, Hudson just spit out the first issue that seems to be caused by the introduction of the parallel artifact resolution: [java] java.util.ConcurrentModificationException [java] at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:552)