Re: Surefire maintenance release

2019-04-26 Thread Benedikt Ritter
Am Do., 25. Apr. 2019 um 22:08 Uhr schrieb Enrico Olivelli < eolive...@gmail.com>: > FYI > I have staged the release artifacts at > https://repository.apache.org/content/repositories/maven-1500/ > and created the tag > > but I have to do some burocratic steps in JIRA before sending the > official

Re: Surefire maintenance release

2019-04-26 Thread Enrico Olivelli
Il giorno ven 26 apr 2019 alle ore 15:59 Stephane Nicoll ha scritto: > > Awesome, thanks a lot Enrico. Will give the staging release a try next week. Okay, Anyway I will start the official [VOTE] thread soon, today or tomorrow. Cheers Enrico > > Cheers, > S. > > On Thu, Apr 25, 2019 at 11:08

Re: Surefire maintenance release

2019-04-26 Thread Stephane Nicoll
Awesome, thanks a lot Enrico. Will give the staging release a try next week. Cheers, S. On Thu, Apr 25, 2019 at 11:08 PM Enrico Olivelli wrote: > FYI > I have staged the release artifacts at > https://repository.apache.org/content/repositories/maven-1500/ > and created the tag > > but I have to

Re: Surefire maintenance release

2019-04-25 Thread Enrico Olivelli
FYI I have staged the release artifacts at https://repository.apache.org/content/repositories/maven-1500/ and created the tag but I have to do some burocratic steps in JIRA before sending the official [VOTE] email I have sent other emails on this mailing list in order to complete my task @Stephan

Re: Surefire maintenance release

2019-04-25 Thread Enrico Olivelli
Staging the artifact now. It will take the whole day I guess Enrico Il mer 24 apr 2019, 13:21 Enrico Olivelli ha scritto: > Il giorno mer 24 apr 2019 alle ore 12:30 Tibor Digana > ha scritto: > > > > What a test has failed? > > In this CI job all tests have passed successfully and the job is "

Re: Surefire maintenance release

2019-04-24 Thread Enrico Olivelli
Il giorno mer 24 apr 2019 alle ore 12:30 Tibor Digana ha scritto: > > What a test has failed? > In this CI job all tests have passed successfully and the job is "blue". You are right ! My browser should have get messed somehow So we are good to go sorry for beeing so late Enrico > > On Wed, Ap

Re: Surefire maintenance release

2019-04-24 Thread Tibor Digana
What a test has failed? In this CI job all tests have passed successfully and the job is "blue". On Wed, Apr 24, 2019 at 8:28 AM Enrico Olivelli wrote: > I am sorry, > I had other priorities, this task is not still complete. > > Tests are still failing and this is weird because I think I saw the

Re: Surefire maintenance release

2019-04-23 Thread Enrico Olivelli
I am sorry, I had other priorities, this task is not still complete. Tests are still failing and this is weird because I think I saw them green. This is the link to the job https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-surefire/job/release%252F2.22.2/ Enrico Il gio 11 a

Re: Surefire maintenance release

2019-04-10 Thread Christian Stein
On Thu, Apr 11, 2019 at 8:09 AM Enrico Olivelli wrote: > This is the final branch from which I will cut the release. > https://github.com/apache/maven-surefire/tree/release/2.22.2 > > Re-launched Jenkins to check for the last time: > > https://builds.apache.org/job/maven-box/job/maven-surefire/jo

Re: Surefire maintenance release

2019-04-10 Thread Enrico Olivelli
This is the final branch from which I will cut the release. https://github.com/apache/maven-surefire/tree/release/2.22.2 Re-launched Jenkins to check for the last time: https://builds.apache.org/job/maven-box/job/maven-surefire/job/release%252F2.22.2/ Enrico Il giorno mer 10 apr 2019 alle ore 1

Re: Surefire maintenance release

2019-04-10 Thread Stephane Nicoll
Awesome work, thank you very much Enrico! On Wed, Apr 10, 2019 at 3:29 PM Enrico Olivelli wrote: > Sorry for the delay > > The work branch seems in good shape. > Now it is only a matter or cutting the release > > > Enrico > > Il lun 1 apr 2019, 16:09 Enrico Olivelli ha scritto: > > > > > > > Il

Re: Surefire maintenance release

2019-04-10 Thread Enrico Olivelli
Sorry for the delay The work branch seems in good shape. Now it is only a matter or cutting the release Enrico Il lun 1 apr 2019, 16:09 Enrico Olivelli ha scritto: > > > Il sab 30 mar 2019, 14:16 Enrico Olivelli ha > scritto: > >> I have created a PR for your work Stephane >> https://github.

Re: Surefire maintenance release

2019-04-01 Thread Enrico Olivelli
Il sab 30 mar 2019, 14:16 Enrico Olivelli ha scritto: > I have created a PR for your work Stephane > https://github.com/apache/maven-surefire/pull/225 > > I will do my best > I am still new to the release procedure, never cut a release for surefire > and we usually are only cutting releases from

Re: Surefire maintenance release

2019-03-30 Thread Enrico Olivelli
I have created a PR for your work Stephane https://github.com/apache/maven-surefire/pull/225 I will do my best I am still new to the release procedure, never cut a release for surefire and we usually are only cutting releases from master. Enrico Il gio 28 mar 2019, 00:34 Olivier Lamy ha scri

Re: Surefire maintenance release

2019-03-27 Thread Olivier Lamy
On Thu, 28 Mar 2019 at 03:14, Enrico Olivelli wrote: > Il mer 27 mar 2019, 18:10 Tibor Digana ha > scritto: > > > Enrico, what i maintenance release for you, 2.22.2-M1? > > > > 2.22.2 without suffix > +1 @Tibor if you are too busy maybe Enrico can cut the release if he has time. > > > Enrico

Re: Surefire maintenance release

2019-03-27 Thread Christian Stein
On Wed, Mar 27, 2019 at 6:14 PM Enrico Olivelli wrote: > Il mer 27 mar 2019, 18:10 Tibor Digana ha > scritto: > > > Enrico, what i maintenance release for you, 2.22.2-M1? > > > > 2.22.2 without suffix > > This.

Re: Surefire maintenance release

2019-03-27 Thread Enrico Olivelli
Il mer 27 mar 2019, 18:10 Tibor Digana ha scritto: > Enrico, what i maintenance release for you, 2.22.2-M1? > 2.22.2 without suffix Enrico > > > > > On Wed, Mar 27, 2019 at 6:07 PM Enrico Olivelli > wrote: > > > Stephane > > thank you so much. > > I think we will be able to cut a maintenainc

Re: Surefire maintenance release

2019-03-27 Thread Tibor Digana
Enrico, what i maintenance release for you, 2.22.2-M1? On Wed, Mar 27, 2019 at 6:07 PM Enrico Olivelli wrote: > Stephane > thank you so much. > I think we will be able to cut a maintenaince release soon with your > branch. > > Maybe you can join us in chat with https://s.apache.org/slack-invite

Re: Surefire maintenance release

2019-03-27 Thread Enrico Olivelli
Stephane thank you so much. I think we will be able to cut a maintenaince release soon with your branch. Maybe you can join us in chat with https://s.apache.org/slack-invite #maven channel Enrico Il giorno mer 27 mar 2019 alle ore 15:45 Tibor Digana ha scritto: > > Stephane, What exists in our

Re: Surefire maintenance release

2019-03-27 Thread Tibor Digana
Stephane, What exists in our agreement are two issues (SUREFIRE-1546 and SUREFIRE-1614), you will have them but no multiple releases (not effective in the perspectives of out spare time). We need people like you who will support us in 3.0.0-M4. This is the main goal. The issues SUREFIRE-1546 and SU

Re: Surefire maintenance release

2019-03-27 Thread Stephane Nicoll
On Tue, Mar 26, 2019 at 12:26 PM Tibor Digana wrote: > Stephane, > > >> I wanted to make sure that the JUnit5 story was functional > > I really don't like politics. What's that supposed to mean? If you want to quote something, please quote the full sentence. The full sentence is *"I wanted to m

Re: Surefire maintenance release

2019-03-26 Thread Tibor Digana
Stephane, >> I wanted to make sure that the JUnit5 story was functional I really don't like politics. Did you see SUREFIRE-1614? It really does not break functionality (only affects logger) and SUREFIRE-1614 is not worth of making release with single improvement. If you want to be consistent, you

Re: Surefire maintenance release

2019-03-25 Thread Stephane Nicoll
Thanks for having a look Tibor! On Mon, Mar 25, 2019 at 4:37 PM Tibor Digana wrote: > The diff looks good. > > Stephane, I guess this only 50% work you wanted to have. > I wanted to make sure that the JUnit5 story was functional with the vintage engine and the current GA of surefire. It looks l

Re: Surefire maintenance release

2019-03-25 Thread Tibor Digana
The diff looks good. Stephane, I guess this only 50% work you wanted to have. Let's not make too many versions because this would be a precedent. Question about JUnit5 display name. Currently our solution turns XML file name and XML content to the textual display name and not fully qualified cla

Re: Surefire maintenance release

2019-03-25 Thread Tibor Digana
I'll check the diff. On Mon, Mar 25, 2019 at 3:38 PM Stephane Nicoll wrote: > Hey, > > Can someone working on surefire confirm the interest of creating that > branch in the main repo and kick-off a release if a review is satisfactory? > > Thanks! > S. > > > On Wed, Mar 13, 2019 at 4:09 PM Stepha

Re: Surefire maintenance release

2019-03-25 Thread Stephane Nicoll
Hey, Can someone working on surefire confirm the interest of creating that branch in the main repo and kick-off a release if a review is satisfactory? Thanks! S. On Wed, Mar 13, 2019 at 4:09 PM Stephane Nicoll wrote: > Hey, > > I've created a `2.22.x` branch based on the 2.22.1 tag and I've >

Re: Surefire maintenance release

2019-03-21 Thread Christian Stein
Hi Stéphane, due to JavaLand and other "business stuff", I'll plan to review your branch early next week. >From a first glimps, it looks good to me. Cheers, Christian On Wed, Mar 20, 2019 at 9:26 AM Enrico Olivelli wrote: > +1 > > Il mar 19 mar 2019, 22:29 Olivier Lamy ha scritto: > > > Soun

Re: Surefire maintenance release

2019-03-20 Thread Enrico Olivelli
+1 Il mar 19 mar 2019, 22:29 Olivier Lamy ha scritto: > Sounds good to have a maintenance release with this! > > On Thu, 14 Mar 2019 at 04:34, Enrico Olivelli wrote: > > > Very good! > > > > Enrico > > > > Il mer 13 mar 2019, 16:09 Stephane Nicoll ha > > scritto: > > > > > Hey, > > > > > > I'v

Re: Surefire maintenance release

2019-03-19 Thread Olivier Lamy
Sounds good to have a maintenance release with this! On Thu, 14 Mar 2019 at 04:34, Enrico Olivelli wrote: > Very good! > > Enrico > > Il mer 13 mar 2019, 16:09 Stephane Nicoll ha > scritto: > > > Hey, > > > > I've created a `2.22.x` branch based on the 2.22.1 tag and I've > > cherry-picked the

Re: Surefire maintenance release

2019-03-13 Thread Enrico Olivelli
Very good! Enrico Il mer 13 mar 2019, 16:09 Stephane Nicoll ha scritto: > Hey, > > I've created a `2.22.x` branch based on the 2.22.1 tag and I've > cherry-picked the issue we need to get proper support for the vintage > engine[1] > > This 2.22.2-SNAPSHOT works for our purpose so I was wonderin

Re: Surefire maintenance release

2019-03-13 Thread Stephane Nicoll
Hey, I've created a `2.22.x` branch based on the 2.22.1 tag and I've cherry-picked the issue we need to get proper support for the vintage engine[1] This 2.22.2-SNAPSHOT works for our purpose so I was wondering if more fixes could be backported and/or if someone would like to review those changes

Re: Surefire maintenance release

2019-02-28 Thread Christian Stein
Hi all, here are my 0.02 € on the two issues/PRs that went into Surefire 3.x already. *SUREFIRE-1546 "JUnit 5 display names"* Both, supporting "@DisplayName" and therefore also backporting https://issues.apache.org/jira/browse/SUREFIRE-1546 to the 2.x branch makes almost *no* sense to me. Suref

Re: Surefire maintenance release

2019-02-27 Thread Tibor Digana
Hi Stephane, We are talking only about these two commits [1]? Notice that 001e807 modifies file names to the verbose one which breaks backwards compatibility and this should not forcibly (by default) happen in your version/branch. Try to fork the project, make a local branch and then reset HEAD t

Re: Surefire maintenance release

2019-02-26 Thread Olivier Lamy
Hi Using slack is a good idea for discussion. But bear mind @ASF all decisions must appear on a mailing list or in a jira ticket. Interesting blog entry regarding this topic "If it didn’t happen on the mailing list, it didn’t happen." http://theapacheway.com/on-list/ think about timezone or people

Re: Surefire maintenance release

2019-02-26 Thread Tibor Digana
Stephane, I have been quite busy with other JUnit5 work - SUREFIRE-1585. Can you join us in the chat on Slack "the-asf.slack.com"? You will find the Channel named "surefire". Ping us as soon as you are ready and we will find some way. I am glad! Cheers Tibor On Mon, Feb 25, 2019 at 8:54 AM Stepha

Re: Surefire maintenance release

2019-02-26 Thread Stephane Nicoll
Thanks Robert. To emphasis on the goal, we'd like to get a GA release of surefire that fully supports JUnit 5 (including the use of the vintage engine) and we'd like to see if it would be possible to backport the two fixes I've mentioned. If there is an appetite for that, we're happy to help and t

Re: Surefire maintenance release

2019-02-25 Thread Robert Scholte
Let me guide this discussion a bit, because I see tends to go to the negative side, whereas I'd like to see this as an open and fair discussion. It is not up to us to decide what any company/organization policy is regarding versions. Putting yourself in the position of Pivotal it makes sense

Re: Surefire maintenance release

2019-02-25 Thread Tibor Digana
Sorry, in normal circumstances projects release BOM with dependencyManagement but not the pluginManagement. We did not break current users and so we split the entire work into multiple stages. The naming convention really is not a problem as you can see and Stephane confirmed it. So we made welcome

Re: Surefire maintenance release

2019-02-25 Thread Stephane Nicoll
Thanks for the reply. See my feedback below On Mon, Feb 25, 2019 at 11:20 AM Tibor Digana wrote: > Stephane, the problem is with Spring upgrade policy as I have understood. > > What about releasing RC4 for you? > It does not matter how you call it. We don't want to be in a position where our us

Re: Surefire maintenance release

2019-02-25 Thread Tibor Digana
Stephane, the problem is with Spring upgrade policy as I have understood. What about releasing RC4 for you? Do you really need to have SUREFIRE-1546 done? We do not want to enable it implicitly as it is done in master right now, and therefore M4 needs to take more time to enable this feature via c

Surefire maintenance release

2019-02-24 Thread Stephane Nicoll
Hi everyone, It's great to see the progress on Surefire 3.0 and I wanted to reach out to discuss a practicable problem with the 2.x line. There are a number of fixes for JUnit 5 that are only available in the 3.x line that isn't GA yet. [1][2] Putting my Spring Boot hat for a min, this actually p