Re: Strange ServiceLoader issue with Surefire and JDK 21 bytecode

2023-10-17 Thread Mark Raynsford
On 2023-10-16T13:59:05 +0200 Romain Manni-Bucau wrote: > Yes, this is the one I had in mind, think it comes from plexus transitive > deps. For reference: org.apache.maven.plugins maven-surefire-plugin 3.1.2

Re: Strange ServiceLoader issue with Surefire and JDK 21 bytecode

2023-10-16 Thread Romain Manni-Bucau
Yes, this is the one I had in mind, think it comes from plexus transitive deps. Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Github | LinkedIn

Re: Strange ServiceLoader issue with Surefire and JDK 21 bytecode

2023-10-16 Thread Mark Raynsford
On 2023-10-16T08:14:40 +0200 Romain Manni-Bucau wrote: > Hi, > > Didn't check in details but it can be the bytecode reader version we have > today in surefire is too old to read java 21 bytecode so it does not put > your module on module path but classpath so then, without > META-INF/services/x

Re: Strange ServiceLoader issue with Surefire and JDK 21 bytecode

2023-10-15 Thread Romain Manni-Bucau
Hi, Didn't check in details but it can be the bytecode reader version we have today in surefire is too old to read java 21 bytecode so it does not put your module on module path but classpath so then, without META-INF/services/x file it is not detected. Romain Manni-Bucau @rmannibucau

Strange ServiceLoader issue with Surefire and JDK 21 bytecode

2023-10-15 Thread Mark Raynsford
Hello! I'm seeing test failures when javac produces JDK 21 bytecode as opposed to JDK 20 bytecode: https://github.com/io7m/surefire-20231015 You'll need JDK 21. Essentially, `mvn package` will work, but `mvn -Dio7m.java.targetJavaVersion=21 package` will cause a test failure. The actual root s