Re: Status of new compiler plugin for Maven 4

2024-08-07 Thread Konrad Windszus
Hi Martin, First of all thanks a lot for the hard work. Much appreciated. However there is other compilers like the Groovy Eclipse Compiler (https://github.com/groovy/groovy-eclipse/blob/d6ac73c6ba4adadbd67c60bf130ad68f2284890f/extras/groovy-eclipse-compiler/src/main/java/org/codehaus/groovy/eclip

Re: Status of new compiler plugin for Maven 4

2024-07-27 Thread Martin Desruisseaux
I created a pull request for Maven core which fixes the issue that the new maven-compiler-plugin was facing (the confusion between "jar" and "test-jar"). With this fix, I'm starting to be able to compile the projects in my company with the new compiler. https://github.com/apache/maven/pull/

Re: Status of new compiler plugin for Maven 4

2024-07-23 Thread Martin Desruisseaux
Le 2024-07-23 à 10 h 50, András Péteri a écrit : Class "org.eclipse.jdt.internal.compiler.tool.EclipseCompiler" does implement this interface (…snip…) name() is a default method on javax.tools.Tool and this implementation leaves it as-is, so it will return an empty String. Looks good. I al

Re: Status of new compiler plugin for Maven 4

2024-07-23 Thread András Péteri
Class "org.eclipse.jdt.internal.compiler.tool.EclipseCompiler" does implement this interface (although I don't know if this is the exact class that is used for compilation within Maven builds): https://github.com/eclipse-jdt/eclipse.jdt.core/blob/8e630b6c235edaf7d6e757442b1ee2c5761b6021/org.eclipse

Re: Status of new compiler plugin for Maven 4

2024-07-23 Thread Martin Desruisseaux
Le 2024-07-23 à 05 h 20, Olivier Lamy a écrit : How to use ecj with those changes? Or any other external tool by using the executable configuration? The compiler needs to implement the following interface (I think it is the case of the Eclipse compiler, but didn't verified carefully): j

Re: Status of new compiler plugin for Maven 4

2024-07-23 Thread Martin Desruisseaux
Le 2024-07-23 à 01 h 15, Guillaume Nodet a écrit : Awesome work ! Does ECJ implement javax.tools API too ? Thanks! I did not tested the Eclipse compiler, but from my search on internet, I got the impression that yes it implements the javax.tools API too. If not the case, it should be possibl

Re: Status of new compiler plugin for Maven 4

2024-07-22 Thread Olivier Lamy
very good work. How to use ecj with those changes? Or any other external tool by using the executable configuration? On Tue, 23 Jul 2024 at 02:43, Martin Desruisseaux wrote: > > Hello all > > The work on a new maven-compiler-plugin [1] for Maven 4 has reached the > following state: > > * All ex

Re: Status of new compiler plugin for Maven 4

2024-07-22 Thread Guillaume Nodet
Le lun. 22 juil. 2024 à 18:41, Martin Desruisseaux a écrit : > > Hello all > > The work on a new maven-compiler-plugin [1] for Maven 4 has reached the > following state: > > * All existing JUnit tests pass > * Integration tests do not yet pass (I'm working on that) > * Plexus compiler depend

Status of new compiler plugin for Maven 4

2024-07-22 Thread Martin Desruisseaux
Hello all The work on a new maven-compiler-plugin [1] for Maven 4 has reached the following state: * All existing JUnit tests pass * Integration tests do not yet pass (I'm working on that) * Plexus compiler dependency completely removed (replaced by javax.tools) My current issue is that de