Il Mar 14 Lug 2020, 13:09 Elliotte Rusty Harold ha
scritto:
> On Tue, Jul 14, 2020 at 2:25 AM Olivier Lamy wrote:
> >
>
> > ***DO NOT CREATE PULL REQUEST FOR RIDICULOUS COMMIT WHICH DO NOT NEED
> REVIEW***
>
> IMHO all PRs need review for the same reason everything needs a test.
>
I see your pa
On Tue, Jul 14, 2020 at 2:25 AM Olivier Lamy wrote:
>
> ***DO NOT CREATE PULL REQUEST FOR RIDICULOUS COMMIT WHICH DO NOT NEED
> REVIEW***
IMHO all PRs need review for the same reason everything needs a test.
>From experience I know I can't tell the difference between PRs that
are too simple to
On Tue, 14 Jul 2020 at 16:37, Maarten Mulders wrote:
> Good part is, even though I followed the docs I couldn't get it to work
> for even one repo (maven-site). It still has the "Squash & merge" button.
>
> The guide I was proposing was for working with pull requests submitted
> by contributors,
Good part is, even though I followed the docs I couldn't get it to work
for even one repo (maven-site). It still has the "Squash & merge" button.
The guide I was proposing was for working with pull requests submitted
by contributors, not for creating them. So I wasn't planning to add any
words on
Well personally I'm happy to use it for myself...
so please don;t remove it.
One of the most important point of the guide could be
***DO NOT CREATE PULL REQUEST FOR RIDICULOUS COMMIT WHICH DO NOT NEED
REVIEW***
it's very noisy and useless notifications (especially because we get
from both gitbox a
Good point. I'll start by disabling the "Squash & merge" button using
asf.yaml for the repositories I have cloned locally.
Maarten
On 13/07/2020 22:03, Elliotte Rusty Harold wrote:
>>> So then the conclusion is, we can use Github for accepting & merging
>>> pull requests, but shouldn't use "Squas
> > So then the conclusion is, we can use Github for accepting & merging
> > pull requests, but shouldn't use "Squash & merge"?
Buttons that shouldn't be used can be turned off by project owners in
the repo settings. There's no need to bother devs with remembering
which buttons should and should n
nstructions on how to accept and incorporate it. Based on
> >> my own experiences with submitting patches to Maven through Github I
> >> came up with a short how-to.
> >>
> >> I have written it down in a short guide "Working with Github pull
>
d instructions on how to accept and incorporate it. Based on
>> my own experiences with submitting patches to Maven through Github I
>> came up with a short how-to.
>>
>> I have written it down in a short guide "Working with Github pull
>> requests" [1] whic
er day I was working on a pull request offered through Github. I
> couldn't find instructions on how to accept and incorporate it. Based on
> my own experiences with submitting patches to Maven through Github I
> came up with a short how-to.
>
> I have written it down in a short
guide "Working with Github pull
requests" [1] which I intent to publish on the Apache Maven site, under
"Maven Developer Centre / Committers". I would appreciate if some of you
could take a look and see if the guide makes sense.
Thanks,
Maarten
[1]
https://gitbox.apache.org/rep
11 matches
Mail list logo
