Re: Shade and it's many options for controlling output

2012-11-25 Thread Peter Janes
Anders Hammar wrote: >> The Enunciate plugin "attaches" its own artifact with a unique >artifactId. > > >Do you have an example of this? I checked the docs ( >http://enunciate.codehaus.org/executables.html#maven) and I can't see >this. The install and deploy goals are what I was referring to.

Re: Shade and it's many options for controlling output

2012-11-25 Thread Peter Janes
The Enunciate plugin "attaches" its own artifact with a unique artifactId. I'm not sure of the implementation details, but it's got its own install-artifact and deploy-artifact goals that do the work. (Just to note that there's at least one other plugin doing something similar, not to make a c

Re: Shade and it's many options for controlling output

2012-11-25 Thread Stephen Connolly
On 25 November 2012 22:14, Peter Janes wrote: > Anders Hammar wrote: > >> The Enunciate plugin "attaches" its own artifact with a unique >>> >> artifactId. >> >> >> Do you have an example of this? I checked the docs ( >> http://enunciate.codehaus.org/**executables.html#maven

Re: Shade and it's many options for controlling output

2012-11-25 Thread Peter Janes
Anders Hammar wrote: The Enunciate plugin "attaches" its own artifact with a unique artifactId. Do you have an example of this? I checked the docs ( http://enunciate.codehaus.org/executables.html#maven) and I can't see this. The install and deploy goals are what I was referring to. I'm no

Re: Shade and it's many options for controlling output

2012-11-25 Thread Anders Hammar
> The Enunciate plugin "attaches" its own artifact with a unique artifactId. Do you have an example of this? I checked the docs ( http://enunciate.codehaus.org/executables.html#maven) and I can't see this. > I'm not sure of the implementation details, but it's got its own > install-artifact and

Re: Shade and it's many options for controlling output

2012-11-25 Thread Peter Janes
The Enunciate plugin "attaches" its own artifact with a unique artifactId. I'm not sure of the implementation details, but it's got its own install-artifact and deploy-artifact goals that do the work. (Just to note that there's at least one other plugin doing something similar, not making a cl

Re: Shade and it's many options for controlling output

2012-11-25 Thread Benson Margulies
More thought leads me toward additional simplification. I don't see why individual plugins need individual settings of outputDirectory. If the output is going into the reactor, I think it should be, by convention, in the project output directory, period. This is related to Anders' hatred of finalN

Re: Shade and it's many options for controlling output

2012-11-25 Thread Stephen Connolly
I've had a look at the code. Kill it! On 25 November 2012 20:22, Benson Margulies wrote: > Given that all it turns out to *do* is to construct finalName, I am > perfectly willing to kill it. If bentmann decides to relax his vow of > never talking to us, I'm happy to hear what he says. > > > On

Re: Shade and it's many options for controlling output

2012-11-25 Thread Benson Margulies
Given that all it turns out to *do* is to construct finalName, I am perfectly willing to kill it. If bentmann decides to relax his vow of never talking to us, I'm happy to hear what he says. On Sun, Nov 25, 2012 at 2:58 PM, Stephen Connolly wrote: > No. Not expected to remember... But sometimes

Re: Shade and it's many options for controlling output

2012-11-25 Thread Stephen Connolly
No. Not expected to remember... But sometimes one does... especially bentmann in my experience ;-) On Sunday, 25 November 2012, Anders Hammar wrote: > Just a check, is one supposed to remember why one did something 4.5 years > ago? I can hardly remember what I did last week > > I'm currently

Re: Shade and it's many options for controlling output

2012-11-25 Thread Anders Hammar
Just a check, is one supposed to remember why one did something 4.5 years ago? I can hardly remember what I did last week I'm currently searching JIRA to see if I can find a ticket that would match Benjamin's fix. /Anders On Sun, Nov 25, 2012 at 8:45 PM, Stephen Connolly < stephen.alan.conn

Re: Shade and it's many options for controlling output

2012-11-25 Thread Stephen Connolly
So it is not to create the shaded artifact at a different coordinate without requiring the creation of an additional module? I agree it seems a tad insane, but if we could get bentmann to chime in as to what it is actually supposed to do, then I think we can make a correct decision... Of course t

Re: Shade and it's many options for controlling output

2012-11-25 Thread Benson Margulies
I am fairly depressed here, and I agree with Anders. The shadedArtifactId was added in svn rev 640405 by bbentman. The log for that change consists of: r640405 | bentmann | 2008-03-24 09:17:58 -0400 (Mon, 24 Mar 2008) | 1 l

Re: Shade and it's many options for controlling output

2012-11-25 Thread Anders Hammar
> I'm willing to go on a history expedition to see who added the > feature. The MavenProjectHelper API suports this feature, let alone > the naked MavenProject API. > I don't care who initially added this, just saying that if we're to do any changes here it should be to fix errors not to refine th

Re: Shade and it's many options for controlling output

2012-11-25 Thread Benson Margulies
Anders, I'm willing to go on a history expedition to see who added the feature. The MavenProjectHelper API suports this feature, let alone the naked MavenProject API. On Sun, Nov 25, 2012 at 2:06 PM, Anders Hammar wrote: >> > How would you attach an artifact with a DIFFERENT artifactId than the

Re: Shade and it's many options for controlling output

2012-11-25 Thread Anders Hammar
> > How would you attach an artifact with a DIFFERENT artifactId than the > > project? It doesn't make sense. > > This is *already* a feature of the plugin. I didn't invent it, I'm > just trying to clean up how your configure it. > Why would you try to clean up how to configure something that does

Re: Shade and it's many options for controlling output

2012-11-25 Thread Benson Margulies
On Sun, Nov 25, 2012 at 1:48 PM, Anders Hammar wrote: > How would you attach an artifact with a DIFFERENT artifactId than the > project? It doesn't make sense. This is *already* a feature of the plugin. I didn't invent it, I'm just trying to clean up how your configure it. > > I would vote for

Re: Shade and it's many options for controlling output

2012-11-25 Thread Anders Hammar
How would you attach an artifact with a DIFFERENT artifactId than the project? It doesn't make sense. I would vote for doing changes that make it impossible to use the plugin as I-would-like-to-create-any-file-the-way-i-used-to-with-Ant solution. I think that the possibilities to alter the final n

Shade and it's many options for controlling output

2012-11-25 Thread Benson Margulies
Shade has a collection of related parameters for controlling where the results end up. To me, they feel like a collection of individual items that are fairly confusing to the reader of the documentation. Since I'm planning to bump the major version and change the behavior, I'd like to consider rat