Re: Merged or separated logs WAS: SLF4J integration

2012-10-12 Thread Anders Hammar
> In the case of Cargo does it fork by default and there the logging is all > self-contained by virtue of running in its own VM? To be honest I don't know. I think it doesn't fork, but I could be wrong. But it doesn't really matter, Cargo was just one example. But after having spent some more ti

Re: Merged or separated logs WAS: SLF4J integration

2012-10-12 Thread Jason van Zyl
I believe we will be able to have more controlled "veins" of logging, or domain specific logging, once SLF4J is in place. For example if I'm interested only in plugin execution, or artifact resolution we will be able to do that. On Oct 12, 2012, at 9:22 AM, Anders Hammar wrote: >>> If all log

Re: Merged or separated logs WAS: SLF4J integration

2012-10-12 Thread Jason van Zyl
In the case of Cargo does it fork by default and there the logging is all self-contained by virtue of running in its own VM? On Oct 12, 2012, at 8:12 AM, Anders Hammar wrote: >> In the context of Maven, is there any added value in pluging having a >> separated logging environment? If there is n

Re: Merged or separated logs WAS: SLF4J integration

2012-10-12 Thread Anders Hammar
>> If all logging from the embedded framework gets directed to the Maven >> output console, it could get messy. I'm thinking something like how >> the surefire plugin works where the user is directed to the surefire >> reports for further problem info (stacktraces etc.) > those would be the cases w

Re: Merged or separated logs WAS: SLF4J integration

2012-10-12 Thread Stephen Connolly
On 12 October 2012 13:12, Anders Hammar wrote: > > In the context of Maven, is there any added value in pluging having a > > separated logging environment? If there is no added value, then merged > > logging is the way to go. > Going separate makes it very difficult for the end user to figure ou

Re: Merged or separated logs WAS: SLF4J integration

2012-10-12 Thread Anders Hammar
> In the context of Maven, is there any added value in pluging having a > separated logging environment? If there is no added value, then merged > logging is the way to go. Could one possible case be a plugin which embeds some "framework" which uses slf4j to log to it's own log file(s)? And in thi

Re: Merged or separated logs WAS: SLF4J integration

2012-10-12 Thread ceki
On 12.10.2012 00:01, Jason van Zyl wrote: > Ceki made some sample plugins and we'll post something tomorrow about > some options for integration. Basically Merged vs Mixed: do we want to > funnel everything into the the core logging backend, or let the plugin > completely decided by declaring bot

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
Just an update. Everything is happy again: https://builds.apache.org/view/M-R/view/Maven/job/core-integration-testing-maven-3-jdk-1.6/182/console I worked with Ceki to push out another version of SLF4J Simple which allows the customization of the WARN label. In our case, the ITs we have specific

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
On Oct 11, 2012, at 4:26 PM, ceki wrote: > Hello all, > > I've created a trivial plugin which uses slf4j for logging: > > https://github.com/ceki/foo-plugin > > It declares a dependency on slf4j-api and slf4j-jdk14 > > Here are my observations: > > 1) when running with maven 3.0.3 the slf4

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
alm and then we would be fine as >> well. >> >> >> Btw, instead of switching hardcoded from log4j to hardcoded slf4j we again >> do >> not gain much. I'd expect a pluggable/configurable mechanism here. >> >> >> >> LieGrue, >>

Re: SLF4J integration

2012-10-11 Thread Mark Struberg
sure not a show stopper. We just need to document it in a FAQ. I gonna refine the IT and check it in in the next days. LieGrue, strub - Original Message - > From: Mark Struberg > To: Maven Developers List > Cc: > Sent: Thursday, October 11, 2012 5:56 PM > Subje

Re: SLF4J integration

2012-10-11 Thread ceki
Hello all, I've created a trivial plugin which uses slf4j for logging: https://github.com/ceki/foo-plugin It declares a dependency on slf4j-api and slf4j-jdk14 Here are my observations: 1) when running with maven 3.0.3 the slf4j declaration is honored, i.e. logging goes through jul (slf4j-j

Re: SLF4J integration

2012-10-11 Thread Mark Struberg
: Benson Margulies > To: Maven Developers List ; Mark Struberg > > Cc: > Sent: Thursday, October 11, 2012 5:16 PM > Subject: Re: SLF4J integration > > On Thu, Oct 11, 2012 at 11:08 AM, Mark Struberg wrote: >> Benson, it's a pity that this happened to you, an

Re: SLF4J integration

2012-10-11 Thread Olivier Lamy
assloader problems alltogether. >> >> >> The only framework which might be ok would java.util.logging. Yea jul sucks >> as hell and if used badly it creates permgen issues and other side effects. >> But at least it doesnt create class clashes. >> >> The best we

Re: SLF4J integration

2012-10-11 Thread Benson Margulies
; as hell and if used badly it creates permgen issues and other side effects. > But at least it doesnt create class clashes. > > The best we could do is to provide a maven.plugin.Logger backend for slf4j. > > > > LieGrue, > strub > > > > > - Original Message

Re: SLF4J integration

2012-10-11 Thread Mark Struberg
b - Original Message - > From: Benson Margulies > To: Maven Developers List ; Mark Struberg > > Cc: > Sent: Thursday, October 11, 2012 2:14 PM > Subject: Re: SLF4J integration > > 1. I have an example of something. I don't quite know what. > > I wen

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
Ok, updated. Thanks. http://tesla.io/maven/logging-with-slf4j.html On Oct 11, 2012, at 10:34 AM, Anders Hammar wrote: > We should clarify that this is for Maven 3.1+, not Maven 3.0.x or Maven 2. > > /Anders > > On Thu, Oct 11, 2012 at 4:11 PM, Jason van Zyl wrote: >> That's fine, users don't

Re: SLF4J integration

2012-10-11 Thread Anders Hammar
We should clarify that this is for Maven 3.1+, not Maven 3.0.x or Maven 2. /Anders On Thu, Oct 11, 2012 at 4:11 PM, Jason van Zyl wrote: > That's fine, users don't seem to mind. > > I pretty much have a zero turn around for writing docs using the system I > have so that's I'm going to use while

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
That's fine, users don't seem to mind. I pretty much have a zero turn around for writing docs using the system I have so that's I'm going to use while iterating. The site plugin supports markdown so I have no problem copying it over when I'm done. You can review when you like. On Oct 11, 2012

Re: SLF4J integration

2012-10-11 Thread Olivier Lamy
AFAIK it's a modification and a new feature of Apache Maven code. So docs MUST be at Apache sources. Perso I won't review or have a look before you commit that @asf. 2012/10/11 Jason van Zyl : > > On Oct 11, 2012, at 9:46 AM, "Nord, James" wrote: > >> >> Hope that clears it up. >> > > Yup, thank

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
On Oct 11, 2012, at 9:46 AM, "Nord, James" wrote: > > Hope that clears it up. > Yup, thanks. http://tesla.io/maven/logging-with-slf4j.html > Regards, > > /James > > > > > ***

RE: SLF4J integration

2012-10-11 Thread Nord, James
> > The configuration section has a type (I hope) > > > > To configure logging with the SLF4J Simple you can edit the properties in > > the > ~/m2/conf/logging/simplelogger.properties file. > > > > I actually put it in the distribution as I figured it would not be changed > very > often, I just e

Re: SLF4J integration

2012-10-11 Thread Benson Margulies
1. I have an example of something. I don't quite know what. I went to release the buildnumber-maven-plugin from the mojo project, using 2.2.1. I got a murky error about slf4j, followed by a failure to find a 'dav' transport. So I patched in wagon-dav, and I now the only problem was the slf4j comp

Re: SLF4J integration

2012-10-11 Thread Mark Struberg
rub - Original Message - > From: Tamás Cservenák > To: Maven Developers List > Cc: > Sent: Thursday, October 11, 2012 1:39 PM > Subject: Re: SLF4J integration > > Here is one with slf4j + logback: > > https://github.com/sonatype/nexus-maven-plugins/tree/mas

Re: SLF4J integration

2012-10-11 Thread Tamás Cservenák
Here is one with slf4j + logback: https://github.com/sonatype/nexus-maven-plugins/tree/master/nexus-staging-maven-plugin and the logging related bits (like LogbackUtils) used in mojos are here: https://github.com/sonatype/mojo-commons Purpose of it: this plugin makes use of a SISU component (not

Re: SLF4J integration

2012-10-11 Thread Mark Struberg
om: ceki > To: Maven Developers List > Cc: > Sent: Thursday, October 11, 2012 1:26 PM > Subject: Re: SLF4J integration > > On 11.10.2012 12:43, Mark Struberg wrote: > >> ceki, really, this is perfect example why no container uses >> commons-logging anymore.  Do y

Re: SLF4J integration

2012-10-11 Thread ceki
On 11.10.2012 12:43, Mark Struberg wrote: > ceki, really, this is perfect example why no container uses > commons-logging anymore. Do you like to repeat these errors? > > I reiterate: there is a workaround by isolating this in > ClassWorlds. It is not yet there, but ff we like to use slf4j then

Re: SLF4J integration

2012-10-11 Thread ceki
On 11.10.2012 12:17, Anders Hammar wrote: A plugin declaring a dependency on slf4j-api without declaring a dependency on an implementation does not makes sense imo. It follows that the term "declaring a dependency on slf4j" means a dependency on both slf4j-api as well as a binding, aka implementa

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
> /James > >> -Original Message- >> From: Jason van Zyl [mailto:ja...@tesla.io] >> Sent: 11 October 2012 11:56 >> To: Maven Developers List >> Subject: Re: SLF4J integration >> >> Here's a first cut at the SLF4J integration documentation[

RE: SLF4J integration

2012-10-11 Thread Nord, James
defaults and not the defaults from the default configuration (which is confusing to an end user). /James > -Original Message- > From: Jason van Zyl [mailto:ja...@tesla.io] > Sent: 11 October 2012 11:56 > To: Maven Developers List > Subject: Re: SLF4J integration > >

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
Here's a first cut at the SLF4J integration documentation[1]. Happy to add anything about potential conflicts, more examples or consider other suggestions. I'll keep editing it until folks are happy and then I'll cut it over to the Maven site: [1]: http://tesla.io/maven/logging-

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
h all scenarios well but that shouldn't stop us from trying to make logging better for the vast majority of cases. > > LieGrue, > strub > > > > - Original Message - >> From: ceki >> To: Maven Developers List >> Cc: >> Sent: Thurs

Re: SLF4J integration

2012-10-11 Thread Mark Struberg
- Original Message - > From: ceki > To: Maven Developers List > Cc: > Sent: Thursday, October 11, 2012 12:25 PM > Subject: Re: SLF4J integration > > On 11.10.2012 11:18, Mark Struberg wrote: >> Oh I missed one more constellation >> >> a pl

Re: SLF4J integration

2012-10-11 Thread ceki
On 11.10.2012 11:18, Mark Struberg wrote: Oh I missed one more constellation a plugin could have slf4j-1.5.x + a logging backend we do not know of. I hope such things dont often exist, but in theory it could happen. For all of those cases we need isolation. A few months before creating the S

Re: SLF4J integration

2012-10-11 Thread Anders Hammar
> A plugin declaring a dependency on slf4j-api without declaring a > dependency on an implementation does not makes sense imo. It follows > that the term "declaring a dependency on slf4j" means a dependency on > both slf4j-api as well as a binding, aka implementation. If the get the slf4j logger i

Re: SLF4J integration

2012-10-11 Thread Jason van Zyl
I hope such things dont often exist, but in theory it could happen. >> >> For all of those cases we need isolation. >> >> >> LieGrue, >> strub >> >> >> >> >> - Original Message - >>> From: Mark Strube

Re: SLF4J integration

2012-10-11 Thread Stephen Connolly
On 11 October 2012 10:30, Stephen Connolly wrote: > On 11 October 2012 10:19, ceki wrote: > >> On 11.10.2012 10:24, Anders Hammar wrote: >> >>> Just to get this clear in my head: >>> When you're talking about "slf4j dependency" in a plugin, are you >>> talking about dependency to slf4j-api or an

Re: SLF4J integration

2012-10-11 Thread Stephen Connolly
On 11 October 2012 10:19, ceki wrote: > On 11.10.2012 10:24, Anders Hammar wrote: > >> Just to get this clear in my head: >> When you're talking about "slf4j dependency" in a plugin, are you >> talking about dependency to slf4j-api or an slf4j impl? >> > > A plugin declaring a dependency on slf4j

Re: SLF4J integration

2012-10-11 Thread Stephen Connolly
n exist, but in theory it could happen. > > For all of those cases we need isolation. > > > LieGrue, > strub > > > > > - Original Message - > > From: Mark Struberg > > To: Maven Developers List > > Cc: > > Sent: Thursday, October 11

Re: SLF4J integration

2012-10-11 Thread ceki
On 11.10.2012 10:24, Anders Hammar wrote: Just to get this clear in my head: When you're talking about "slf4j dependency" in a plugin, are you talking about dependency to slf4j-api or an slf4j impl? A plugin declaring a dependency on slf4j-api without declaring a dependency on an implementation

Re: SLF4J integration

2012-10-11 Thread Mark Struberg
gt; To: Maven Developers List > Cc: > Sent: Thursday, October 11, 2012 10:52 AM > Subject: Re: SLF4J integration > > A the end of the day we could have both actually! > > Most plugins will add both as dependency. Otherwise they would not be able to > log via slf4j. >

Re: SLF4J integration

2012-10-11 Thread Mark Struberg
day" ;) LieGrue, strub - Original Message - > From: Anders Hammar > To: Maven Developers List > Cc: > Sent: Thursday, October 11, 2012 10:24 AM > Subject: Re: SLF4J integration > > Just to get this clear in my head: > When you're talking about "slf4

Re: SLF4J integration

2012-10-11 Thread Anders Hammar
Just to get this clear in my head: When you're talking about "slf4j dependency" in a plugin, are you talking about dependency to slf4j-api or an slf4j impl? /Anders On Thu, Oct 11, 2012 at 10:16 AM, ceki wrote: > On 11.10.2012 08:37, Mark Struberg wrote: > > Hi Mark, > >> Hi Ceki, thanks for the

Re: SLF4J integration

2012-10-11 Thread ceki
On 11.10.2012 08:37, Mark Struberg wrote: Hi Mark, Hi Ceki, thanks for the reply! >> The method signatures of classes in the org.slf4j package such as? >> Logger, LoggerFactory, Marker, MDC, etc. are the same since 2005.? > > No they are not. I did a diff between 1.2 and the latest and it > s

Re: SLF4J integration

2012-10-10 Thread Mark Struberg
any plugin to use slf4j right now. All it needs to do is to funnel it into our own maven logging api. We could e.g. provide a slf4j-maven-logging backend so users could use it even more easily. LieGrue, strub - Original Message - > From: ceki > To: Maven Developers L

Re: SLF4J integration

2012-10-10 Thread ceki
On 10.10.2012 15:42, Mark Struberg wrote: Hi Mark, > Hi! > Here are a few basic observations about slf4j. slf4j really rocks for > end user applications, but when it comes to deep container core stuff > you must take care about classloader clashes much more than within an > end-user project. W

Re: SLF4J integration

2012-10-10 Thread Stephen Connolly
itment to deliver specific versions of dependencies in specific future versions of Maven] > I'm happy about any feedback! > > LieGrue, > strub > > > > - Original Message - > > From: Jason van Zyl > > To: Maven Developers List > > Cc: &

Re: SLF4J integration

2012-10-10 Thread Mark Struberg
> To: Maven Developers List > Cc: > Sent: Saturday, October 6, 2012 9:31 PM > Subject: SLF4J integration > >T he commit for review if anyone wants to take a look is here: > > https://github.com/tesla/maven-3/commit/4595e0860243854a7d80db8ebea97205aa4aca65 > &g

SLF4J integration

2012-10-06 Thread Jason van Zyl
The commit for review if anyone wants to take a look is here: https://github.com/tesla/maven-3/commit/4595e0860243854a7d80db8ebea97205aa4aca65 Ceki added support for logging to a file without massive contortions so I have defaulted the implementation to slf4j-simple which is small and provides t