On Wed, Jan 21, 2015 at 11:49 PM, Dennis Lundberg wrote:
> On Thu, Jan 22, 2015 at 5:29 AM, Hervé BOUTEMY wrote:
>> Le mercredi 21 janvier 2015 14:44:27 Dennis Lundberg a écrit :
>>> There is some piece of code in Checkstyle 5.9 that uses Java 6+
>>> classes/methods. I don't remember where, but i
On Thu, Jan 22, 2015 at 5:29 AM, Hervé BOUTEMY wrote:
> Le mercredi 21 janvier 2015 14:44:27 Dennis Lundberg a écrit :
>> There is some piece of code in Checkstyle 5.9 that uses Java 6+
>> classes/methods. I don't remember where, but it isn't covered by our
>> integration tests.
> since our ITs us
Le mercredi 21 janvier 2015 14:44:27 Dennis Lundberg a écrit :
> There is some piece of code in Checkstyle 5.9 that uses Java 6+
> classes/methods. I don't remember where, but it isn't covered by our
> integration tests.
since our ITs use the 3 integrated rulesets, I suppose this is in a rule that
Benson, please have a look at the road map in JIRA.
The talk about Checkstyle 5.9 regards the 2.14 release that we have
been preparing for during the last couple of weeks.
On Wed, Jan 21, 2015 at 2:52 PM, Benson Margulies wrote:
> I'm confused. The current version of checkstyle is 6.2. Why is th
I'm confused. The current version of checkstyle is 6.2. Why is this
discussion about 5.9? Should we make a branch that requires java
whatever and is actually current?
On Wed, Jan 21, 2015 at 8:44 AM, Dennis Lundberg wrote:
> There is some piece of code in Checkstyle 5.9 that uses Java 6+
> classe
There is some piece of code in Checkstyle 5.9 that uses Java 6+
classes/methods. I don't remember where, but it isn't covered by our
integration tests. I'll have a look at it tomorrow evening, and see if
I can produce an IT that catches it.
Another thing that I have been thinking about is whether
Le vendredi 9 janvier 2015 13:29:06 Dennis Lundberg a écrit :
> I've started going through the open issues and have found a problem
> that I need som help with. It turns out that Checkstyle 5.9 uses Java
> 6 classes, even though it is not mentioned in the release notes. How
> do we want to handle t
Thanks, will do.
On Sun, Jan 18, 2015 at 8:12 AM, Dennis Lundberg wrote:
> Henning,
>
> Please try the latest 2.14-SNAPSHOT version from the ASF repository.
> You should be able to just override the Checkstyle version by adding a
> dependency on Checkstyle 6.2 to the Maven Checkstyle Plugin in yo
Henning,
Please try the latest 2.14-SNAPSHOT version from the ASF repository.
You should be able to just override the Checkstyle version by adding a
dependency on Checkstyle 6.2 to the Maven Checkstyle Plugin in your
project's POM.
On Sat, Jan 17, 2015 at 6:39 PM, Henning Schmiedehausen
wrote:
>
There are now 3 issues left for the 2.14 version in JIRA. I've
commented on two of them. Unless someone wants to include them (and
are willing to do the work shortly) I will move them to the backlog.
After that I will start the release of 2.14.
Then I plan to do 2.15 (Java 6) and 2.16 (Java 7) in
the changes are at canonical repo, ie ASF svn
see http://jira.codehaus.org/browse/MCHECKSTYLE-276
I suppose github mirror is a little bit behind
Regards,
Hervé
Le samedi 17 janvier 2015 09:39:16 Henning Schmiedehausen a écrit :
> As long as I can just drop in 6.2 and the plugin does not break (
As long as I can just drop in 6.2 and the plugin does not break (as it
does today), I am fine.
We are running our own checkstyle ruleset anyway, it is just the
default that does not work well.
Where are your changes, I haven't seen them on the trunk @ github.
-h
On Sat, Jan 17, 2015 at 9:30 AM
yes, i know you did that in the branch to test upgrade for a release with
Checkstyle 6.2 as default version
I did it in trunk, even without changing Checkstyle version: even if maven-
checkstyle-plugin ships with an older Checkstyle version as default
dependency, end-users can now upgrade the de
I already did that. See https://github.com/apache/maven-plugins/pull/42
-h
On Sat, Jan 17, 2015 at 9:02 AM, Hervé BOUTEMY wrote:
> Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
>> The 6.2 checkstyle requires java 7 and it also removes (!) at least
>> one of the checks (Re
Le mercredi 14 janvier 2015 11:08:40 Henning Schmiedehausen a écrit :
> The 6.2 checkstyle requires java 7 and it also removes (!) at least
> one of the checks (RedundantThrows) which is used in all shipped
> checkstyle sets and one of the integration tests. So you can no longer
> use any of the bu
I made all the necessary changes to run out-of-the-box with 6.2 (and
have all the integration tests etc. pass) at
https://github.com/apache/maven-plugins/pull/42
Getting this out quickly would IMHO be a benefit to the whole apache
community (compared to, say lovingly maintain backwards compat to 5
The 6.2 checkstyle requires java 7 and it also removes (!) at least
one of the checks (RedundantThrows) which is used in all shipped
checkstyle sets and one of the integration tests. So you can no longer
use any of the builtin styles but have to use a custom style which has
the RedundantThrows chec
question: is upgrading only a question of changing dependency version? or does
it require code change?
and if it requires code change, can we do it with reasonable reflection or is
it really too much change?
because if we can let the end user upgrade his config (and better document), we
would g
I would pretty much abandon anything pre-Java 6 at this point and
start moving towards Java 7 soon. The checkstyle plugin right now has
three open releases with only the third being really useful ("upgrade
to latest checkstyle") and given the previous release cadence it makes
me fear that this rele
Definitely does not count as a regression, although like all fixed bugs it
has end user value.
You call, I say go for 1.6 and use the extra time & energy elsewhere :)
K
The only fixed issue that could I see that could have a direct benefit
to end users is:
http://jira.codehaus.org/browse/MCHE
The only fixed issue that could I see that could have a direct benefit
to end users is:
http://jira.codehaus.org/browse/MCHECKSTYLE-254
Update plexus-interpolation to avoid thread safety issues
But I don't know if anyone has had any problems with this specifically
regarding the Checkstyle Plugin,
+1
On Jan 9, 2015, at 8:13 AM, Kristian Rosenvold
wrote:
> As long as we're not regressed on the latest version I'd say that's
> your call right now.
>
> Kristian
>
>
> 2015-01-09 13:29 GMT+01:00 Dennis Lundberg :
>> I've started going through the open issues and have found a problem
>> that
As long as we're not regressed on the latest version I'd say that's
your call right now.
Kristian
2015-01-09 13:29 GMT+01:00 Dennis Lundberg :
> I've started going through the open issues and have found a problem
> that I need som help with. It turns out that Checkstyle 5.9 uses Java
> 6 classes
I've started going through the open issues and have found a problem
that I need som help with. It turns out that Checkstyle 5.9 uses Java
6 classes, even though it is not mentioned in the release notes. How
do we want to handle this? I see two possible options:
1. Make version 2.14 of the plugin r
if nobody beats me at it, I'll work on it in 1 or 2 weeks: nothing really
complex, just "to do"
Regards,
Hervé
Le jeudi 8 janvier 2015 15:51:57 Dennis Lundberg a écrit :
> Hi,
>
> I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
> motive for 2.14 is the ability to check Ja
Hi,
I'd like to release version 2.14 of Maven Checkstyle Plugin. The main
motive for 2.14 is the ability to check Java 8 source code.
According to the road map there are 5 unresolved issues scheduled for 2.14.
https://jira.codehaus.org/browse/MCHECKSTYLE#selectedTab=com.atlassian.jira.plugin.sys
26 matches
Mail list logo
