Re: Release of Maven Sources Plugin 2.3

2012-10-10 Thread Mark Struberg
lopers List > Cc: > Sent: Thursday, October 11, 2012 8:44 AM > Subject: Re: Release of Maven Sources Plugin 2.3 > > Ooo. Findbugs does some serious good stuff; Look at this violation in > "FileUtils"; > > https://analysis.apache.org/drilldown/violations/12409?

Re: Release of Maven Sources Plugin 2.3

2012-10-10 Thread Kristian Rosenvold
Ooo. Findbugs does some serious good stuff; Look at this violation in "FileUtils"; https://analysis.apache.org/drilldown/violations/12409?rids%5B%5D=103768&rids%5B%5D=103771&rule=findbugs%3ARCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE&rule_sev=CRITICAL# Which raises the question; I would never be abl

Re: Release of Maven Sources Plugin 2.3

2012-10-10 Thread Robert Scholte
While improving this, also have a look at https://analysis.apache.org/drilldown/violations/org.apache.maven.shared:maven-shared-aggregator? maven-shared-utils is by far the project with the most violations... Robert Op Mon, 08 Oct 2012 19:19:40 +0200 schreef Olivier Lamy : 2012/10/8 Robert Sc

Re: Release of Maven Sources Plugin 2.3

2012-10-08 Thread Olivier Lamy
2012/10/8 Robert Scholte : > Op Mon, 08 Oct 2012 00:17:38 +0200 schreef Olivier Lamy : > > >> 2012/10/7 Robert Scholte : >>> >>> Hi, >>> >>> I'm having a look at the shared-utils and some tests fail under Windows. >>> So >>> those need to be fixed first. >>> I'm working on that. >> >> Good luck :P

Re: Release of Maven Sources Plugin 2.3

2012-10-08 Thread Robert Scholte
Op Mon, 08 Oct 2012 00:17:38 +0200 schreef Olivier Lamy : 2012/10/7 Robert Scholte : Hi, I'm having a look at the shared-utils and some tests fail under Windows. So those need to be fixed first. I'm working on that. Good luck :P We can probably setup Jenkins to run this on the windauze nod

Re: Release of Maven Sources Plugin 2.3

2012-10-07 Thread Olivier Lamy
2012/10/7 Robert Scholte : > Hi, > > I'm having a look at the shared-utils and some tests fail under Windows. So > those need to be fixed first. > I'm working on that. Good luck :P We can probably setup Jenkins to run this on the windauze node too ? > > Also I'd like discuss if we should remove dep

Re: Release of Maven Sources Plugin 2.3

2012-10-07 Thread Robert Scholte
Hi, I'm having a look at the shared-utils and some tests fail under Windows. So those need to be fixed first. I'm working on that. Also I'd like discuss if we should remove deprecated classes and methods and optimize method signatures. Since we're starting with a new artifact there's no bac

Re: Release of Maven Sources Plugin 2.3

2012-10-05 Thread Arnaud Héritier
+1 for the release. Arnaud On Thu, Oct 4, 2012 at 11:07 PM, Robert Scholte wrote: > Ok, I missed this in the revisions mentioned in Jira. > I'm fine with it. > > Robert > > Op Thu, 04 Oct 2012 21:14:09 +0200 schreef Olivier Lamy >: > > > 2012/10/4 Robert Scholte : >> >>> Since this is a blocke

Re: Release of Maven Sources Plugin 2.3

2012-10-04 Thread Robert Scholte
Ok, I missed this in the revisions mentioned in Jira. I'm fine with it. Robert Op Thu, 04 Oct 2012 21:14:09 +0200 schreef Olivier Lamy : 2012/10/4 Robert Scholte : Since this is a blocker, where's the unit test or IT? http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-source-plugin/s

Re: Release of Maven Sources Plugin 2.3

2012-10-04 Thread Olivier Lamy
2012/10/4 Robert Scholte : > Since this is a blocker, where's the unit test or IT? http://svn.apache.org/repos/asf/maven/plugins/trunk/maven-source-plugin/src/it/MSOURCES-62/ > > Op Thu, 04 Oct 2012 10:19:51 +0200 schreef Olivier Lamy : > > >> Hi, >> There is a blocker issue http://jira.codehaus.

Re: Release of Maven Sources Plugin 2.3

2012-10-04 Thread Robert Scholte
Since this is a blocker, where's the unit test or IT? Op Thu, 04 Oct 2012 10:19:51 +0200 schreef Olivier Lamy : Hi, There is a blocker issue http://jira.codehaus.org/browse/MSOURCES-62 The plugin has some SNAPSHOT dependencies I need to release too. * maven-archiver * maven-shared-utils So I w

Release of Maven Sources Plugin 2.3

2012-10-04 Thread Olivier Lamy
Hi, There is a blocker issue http://jira.codehaus.org/browse/MSOURCES-62 The plugin has some SNAPSHOT dependencies I need to release too. * maven-archiver * maven-shared-utils So I will release all. Objections ? Thanks -- Olivier Lamy Talend: http://coders.talend.com http://twitter.com/olamy | h