Re: Reading another plugins configuration: there's a patch available that does this

2007-12-28 Thread Jason van Zyl
On 28 Dec 07, at 2:52 AM 28 Dec 07, Dennis Lundberg wrote: Jason van Zyl wrote: On 27 Dec 07, at 4:02 PM 27 Dec 07, Dennis Lundberg wrote: Hi I've been applying patches to the pmd-plugin from Xavier Le Vourch. The patches have been of good quality. Now I'm looking at a patch for http:/

Re: Reading another plugins configuration: there's a patch available that does this

2007-12-28 Thread Dennis Lundberg
Brett Porter wrote: > That's the current "standard practice" I think (doesn't the IDEA plugin > already do it? That would be a good place to copy behaviour from for > consistency). No, it just has a @todo comment: "would be good to use the compilation source if possible" > > Toolchains should m

Re: Reading another plugins configuration: there's a patch available that does this

2007-12-28 Thread Dennis Lundberg
Jason van Zyl wrote: > > On 27 Dec 07, at 4:02 PM 27 Dec 07, Dennis Lundberg wrote: > >> Hi >> >> I've been applying patches to the pmd-plugin from Xavier Le Vourch. The >> patches have been of good quality. >> >> Now I'm looking at a patch for http://jira.codehaus.org/browse/MPMD-63 >> which rea

Re: Reading another plugins configuration: there's a patch available that does this

2007-12-28 Thread Tom Huybrechts
On Dec 28, 2007 1:02 AM, Dennis Lundberg <[EMAIL PROTECTED]> wrote: > Hi > > I've been applying patches to the pmd-plugin from Xavier Le Vourch. The > patches have been of good quality. > > Now I'm looking at a patch for http://jira.codehaus.org/browse/MPMD-63 > which reads the jdk source level fr

Re: Reading another plugins configuration: there's a patch available that does this

2007-12-27 Thread Jason van Zyl
On 27 Dec 07, at 4:02 PM 27 Dec 07, Dennis Lundberg wrote: Hi I've been applying patches to the pmd-plugin from Xavier Le Vourch. The patches have been of good quality. Now I'm looking at a patch for http://jira.codehaus.org/browse/MPMD-63 which reads the jdk source level from the compiler

Re: Reading another plugins configuration: there's a patch available that does this

2007-12-27 Thread Brett Porter
That's the current "standard practice" I think (doesn't the IDEA plugin already do it? That would be a good place to copy behaviour from for consistency). Toolchains should make it all go away eventually... - Brett On 28/12/2007, at 11:02 AM, Dennis Lundberg wrote: Hi I've been applying

Reading another plugins configuration: there's a patch available that does this

2007-12-27 Thread Dennis Lundberg
Hi I've been applying patches to the pmd-plugin from Xavier Le Vourch. The patches have been of good quality. Now I'm looking at a patch for http://jira.codehaus.org/browse/MPMD-63 which reads the jdk source level from the compiler-plugin, so that it can feed this info to PMD. This topic has been