Re: Toolchains and Maven Enforcer

2025-02-04 Thread Guillaume Nodet
Le mar. 4 févr. 2025 à 09:05, Thomas Reinhardt a écrit : > > Interesting, I was not aware of the new discovery mechanism. > > Unfortunately the most interesting goal "select-jdk-toolchain" is not > marked threadsafe. Was that a conscious decision or just easier to > implement? > I think it's an

Re: Toolchains and Maven Enforcer

2025-02-04 Thread Romain Manni-Bucau
Hi, The discovery uses JAVA_xx_HOME environment variables which is often the way CI are setting up the paths - ack not on jenkins if not done manually but it is not a bad practise. I assume adding a property to configure yet another search path ( https://github.com/apache/maven-toolchains-plugin/b

Re: Toolchains and Maven Enforcer

2025-02-04 Thread Thomas Reinhardt
Interesting, I was not aware of the new discovery mechanism. Unfortunately the most interesting goal "select-jdk-toolchain" is not marked threadsafe. Was that a conscious decision or just easier to implement? Also I am missing a parameter to provide a search path. Might come in handy in CI

Re: Toolchains and Maven Enforcer

2025-02-03 Thread Mikko Johannes Koivunalho
Hi, Greg, I tried reproducing your issue but couldn't. It seems like something wrong with the JDK1.5 installation. Offhand I would guess JDK 1.5 just isn't compatible with |ToolchainDiscoverer.java:discoverToolchains()| when trying to extract some detail. However, for myself, when running |

Re: Toolchains and Maven Enforcer

2025-02-02 Thread Guillaume Nodet
The toolchains discovery has been released a few months ago: https://maven.apache.org/plugins/maven-toolchains-plugin/toolchains/jdk-discovery.html This is also usable in Maven 3.x. I think that should cover your use case. The enforcer check does not really need to be performed because the toolch

Re: Toolchains and Maven Enforcer

2025-02-02 Thread Mikko Johannes Koivunalho
Hi, I am forwarding this message to Maven Developer List. Before getting to any development, I'd like to know more about planned Maven4 improvements in the area of toolchains. Thank you. Sincerely, Mikko Koivunalho On 02/02/2025 19:28, Tamás Cservenák wrote: Howdy, TBH, I never understoo