Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 14 h 26, Guillaume Nodet a écrit : https://github.com/apache/maven/blob/c0012c08aaad27473770fc39ab7e39026238c7e1/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.1.0.xml#L27 My bad. Re-testing again, I get the warning with Maven 3.9.6 (the version provided b

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Gary Gregory
Hm, good point! There must be different toggles. Gary On Wed, Aug 7, 2024, 8:27 AM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > Le 2024-08-07 à 13 h 56, Gary Gregory a écrit : > > > > I think COMPAT is going away in Java 23: > > https://inside.java/2024/07/11/quality-heads-up

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 13 h 56, Gary Gregory a écrit : I think COMPAT is going away in Java 23: https://inside.java/2024/07/11/quality-heads-up/ Thanks for the link. But it seems to be a different `COMPAT`. The above link mentions only the `java.locale.providers` property value, while the `COMPAT`

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Guillaume Nodet
https://github.com/apache/maven/blob/c0012c08aaad27473770fc39ab7e39026238c7e1/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.1.0.xml#L27 Guillaume Nodet Le mer. 7 août 2024 à 13:44, Martin Desruisseaux < martin.desruisse...@geomatys.com> a écrit :

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Gary Gregory
I think COMPAT is going away in Java 23: https://inside.java/2024/07/11/quality-heads-up/ Gary On Wed, Aug 7, 2024, 7:43 AM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > Le 2024-08-07 à 12 h 49, Guillaume Nodet a écrit : > > > > I thought we set the default encoding in the roo

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 13 h 42, Martin Desruisseaux a écrit : Note: I would not recommend to change that. I mean, the fact that the encoding is apparently not specified in the root POM. I still suggest to remove the warning except on Java 17.     Martin --

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Martin Desruisseaux
Le 2024-08-07 à 12 h 49, Guillaume Nodet a écrit : I thought we set the default encoding in the root pom a while ago ? Apparently not. The default encoding is ${project.build.sourceEncoding}. But if this property is not explicitly set in user's project, we get the warning (tested with Maven 3

Re: Proposal: remove warning about file encoding not set

2024-08-07 Thread Guillaume Nodet
I thought we set the default encoding in the root pom a while ago ? Le lun. 5 août 2024 à 13:30, Tamás Cservenák a écrit : > > +1 for removing this warning > > On Mon, Aug 5, 2024 at 1:22 PM Martin Desruisseaux < > martin.desruisse...@geomatys.com> wrote: > > > In Maven 3, if the configuration p

Re: Proposal: remove warning about file encoding not set

2024-08-05 Thread Tamás Cservenák
+1 for removing this warning On Mon, Aug 5, 2024 at 1:22 PM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > In Maven 3, if the configuration parameter or the > "project.build.sourceEncoding" property is not set, the compiler emits a > warning like below: > > > File encoding has