Re: Proposal: Reactivating PMD to Strengthen Definition of Done

2025-05-21 Thread Martin Desruisseaux
I agree with Elliotte and his example with parenthesis. I do not consider "unnecessary parenthesis" as a violation, since they sometime improve code readability. The last time that I used PMD in a big project (years ago), we had thousands of warnings reported as "violations" that we considered

Re: Proposal: Reactivating PMD to Strengthen Definition of Done

2025-05-20 Thread Elliotte Rusty Harold
Maybe. Maybe not. I don't think most of these can be simply assumed to be correct. For instance "Unnecessary parentheses" can nonetheless be extremely helpful in clarifying code. Removing them is in no way a best practice. Sometimes it's a good idea. Sometimes it's actively harmful. The same is tru