Ok,
Thanks Brett,
Arnaud
> -Message d'origine-
> De : Brett Porter [mailto:[EMAIL PROTECTED]
> Envoyé : lundi 14 novembre 2005 00:09
> À : Maven Developers List
> Objet : Re: standard form for commit messages
>
> Yes, its already under the guide for
Yes, its already under the guide for contributing.
- Brett
Arnaud HERITIER wrote:
Hi,
Can it be documented somewhere in m1/m2 sites ?
Committers, can you try to follow it ? :-)
I took a look at recent commits and it's not really used !!
Arnaud
Hi,
I've noticed a few things go
Hi,
Can it be documented somewhere in m1/m2 sites ?
Committers, can you try to follow it ? :-)
I took a look at recent commits and it's not really used !!
Arnaud
>
> Hi,
>
> I've noticed a few things going into commit messages, for
> which I usually use a standard fo
Ok for me,
I'll try to not forget to use it ;-)
Arnaud
> -Message d'origine-
> De : Brett Porter [mailto:[EMAIL PROTECTED]
> Envoyé : vendredi 28 octobre 2005 03:46
> À : Maven Developers List
> Objet : standard form for commit messages
>
> Hi,
>
> I've noticed a few things going in
On 28/10/05, Brett Porter <[EMAIL PROTECTED]> wrote:
> PR: issue1, issue2 (using issue keys from JIRA, not URLs)
> Submitted by: (when it was a patch, put that persons name there)
> Reviewed by: (not sure if this is useful, but was in the template - who
> reviewed it)
> << comment >>
I've always w
On Thu, 2005-10-27 at 18:46 -0700, Brett Porter wrote:
> Hi,
>
> I've noticed a few things going into commit messages, for which I
> usually use a standard form (that matches a template that used to exist
> in Apache's CVS).
>
> Basically, wehere applicable:
>
> PR: issue1, issue2 (using issue
Probably the point in adding submitted by, is for submitted patches. A
lot of contributors don't have commit rights so their names wouldn't
show up from the SCM if you view the logs.
Carlos Sanchez wrote:
Sorry, when I said issue number I meant source control commit id, so
when you ask for th
Sorry, when I said issue number I meant source control commit id, so
when you ask for the comment used you can also get the user from the
SCM
On 10/27/05, Brett Porter <[EMAIL PROTECTED]> wrote:
> I think it is a good idea to include it in the SVN commit message (also
> a description of what was g
I think the reviewed-by is pointless if it's the same person as the
committer. Otherwise, it matches exactly the template that I've been
using so far.
-Lukas
Brett Porter wrote:
Hi,
I've noticed a few things going into commit messages, for which I
usually use a standard form (that matches
I think it is a good idea to include it in the SVN commit message (also
a description of what was going on). It makes the source control stand
on its own as a source of information. Otherwise, if you later analyse
the history and it points to JIRA when we've moved on to
ReallyGoodIssueTracker20
Yes, and this is a good practice for committers anyway, to ensure
changesets represent one fix or feature if possible. It makes them
easier to identify later and rollback if required.
-Brett
Edwin Punzalan wrote:
I think that's ok.
Since there is a "Submitted by: " phrase there, I assume th
I don't see the point of including the submitted by, probably it can
be obtained in any other way from the issue number. I agree with the
jira issue number
On 10/27/05, Brett Porter <[EMAIL PROTECTED]> wrote:
> Hi,
>
> I've noticed a few things going into commit messages, for which I
> usually use
I think that's ok.
Since there is a "Submitted by: " phrase there, I assume that each patch
will be committed separately.
Brett Porter wrote:
Hi,
I've noticed a few things going into commit messages, for which I
usually use a standard form (that matches a template that used to
exist in
13 matches
Mail list logo
