berndq wrote:
Edwin Punzalan wrote:
A staging site is currently available at
http://people.apache.org/~epunzalan/maven-assembly-plugin.
Thank you for taking some time to review it.
- Binding to package phase:
in the example there is packaging
Works for me only with package
Nice catch
Edwin Punzalan wrote:
A staging site is currently available at
http://people.apache.org/~epunzalan/maven-assembly-plugin.
Thank you for taking some time to review it.
- Binding to package phase:
in the example there is packaging
Works for me only with package
- the page mentions "attac
Fixed and uploaded.
Sorry about that, I had to edit your patch for consistency.
Barrie Treloar wrote:
On 7/31/06, Edwin Punzalan <[EMAIL PROTECTED]> wrote:
staging site updated with a patch from MASSEMBLY-130 applied.
Did I stuff up the patch?
*
http://people.apache.org/~epunzalan/maven-a
On 7/31/06, Edwin Punzalan <[EMAIL PROTECTED]> wrote:
staging site updated with a patch from MASSEMBLY-130 applied.
Did I stuff up the patch?
* http://people.apache.org/~epunzalan/maven-assembly-plugin/examples/index.html
is missing a link to the include-and-exclude.html (It is included in
the
staging site updated with a patch from MASSEMBLY-130 applied.
Again, thanks for the reviewers. ^_^
Edwin Punzalan wrote:
Hi,
I've made some changes to the documentation of the Assembly plugin and
would like to hear your inputs about it.
- made the plugin docck-compliant
- edited the de
Hi,
Thanks for the review. Please see my inline comments below...
Dennis Lundberg wrote:
Hi Edwin
I have committed a fix for a few typos.
Here are some additional comments om the assembly plugin documentation:
assembly-mojo.html
- archiverManager, artifactResolver and repositoryAssembler h
Any chance i can get MASSEMBLY-118, 119, 130 looked at the same time?
130 is a doc patch
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
Edwin Punzalan wrote:
Hi,
I've made some changes to the documentation of the Assembly plugin and
would like to hear your inputs about it.
- made the plugin docck-compliant
- edited the descriptions inside the modello files
- edited some of the parameter descriptions
- added an faq page
Changes applied and deployed in the same staging site.
- fixed "simple" links to "single"
- added an faq on using javadoc to jar javadoc files docs
- added goals in the navigation bar
- added link to the project summary page in features.html
- fixed some typos and grammatical errors
- removed "A
http://people.apache.org/~epunzalan/maven-assembly-plugin/index.html:
* tar.bz -> tar.gz
* tar.gz2 -> tar.bz2
http://people.apache.org/~epunzalan/maven-assembly-plugin/descriptor-refs.html
In the 'src' section there is a sentence which starts with "The bin
descriptorId produces" which should be
Hi Edwin,
Great job! Thanks.
Here my comments:
Navbar:
Missing goals link to be in line with the standard
As already said, review links.
index.html
Missing usage part as usual.
features.html
What is the current version? Maybe add a link to /project-summary.html
faq.html
"is ran" => is run
e
The simple examples index page is missing:
Not Found
The requested URL
/~epunzalan/maven-assembly-plugin/examples/simple/index.html was not found
on this server.
It seems all of the simple files are missing. I guess it's a typo
somewhere.
I would definitly like to see a component example (i
when you clink on "Using repositories" in navigation bar, you don't
get any page. There is a typo in the path, it's using "single" instead
of "simple" or vice versa..
Milos
On 7/26/06, Edwin Punzalan <[EMAIL PROTECTED]> wrote:
Hi,
I've made some changes to the documentation of the Assembly pl
13 matches
Mail list logo