Re: New feature: filtering

2003-06-16 Thread Brett Porter
I'm not fussy about the syntax but I do not want to bind the filtering to Ant. Why don't we keep @...@ syntax by default, but allow configuration (as does Ant). I think we can reuse the POM definition to configure Ant filtersets for those that want to use it, but if we remove and replace it wit

RE: New feature: filtering

2003-06-16 Thread Jason van Zyl
On Mon, 2003-06-16 at 09:48, Vincent Massol wrote: > > > > I don't have the full picture of what you're doing though... > > > > I'm trying to trace down the memory leak and sequentially going > through > > a list of suspect points of leakage. > > That's cool :-) Yes, well I'm trying but so far

RE: New feature: filtering

2003-06-16 Thread Vincent Massol
> -Original Message- > From: Jason van Zyl [mailto:[EMAIL PROTECTED] > Sent: 16 June 2003 15:47 > To: Maven Developers List > Subject: RE: New feature: filtering > > On Mon, 2003-06-16 at 09:39, Vincent Massol wrote: > > > Filtering is working right now

RE: New feature: filtering

2003-06-16 Thread Jason van Zyl
On Mon, 2003-06-16 at 09:39, Vincent Massol wrote: > Filtering is working right now for runtime and test resources... We can > get the release out the door (on this subject). I don't see how > rewriting our filtering support and in addition writing some additional > java code can help improve the

RE: New feature: filtering

2003-06-16 Thread Vincent Massol
> -Original Message- > From: Jason van Zyl [mailto:[EMAIL PROTECTED] > Sent: 16 June 2003 15:24 > To: Maven Developers List > Subject: RE: New feature: filtering > > On Mon, 2003-06-16 at 04:44, Vincent Massol wrote: > > > And you can re-use any of these w

RE: New feature: filtering

2003-06-16 Thread Jason van Zyl
On Mon, 2003-06-16 at 04:44, Vincent Massol wrote: > And you can re-use any of these without having to go through an XML > script file of course. Why would you want to reinvent the wheel? Because everytime I take this line of thought I end up spending monumental amounts of time because I run into

RE: New feature: filtering

2003-06-16 Thread Vincent Massol
> -Original Message- > From: Jason van Zyl [mailto:[EMAIL PROTECTED] > Sent: 16 June 2003 10:35 > To: Maven Developers List > Subject: Re: New feature: filtering > > On Mon, 2003-06-16 at 03:20, Brett Porter wrote: > > > oh, ok. I thought you wanted to p

Re: New feature: filtering

2003-06-16 Thread Jason van Zyl
On Mon, 2003-06-16 at 03:20, Brett Porter wrote: > > oh, ok. I thought you wanted to put the filter in the POM... If it's > > just the filtersets, then, yes I agree. However, I'm not sure I like the > > format: > > > > > > > > my.filters > > ${basedir}/../filters > > > > **/

Re: New feature: filtering

2003-06-16 Thread Brett Porter
Although I don't quite agree, I've applied it for now. The part that I don't like is that copying will be done all the time when there are filters, even if the file or the filter value have not changed... This has always been an issue with ant filtering. The only option you have is to set up some

RE: New feature: filtering

2003-06-16 Thread Vincent Massol
> -Original Message- > From: Brett Porter [mailto:[EMAIL PROTECTED] > Sent: 16 June 2003 09:21 > To: Maven Developers List > Subject: Re: New feature: filtering > > > oh, ok. I thought you wanted to put the filter in the POM... If it's > > just the fil

Re: New feature: filtering

2003-06-16 Thread Brett Porter
oh, ok. I thought you wanted to put the filter in the POM... If it's just the filtersets, then, yes I agree. However, I'm not sure I like the format: my.filters ${basedir}/../filters **/*.properties my.filters base.filters ... [...]

RE: New feature: filtering

2003-06-16 Thread Vincent Massol
> -Original Message- > From: Brett Porter [mailto:[EMAIL PROTECTED] > Sent: 16 June 2003 08:07 > To: Maven Developers List > Subject: Re: New feature: filtering > > > BTW, do you have any idea why the sample-filtering project in > > plugin-builds/exampl

RE: New feature: filtering

2003-06-16 Thread Vincent Massol
> -Original Message- > From: Brett Porter [mailto:[EMAIL PROTECTED] > Sent: 16 June 2003 07:21 > To: Maven Developers List > Subject: Re: New feature: filtering > > > Why is that? I never use the "overwrite" attribute and all my filtering > > work

Re: New feature: filtering

2003-06-15 Thread Brett Porter
BTW, do you have any idea why the sample-filtering project in plugin-builds/examples does not work WRT filtering? You've placed the "filtering" attribute on the "fileset" tag. It should be on the "copy" tag. Also, test-nofilter should contain "@testFilter@" so you can check it is not replaced.

Re: New feature: filtering

2003-06-15 Thread Brett Porter
Why is that? I never use the "overwrite" attribute and all my filtering work fine... change a filter, but don't touch the file that will be filtered - Ant (at least last time I checked) doesn't copy the file again, leaving it with the old value. BTW, do you have any idea why the sample-filtering

RE: New feature: filtering

2003-06-15 Thread Vincent Massol
> -Original Message- > From: Brett Porter [mailto:[EMAIL PROTECTED] > Sent: 16 June 2003 06:59 > To: Maven Developers List > Subject: Re: New feature: filtering > > Hi Vincent, > > This is great! However, there is one problem: you'll need to add >

Re: New feature: filtering

2003-06-15 Thread Brett Porter
Hi Vincent, This is great! However, there is one problem: you'll need to add as well, as overwrite needs to be enabled for filtering. Also, I'd prefer to see filter loading incorporated into the POM. my.filters ${basedir}/../filters **/*.properties