Re: Artifact Version Comparison

2008-05-19 Thread Hervé BOUTEMY
Le lundi 19 mai 2008, Brett Porter a écrit : > So the change was just to allow numerical ordering for non-standard > versions like alpha-1 vs alpha-11 and 5.0.9.0 vs 5.0.10.0 ? Yes, these cases are the most common ones fixed. I didn't work on the "pluggable version handling" part of the proposal: i

Re: Artifact Version Comparison

2008-05-18 Thread Brett Porter
So the change was just to allow numerical ordering for non-standard versions like alpha-1 vs alpha-11 and 5.0.9.0 vs 5.0.10.0 ? That looks ok to me at first glance, but I'll take a closer look. - Brett On 16/05/2008, at 5:02 AM, Hervé BOUTEMY wrote: FYI, I just merged version comparison impr

Re: Artifact Version Comparison

2008-05-15 Thread Hervé BOUTEMY
FYI, I just merged version comparison improvement to artifact trunk. 2.1.x ITs are ok, both on my machine and on Sonatype's CI server I hope everything is ok for everybody Don't hesitate to ring me if anything goes wrong regards, Hervé Le jeudi 01 mai 2008, Hervé BOUTEMY a écrit : > Kenney sta

Re: Artifact Version Comparison

2008-05-03 Thread Jason van Zyl
On 3-May-08, at 3:34 AM, Hervé BOUTEMY wrote: The change is only on version comparison, not version parsing to dispatch info to ArtifactVersion API, which would have probably more impact. This still could potentially impact users. Just for the record I think Kenney's proposal is good, soun

Re: Artifact Version Comparison

2008-05-03 Thread Hervé BOUTEMY
The change is only on version comparison, not version parsing to dispatch info to ArtifactVersion API, which would have probably more impact. AFAIK, version comparison is used only for version ranges, but I don't know every aspect of Maven to be sure of this. As asked by Jason, I'll try integrat

Re: Artifact Version Comparison

2008-05-03 Thread Hervé BOUTEMY
Le vendredi 02 mai 2008, Gilles Scokart a écrit : > By the way, in which case did you need to compare 2 version? > In ivy, we use it mostly for conflict resolution. But maven use a > 'nearest' aproach. So I guess there is no need to compare version > there. > > Is the impact limited to version ra

Re: Artifact Version Comparison

2008-05-03 Thread Hervé BOUTEMY
Le vendredi 02 mai 2008, Benjamin Bentmann a écrit : > Wayne Fay wrote: > > How is CR different from RC? > > I don't meant to say they are different, it's only another well-known > qualifier, aliasing one from the existing list. yes, I'll need to add an aliasing system: CR = RC, GA = "" > > > I th

Re: Artifact Version Comparison

2008-05-02 Thread Paul Gier
Within JBoss a lot of our projects use CR and GA so that the versions can be sorted alphabetically. At least that was the explanation given to me ;) I think RC is more common in other places. Ideally I would like to see a pluggable version parsing so that a given project could configure it's

Re: Artifact Version Comparison

2008-05-02 Thread Gilles Scokart
2008/5/2 Benjamin Bentmann <[EMAIL PROTECTED]>: > Wayne Fay wrote: > > > > How is CR different from RC? > > > > I don't meant to say they are different, it's only another well-known > qualifier, aliasing one from the existing list. > > > > > I think I'd pick one and forget about the other. > > > >

Re: Artifact Version Comparison

2008-05-02 Thread Benjamin Bentmann
Wayne Fay wrote: How is CR different from RC? I don't meant to say they are different, it's only another well-known qualifier, aliasing one from the existing list. I think I'd pick one and forget about the other. Is an option, we only need to make sure to clearly explain people that Mave

RE: Artifact Version Comparison

2008-05-01 Thread Brian E. Fox
What's the impact to existing builds. My initial reaction is no-way in 2.0.x. -Original Message- From: Hervé BOUTEMY [mailto:[EMAIL PROTECTED] Sent: Thursday, May 01, 2008 4:07 PM To: Maven Developers List Subject: Artifact Version Comparison Kenney started a proposal http://docs.codehau

Re: Artifact Version Comparison

2008-05-01 Thread Jason van Zyl
On 1-May-08, at 1:07 PM, Hervé BOUTEMY wrote: Kenney started a proposal http://docs.codehaus.org/display/MAVEN/Versioning with a implementation of a comparator. I took his implementation, updated it to support comparison between more version schemes and integrated it to DefaultArtifactVersio

Re: Artifact Version Comparison

2008-05-01 Thread Wayne Fay
> The JBoss Product Versioning [0] suggests the following additional > well-known qualifiers: > - CR > - FINAL How is CR different from RC? One is Candidate Release, the other is Release Candidate. I think I'd pick one and forget about the other. Wayne ---

Re: Artifact Version Comparison

2008-05-01 Thread Benjamin Bentmann
Hervé BOUTEMY wrote: Kenney started a proposal http://docs.codehaus.org/display/MAVEN/Versioning with a implementation of a comparator. The JBoss Product Versioning [0] suggests the following additional well-known qualifiers: - CR - FINAL Benjamin [0] http://wiki.jboss.org/wiki/JBossProduc