Re: Adding wildcards to IncludesArtifactFilter

2007-06-19 Thread Mark Hobson
I've added the new filters to maven-common-artifact-filters as per John's suggestion in MNG-2621. Let me know if there's any probs. Mark On 18/06/07, Mark Hobson <[EMAIL PROTECTED]> wrote: Hi John, On 16/06/07, John Casey <[EMAIL PROTECTED]> wrote: > Just another pointer to add. I've put toge

Re: Adding wildcards to IncludesArtifactFilter

2007-06-19 Thread Mark Hobson
Hi Brian, On 18/06/07, Brian E. Fox <[EMAIL PROTECTED]> wrote: I'm pretty sure I just wrapped the core artifactsFilter impl so that I could deal with the collection. In any case that I can, I try to use the core functionality but sometimes I wrap it to do any additional work needed. This was don

RE: Adding wildcards to IncludesArtifactFilter

2007-06-18 Thread Brian E. Fox
have Karma to influence core. -Original Message- From: Mark Hobson [mailto:[EMAIL PROTECTED] Sent: Monday, June 18, 2007 8:53 AM To: Maven Developers List Subject: Re: Adding wildcards to IncludesArtifactFilter Hi Brian, On 15/06/07, Brian E. Fox <[EMAIL PROTECTED]> wrote: >

Re: Adding wildcards to IncludesArtifactFilter

2007-06-18 Thread Mark Hobson
Hi John, On 16/06/07, John Casey <[EMAIL PROTECTED]> wrote: Just another pointer to add. I've put together some wildcard filtering support for the assembly plugin, and factored it into a separate library so I could share it with the maven-repository- builder project. These wildcard-enabled filte

Re: Adding wildcards to IncludesArtifactFilter

2007-06-18 Thread Mark Hobson
Hi Brian, On 15/06/07, Brian E. Fox <[EMAIL PROTECTED]> wrote: Mark, There are already a bunch of filters defined within dependency for a lot of this. None of them work for you or is it that you need to access them from the shared component? I did see them, although they weren't really what I

Re: Adding wildcards to IncludesArtifactFilter

2007-06-16 Thread John Casey
defined within dependency for a lot of this. None of them work for you or is it that you need to access them from the shared component? -Original Message- From: Mark Hobson [mailto:[EMAIL PROTECTED] Sent: Friday, June 15, 2007 9:46 AM To: Maven Developers List Subject: Re: Addi

RE: Adding wildcards to IncludesArtifactFilter

2007-06-15 Thread Brian E. Fox
Developers List Subject: Re: Adding wildcards to IncludesArtifactFilter On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: > I think you have two different things here. The first visualizing the > tree removing certain aspects and this implies the resolution is > complete and you&

Re: Adding wildcards to IncludesArtifactFilter

2007-06-15 Thread Mark Hobson
On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: I think you have two different things here. The first visualizing the tree removing certain aspects and this implies the resolution is complete and you're looking at a reduction. The second is actually changing how the resolution happened in t

Re: Adding wildcards to IncludesArtifactFilter

2007-06-15 Thread Jason van Zyl
On 15 Jun 07, at 6:29 AM 15 Jun 07, Mark Hobson wrote: Hi Jason, On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: That one small typo will render a system useless. What's the usecase for not having to select individual artifacts to filter? The filters are looking like something that wil

Re: Adding wildcards to IncludesArtifactFilter

2007-06-15 Thread Mark Hobson
Hi Jason, On 15/06/07, Jason van Zyl <[EMAIL PROTECTED]> wrote: That one small typo will render a system useless. What's the usecase for not having to select individual artifacts to filter? The filters are looking like something that will be used to exclude dependencies and things of that natur

Re: Adding wildcards to IncludesArtifactFilter

2007-06-15 Thread Jason van Zyl
On 15 Jun 07, at 4:38 AM 15 Jun 07, Kenney Westerhof wrote: Mark Hobson wrote: Hi, I need an ArtifactFilter that supports wildcards and have patched IncludesArtifactFilter accordingly, but then saw MNG-2621. I implemented wildcards slightly stricter than allowing arbitrary regular expressio

Re: Adding wildcards to IncludesArtifactFilter

2007-06-15 Thread Mark Hobson
On 15/06/07, Kenney Westerhof <[EMAIL PROTECTED]> wrote: I think it's safest to assume no regexps at all, so your solution looks fine. Jason, you said in MNG-2621 it could wreak havoc - how so? I think it's safer to not allow * for partial matches too, but we have no choice in the version tag,

Re: Adding wildcards to IncludesArtifactFilter

2007-06-15 Thread Kenney Westerhof
Mark Hobson wrote: Hi, I need an ArtifactFilter that supports wildcards and have patched IncludesArtifactFilter accordingly, but then saw MNG-2621. I implemented wildcards slightly stricter than allowing arbitrary regular expressions - from the Javadoc: The artifact pattern syntax is of the