little late, but a big +1 from me too
Andy
On 16 Mar 2007, at 16:51, John Casey wrote:
Hi everyone,
I've performed a fairly significant refactoring of the lifecycle
executor on
the 2.1-lifecycle-refactor branch. The changes allow Maven to
construct a
build plan before execution begins in
Ah, well...that wasn't completely clear. I assumed your comments last night
were in lieu of the appointment you had made to review it. Sorry for the
mixup.
-john
On 3/20/07, Brett Porter <[EMAIL PROTECTED]> wrote:
For the record, I wasn't adding a +1 on IRC, but agreeing that it's
lazy consens
For the record, I wasn't adding a +1 on IRC, but agreeing that it's
lazy consensus based (so yes - go ahead). I still intend to review
when time permits :)
- Brett
On 21/03/2007, at 8:04 AM, John Casey wrote:
Brett added his +1 on IRC last night, making the total:
Binding: +3 (John, Jason
Brett added his +1 on IRC last night, making the total:
Binding: +3 (John, Jason, Brett)
Non-Binding: +2 (Brian, Milos)
I'm going to start the merge now.
-john
On 3/20/07, Milos Kleint <[EMAIL PROTECTED]> wrote:
very cool.
+1
Milos
On 3/20/07, Jason van Zyl <[EMAIL PROTECTED]> wrote:
> +1
very cool.
+1
Milos
On 3/20/07, Jason van Zyl <[EMAIL PROTECTED]> wrote:
+1
To be able to order correctly is a big improvement.
Also very cool is that we can now query and inspect what will happens
before it executes. One more step of providing declarative outputs
for plugins and we will know
+1
To be able to order correctly is a big improvement.
Also very cool is that we can now query and inspect what will happens
before it executes. One more step of providing declarative outputs
for plugins and we will know everything that could happen which will
make IDE integration very awe
+1. I tried this out and the output is much better than what we
currently have:
Summary view:
Build Plan:
1. org.apache.maven.plugins:maven-clean-plugin:2.1:clean [executionId:
default]
2. org.apache.maven.plugins:maven-plugin-plugin:2.2:descriptor
[executionId: def
ault]
3. org.apache.maven.plug
