I am a Maven user and we have custom plugins we wrote over at Apache
Commons and this type of change has been painful in the past, see
https://issues.apache.org/jira/browse/MNG-7316
I do not think we can make a blanket statement like "everything is
immutable" without causing a world of pain.
Gary
Hi Garry,
I understand what you are saying. I though that there was a discussion about
making the API immutable for mvn4. I also read that to modify some values on
the API, the best practice was to replace the value (collection?) with a new
one and not modify the actual one. What do you think?
Bad idea unless you can look at each call site and _guarantee_ that you
want an immutable Collection instead of a mutable one... which I do not see
how you can do especially once a Collection escapes an API. Unless you're
ok with breaking behavioral compatibility...
Gary
On Thu, May 19, 2022, 02:
Hi Sebastien,
On 18.05.22 17:57, Sebastien Doyon wrote:
Hi,
Recently I found some small potential improvements that could help clean the
maven code. I would be glad to contribute it back to my most useful Java
project, if you find it of interest.
The changes are mostly :
- Use of Collection
Hi,
Recently I found some small potential improvements that could help clean the
maven code. I would be glad to contribute it back to my most useful Java
project, if you find it of interest.
The changes are mostly :
- Use of Collections.emptyList() instead of new ArrayList() when possible.
- U
