Re: Profile activation/deactivation

2008-05-16 Thread Paul Gier
I added a proposal for some profile activation/deactivation improvements here: http://docs.codehaus.org/display/MAVENUSER/Improvements+to+Profile+Activation+Deactivation Please take a look and add comments if you are interested. Thanks! Paul Gier wrote: I would like to bring up a couple of

Re: Profile activation/deactivation

2008-05-16 Thread Paul Gier
ity, it is definitely profiles. --Brian -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Jesse McConnell Sent: Thursday, May 15, 2008 11:37 AM To: Maven Developers List; [EMAIL PROTECTED] Subject: Re: Profile activation/deactivation No one can dispute the ni

RE: Profile activation/deactivation

2008-05-15 Thread Brian E. Fox
f Of Jesse McConnell Sent: Thursday, May 15, 2008 11:37 AM To: Maven Developers List; [EMAIL PROTECTED] Subject: Re: Profile activation/deactivation No one can dispute the nice things that profiles let us accomplish in terms of toggling on functionalities... But I wonder much this will im

Re: Profile activation/deactivation

2008-05-15 Thread Paul Gier
John Casey wrote: The activeByDefault flag was originally designed to allow profiles to work as a group, with a default selection. Obviously, it's an incomplete design, since it doesn't allow for profiles that _aren't_ part of that grouping to be activated/deactivated independently. As for the

Re: Profile activation/deactivation

2008-05-15 Thread Paul Gier
Ralph Goers wrote: Paul Gier wrote: I would like to bring up a couple of issues related to profile activation and deactivation. While working on MNG-3545 I noticed some cases where the current behaviour might be improved. 1. What is the correct behaviour when there is more than one activ

Re: Profile activation/deactivation

2008-05-15 Thread John Casey
D/E were meant to work in cases where the - leading character might be a problem. If it's never a problem, we don't need them. If the only argument to the -P option can be something like "- myProfile" (leading dash) then we have no need for it...and the ! notation might make this even better

Re: Profile activation/deactivation

2008-05-15 Thread Paul Gier
2.0.x and 2.1 work the same after your change. "+" means activate and "-" means deactivate. I'm guessing it was just a typo in 2.1 that had them reversed. What's the reason for the D: and E: syntax? Do we need these if +,-,!, can be used? John Casey wrote: I looked at the logic for +/- the

Re: Profile activation/deactivation

2008-05-15 Thread Jesse McConnell
No one can dispute the nice things that profiles let us accomplish in terms of toggling on functionalities... But I wonder much this will impact build reproducibilityespecially given the existence of profiles in the settings.xml file. It is already a source of minor pain where people need to

Re: Profile activation/deactivation

2008-05-15 Thread John Casey
I looked at the logic for +/- the other day (when I added E: and D:, fwiw), and the logic was backward, IIRC...I fixed it in 2.1, but it may still be broken in 2.0.x, not sure... -john On May 14, 2008, at 5:44 PM, Brian E. Fox wrote: Need to think about 1& 2 some more but: 3. There was a

Re: Profile activation/deactivation

2008-05-15 Thread John Casey
The activeByDefault flag was originally designed to allow profiles to work as a group, with a default selection. Obviously, it's an incomplete design, since it doesn't allow for profiles that _aren't_ part of that grouping to be activated/deactivated independently. As for the default profil

Re: Profile activation/deactivation

2008-05-15 Thread Ralph Goers
+1. My first reaction though was the thought, what should -P-profile do? Is it confusing not to have it if + is supported? Would it be the same as -P!profile? Bernhard David wrote: would it be possible to have "-Pprofile" work as usual (activate profile, deactivate defaults) but "-P+profile

Re: Profile activation/deactivation

2008-05-15 Thread Ralph Goers
Paul Gier wrote: I would like to bring up a couple of issues related to profile activation and deactivation. While working on MNG-3545 I noticed some cases where the current behaviour might be improved. 1. What is the correct behaviour when there is more than one activeByDefault profile a

Re: Profile activation/deactivation

2008-05-15 Thread nicolas de loof
Same use case here. IMHO having a distinction between "-P profile" and "-P +profile" is acceptable. "-P profile" may work as it does today (specify the exact list of profiles, whith auto-disabled default ones). For backward compatibility, but also to enable exclusive profiles switching. 2008/5/1

Re: Profile activation/deactivation

2008-05-15 Thread Mark Hobson
Would a concept of profile groups help to determine which profiles are meant to be mutually exclusive? I use mutually exclusive profiles for different deployment configurations, for example development and production. By default, the development profile is actived by default, so currently -Pprodu

Re: Profile activation/deactivation

2008-05-14 Thread nicolas de loof
"mvn install -P+optionalTests" without having to > figure out what other profiles you need manually. > > Greetings, > > David Bernhard > > > > -Original Message- > > From: Jesse McConnell [mailto:[EMAIL PROTECTED] > > Sent: 15 May 2008 00:04 >

RE: Profile activation/deactivation

2008-05-14 Thread Bernhard David
:[EMAIL PROTECTED] > Sent: 15 May 2008 00:04 > To: Maven Developers List > Subject: Re: Profile activation/deactivation > > I think the ! is probably better then D: E: E: > > jesse > > On Wed, May 14, 2008 at 4:51 PM, Paul Gier <[EMAIL PROTECTED]> wrote: > >

RE: Profile activation/deactivation

2008-05-14 Thread Brian E. Fox
>Should I remove both "-" and "+" since they would both be redundant if we add "!"? I would. >So some examples would be: >mvn -P !profile1,profile2,profile3 Yep. >And in maven 2.1 currently this can also be expressed with: >mvn -P D:profile1,E:profile2,E:profile3 I would make it the same as

Re: Profile activation/deactivation

2008-05-14 Thread Jesse McConnell
I think the ! is probably better then D: E: E: jesse On Wed, May 14, 2008 at 4:51 PM, Paul Gier <[EMAIL PROTECTED]> wrote: > Brian E. Fox wrote: > > > > > Need to think about 1& 2 some more but: > > > > > > > 3. There was a suggestion to allow the use of "!" to disable a profile. > > > > > So th

Re: Profile activation/deactivation

2008-05-14 Thread Paul Gier
Brian E. Fox wrote: Need to think about 1& 2 some more but: 3. There was a suggestion to allow the use of "!" to disable a profile. So the command line would look like: mvn -P!myProfile This seems more intuitive than the current syntax using a dash, and I created MNG-3571 for it. But I

RE: Profile activation/deactivation

2008-05-14 Thread Brian E. Fox
Need to think about 1& 2 some more but: >3. There was a suggestion to allow the use of "!" to disable a profile. So the >command line would look like: mvn -P!myProfile >This seems more intuitive than the current syntax using a dash, and I created >MNG-3571 for it. But I'm hesitant to add it s

Re: Profile activation/deactivation

2008-05-14 Thread Benjamin Bentmann
Paul Gier wrote: 3. There was a suggestion to allow the use of "!" to disable a profile. So the command line would look like: mvn -P!myProfile Unless some severe drawback is reported, +1 on this because "!" is quite natural among programmers for negation and also matches the existing syntax

Profile activation/deactivation

2008-05-14 Thread Paul Gier
I would like to bring up a couple of issues related to profile activation and deactivation. While working on MNG-3545 I noticed some cases where the current behaviour might be improved. 1. What is the correct behaviour when there is more than one activeByDefault profile and I manually acti