Re: Plugins with Annotations ETA

2012-05-12 Thread Olivier Lamy
Omission ! I will fix that. Thanks for review and doc fix :-) -- Olivier Le 12 mai 2012 17:22, "Hervé BOUTEMY" a écrit : > great! well done! > > working on documentation, I found something strange: @Component annotation > doesn't provide readonly nor required attributes, that are available in > M

Re: Plugins with Annotations ETA

2012-05-12 Thread Hervé BOUTEMY
great! well done! working on documentation, I found something strange: @Component annotation doesn't provide readonly nor required attributes, that are available in Mojo Javadoc Tags. Is this expected or a simple omission? Regards, Hervé Le samedi 12 mai 2012 12:30:31 Olivier Lamy a écrit : >

Re: Plugins with Annotations ETA

2012-05-12 Thread Olivier Lamy
so all done :-). 2012/5/12 Olivier Lamy : > Update: help generation works now. > I have created a branch of compiler plugin using annotations as a > sample: > https://svn.apache.org/repos/asf/maven/plugins/branches/maven-compiler-plugin-annotations/ > > Now my idea is to create a branch 2.x from

Re: Plugins with Annotations ETA

2012-05-11 Thread Olivier Lamy
Update: help generation works now. I have created a branch of compiler plugin using annotations as a sample: https://svn.apache.org/repos/asf/maven/plugins/branches/maven-compiler-plugin-annotations/ Now my idea is to create a branch 2.x from the current and merge the branch in trunk. 2012/5/9

Re: Plugins with Annotations ETA

2012-05-10 Thread Mark Struberg
Thursday, May 10, 2012 9:34 PM > Subject: Re: Plugins with Annotations ETA > > 2012/5/10 Jesse Glick : >> On 05/09/2012 12:56 PM, Olivier Lamy wrote: >>> >>> we still need to do some javadoc parsing for @deprecated >> >> >> Just look for @D

Re: Plugins with Annotations ETA

2012-05-10 Thread Olivier Lamy
2012/5/10 Jesse Glick : > On 05/09/2012 12:56 PM, Olivier Lamy wrote: >> >> we still need to do some javadoc parsing for @deprecated > > > Just look for @Deprecated - the real annotation - instead. (Note that javac > will warn you if you have the Javadoc tag without the annotation.) > > >> @since a

Re: Plugins with Annotations ETA

2012-05-10 Thread Jesse Glick
On 05/09/2012 12:56 PM, Olivier Lamy wrote: we still need to do some javadoc parsing for @deprecated Just look for @Deprecated - the real annotation - instead. (Note that javac will warn you if you have the Javadoc tag without the annotation.) @since and comments for class/field description.

Re: Plugins with Annotations ETA

2012-05-10 Thread Mark Struberg
- > From: Jason van Zyl > To: Maven Developers List > Cc: > Sent: Thursday, May 10, 2012 1:15 AM > Subject: Re: Plugins with Annotations ETA > > > On May 9, 2012, at 3:30 PM, Mark Derricutt wrote: > >> On 10/05/12 7:47 AM, Jason van Zyl wrote: >>> The

Re: Plugins with Annotations ETA

2012-05-09 Thread Jason van Zyl
On May 9, 2012, at 3:30 PM, Mark Derricutt wrote: > On 10/05/12 7:47 AM, Jason van Zyl wrote: >> The only thing I would like to sync up on is a couple changes I want to make >> to the plugin manager to make sure the current plugin packaging, the plugin >> packaging you're making and the plugin

Re: Plugins with Annotations ETA

2012-05-09 Thread Olivier Lamy
2012/5/9 Jason van Zyl : > > On May 9, 2012, at 3:23 PM, Olivier Lamy wrote: > >> 2012/5/9 Jason van Zyl : >>> The only thing I might suggest is that you create a hybrid scanner that can >>> deal with the old and new. It looks like you've already looked at [1], but >>> the hybrid scanner is here[

Re: Plugins with Annotations ETA

2012-05-09 Thread Jason van Zyl
On May 9, 2012, at 3:23 PM, Olivier Lamy wrote: > 2012/5/9 Jason van Zyl : >> The only thing I might suggest is that you create a hybrid scanner that can >> deal with the old and new. It looks like you've already looked at [1], but >> the hybrid scanner is here[2]. > Thanks but this mix scannin

Re: Plugins with Annotations ETA

2012-05-09 Thread Olivier Lamy
And btw make changes you need. I have added some its for basic use cases with annotations. 2012/5/9 Olivier Lamy : > 2012/5/9 Jason van Zyl : >> The only thing I might suggest is that you create a hybrid scanner that can >> deal with the old and new. It looks like you've already looked at [1], bu

Re: Plugins with Annotations ETA

2012-05-09 Thread Mark Derricutt
On 10/05/12 7:47 AM, Jason van Zyl wrote: The only thing I would like to sync up on is a couple changes I want to make to the plugin manager to make sure the current plugin packaging, the plugin packaging you're making and the plugin packaging I'm working on in Tesla all work together without

Re: Plugins with Annotations ETA

2012-05-09 Thread Olivier Lamy
2012/5/9 Jason van Zyl : > The only thing I might suggest is that you create a hybrid scanner that can > deal with the old and new. It looks like you've already looked at [1], but > the hybrid scanner is here[2]. Thanks but this mix scanning is already implemented in the branch. Currently the onl

Re: Plugins with Annotations ETA

2012-05-09 Thread Manfred Moser
Its great to see this teamwork happening from the outside. Keep it up! manfred On Wed, May 9, 2012 12:47 pm, Jason van Zyl wrote: > The only thing I might suggest is that you create a hybrid scanner that > can deal with the old and new. It looks like you've already looked at [1], > but the hybrid

Re: Plugins with Annotations ETA

2012-05-09 Thread Jason van Zyl
The only thing I might suggest is that you create a hybrid scanner that can deal with the old and new. It looks like you've already looked at [1], but the hybrid scanner is here[2]. The only thing I would like to sync up on is a couple changes I want to make to the plugin manager to make sure t

Plugins with Annotations ETA

2012-05-09 Thread Olivier Lamy
Hi, So I have pushed some stuff on supporting plugin descriptor generation from annotations as described here [1]. I have added support of having annotations from parent classes even if they are not in the same project (from reactors and/or dependencies). BTW we still need to do some javadoc parsin