Re: Please review checkstyle plugin docs

2006-07-26 Thread Maria Odea Ching
Hi Everyone, I've already revised and applied the review comments in the plugin docs. :-) Btw, for the shared jar configuration issue in "Multimodule Configuration", I've just revised the page and mentioned the shared jar configuration issue (declaring it as an extension instead of as a plu

Re: Please review checkstyle plugin docs

2006-07-24 Thread Maria Odea Ching
Thanks everyone for your comments :-) I'll post them in Jira and I'll fix the docs :-) Odea Vincent Siveton wrote: Thanks Maria, here my comments: usage.html Should be better to create two subsections: - Generate the report as part of Project Reports - Generate the report as standalone Mayb

Re: Please review checkstyle plugin docs

2006-07-24 Thread Vincent Siveton
Thanks Maria, here my comments: usage.html Should be better to create two subsections: - Generate the report as part of Project Reports - Generate the report as standalone Maybe add a report screenshot FAQ "checkstyle.properties" or "checkstyle properties" (with space) If the first, the followi

Re: Please review checkstyle plugin docs

2006-07-24 Thread Dennis Lundberg
Stephen Duncan wrote: On the "Multimodule Configuration" documentation: As I just mentioned on a question on the user's list, I don't think it's correct to specify the "build-tools" dependency as a dependency of the plugin. While this will work if you manually install the build-tools jar, it wi

Re: Please review checkstyle plugin docs

2006-07-24 Thread Stephen Duncan
On the "Multimodule Configuration" documentation: As I just mentioned on a question on the user's list, I don't think it's correct to specify the "build-tools" dependency as a dependency of the plugin. While this will work if you manually install the build-tools jar, it will not download it from

Please review checkstyle plugin docs

2006-07-24 Thread Maria Odea Ching
Hi Everyone, The Checkstyle plugin documentation is now ready for review :) A staging site is available at http://people.apache.org/~oching/maven-checkstyle-plugin Thanks, Odea -