Re: Patch for war plugin filtering needs review

2008-08-02 Thread Dennis Lundberg
http://jira.codehaus.org/browse/MRESOURCES-56 "use (and release) the maven-filtering component" Stephane Nicoll wrote: My mistake, it works with the war plugin. I think I need more coffee! The bug is still there in the resources plugin though so we might need to migrate it to the maven-filtering

Re: Patch for war plugin filtering needs review

2008-08-02 Thread Stephane Nicoll
On Sat, Aug 2, 2008 at 5:36 AM, Wendy Smoak <[EMAIL PROTECTED]> wrote: > MWAR-133 (Filtering issue: wrong replacement of properties by values > from MavenProject object) was mentioned when I asked about releasing > the war plugin. It has 11 votes and there is a patch attached. Does > anyone have

Re: Patch for war plugin filtering needs review

2008-08-02 Thread Stephane Nicoll
My mistake, it works with the war plugin. I think I need more coffee! The bug is still there in the resources plugin though so we might need to migrate it to the maven-filtering component. Olivier, is this scheduled? S. On Sat, Aug 2, 2008 at 3:43 PM, Stephane Nicoll <[EMAIL PROTECTED]>wrote: >

Re: Patch for war plugin filtering needs review

2008-08-02 Thread Stephane Nicoll
OK, it is still broken and we really need to have a look to this. I am pretty sure we will break the backward compat if we want to have a consistent behavior. The related issues are MRESOURCES-20 and MWAR-133. I have an IT for MWAR-133 and it uses the maven filtering component. I will have a look n

Re: Patch for war plugin filtering needs review

2008-08-01 Thread Stephane Nicoll
This should have been fixed now we use the shared filtering component that Olivier made. I can write an IT to validate the scenario and I will do today or tomorrow. In any case, we need a release of the filtering component. I am also waiting for this release to finalize the ear plugin 2.3.2. Thanks

Patch for war plugin filtering needs review

2008-08-01 Thread Wendy Smoak
MWAR-133 (Filtering issue: wrong replacement of properties by values from MavenProject object) was mentioned when I asked about releasing the war plugin. It has 11 votes and there is a patch attached. Does anyone have time to review it? If this is not fixed before the next release, should the plu