Re: New link pattern when option is set to true

2019-11-09 Thread Enrico Olivelli
Max Sorry for so late reply I left an idea on the pr, about making it more extensible. Let's follow up the discussion on the pr Cheers Enrico Il sab 9 nov 2019, 10:06 Max Zhu ha scritto: > hi Enrico, > > How does the PR look? Anything I need to follow up on? > > Max > > On Sun, Nov 3, 2019

Re: New link pattern when option is set to true

2019-11-03 Thread Max Zhu
Raised PR with unit test and integration test included: https://github.com/apache/maven-javadoc-plugin/pull/34 This is my first PR for any of the maven project. Although I made my best effort to follow all the coding conventions, surely there will be something missing. So feel free to point out.

Re: New link pattern when option is set to true

2019-11-03 Thread Max Zhu
thanks. Created: https://issues.apache.org/jira/browse/MJAVADOC-628 Max On Sun, Nov 3, 2019 at 4:51 AM Enrico Olivelli wrote: > Hi Max. > sorry for late reply. > > I think your idea is interesting and you work is valuable, > You can follow up by creating a JIRA in issues.apache.org in MJAVADOC

Re: New link pattern when option is set to true

2019-11-02 Thread Enrico Olivelli
Hi Max. sorry for late reply. I think your idea is interesting and you work is valuable, You can follow up by creating a JIRA in issues.apache.org in MJAVADOC project and then you can also send a PR. Please add an integration test. this is the guide for new contributors https://maven.apache.org/g

Re: New link pattern when option is set to true

2019-11-01 Thread Max Zhu
hi, Any update on this please? Is this mail group actively monitored? or should I raise a pull request directly to the project? Max On Mon, Oct 28, 2019 at 6:12 PM Max Zhu wrote: > For what's worth I am talking about maven-javadoc-plugin (just realized > this is the main maven mail group) > >

Re: New link pattern when option is set to true

2019-10-28 Thread Max Zhu
For what's worth I am talking about maven-javadoc-plugin (just realized this is the main maven mail group) On Sat, Oct 26, 2019 at 6:51 PM Max Zhu wrote: > hi, > > Wondering if it makes sense to extend option to javadoc.io. > > For example, google gson (https://github.com/google/gson) has point

New link pattern when option is set to true

2019-10-27 Thread Max Zhu
hi, Wondering if it makes sense to extend option to javadoc.io. For example, google gson (https://github.com/google/gson) has pointed their javadoc to https://www.javadoc.io/doc/com.google.code.gson/gson on their README.md. But currently, maven-javadoc-plugin will only try to fetch https://githu