Re: Naming of ITs in maven-release

2019-07-22 Thread Clemens Quoss
Hi Robert, having put some more thought into it I was thinking:  maybe the IT should prove that the jira issue integrates with the plugin.  In that case the name would be OK and I would also have a path for providing an IT for MRELEASE-229.  As of now there are no ITs for release:rollback.   I

Re: Naming of ITs in maven-release

2019-07-22 Thread Robert Scholte
Hi Clemens, since the codebase is already rather old, you'll see that naming convention has changed over the years. Nowadays I prefer to to start with the JIRA id, followed by a very short statement of the IT. In the end I'm more important that there is at least a test than the name. Just k

Re: Naming of ITs in maven-release

2019-07-17 Thread Tibor Digana
Clemens, why the issues cannot use Jira ID only? If somebody wants to know more, she/he can still open Jira and see. Another position is when you develop a new feature and then human readable name should be used. This way we know that we have more ITs for bug than originally TDD features, or oposit

Re: Naming of ITs in maven-release

2019-07-17 Thread Clemens Quoss
Hi, I wrote unit tests with scm mocked away [0]. But IT: I do not know how and what. Cheers, Clemens [0] https://github.com/apache/maven-release/pull/29/files#diff-bd93f43863e2917722a94ccc46af95a8 Am 17.07.2019 um 08:22 schrieb Olivier Lamy: Hi I understand it can be complicated to write such

Re: Naming of ITs in maven-release

2019-07-16 Thread Olivier Lamy
Hi I understand it can be complicated to write such it which need some scm.. Maybe write a unit at least? On Tue, 16 Jul 2019 at 05:20, Clemens Quoss wrote: > Hi Olivier, > yeah, could do that. Would be a great idea. But i am stuck on what to > put into this IT: > RemoveScmTag does what the na

Re: Naming of ITs in maven-release

2019-07-15 Thread Clemens Quoss
Hi Olivier, yeah, could do that.  Would be a great idea.  But i am stuck on what to put into this IT: RemoveScmTag does what the name suggests:  it uses maven-scm to remove the tag during release:rollback. In the unit tests maven-scm is mocked away and i think in the ITs of maven-release maven-

Re: Naming of ITs in maven-release

2019-07-14 Thread Olivier Lamy
Hi I agree the name is a bit confusing... maybe name the IT: MRELEASE-229-RemoveScmTagPhase? On Sun, 14 Jul 2019 at 20:06, Clemens Quoss wrote: > Hello everyone, > > one more question regarding the name of the ITs in maven-release (or > maybe generally): > > Seeing that the tests are named afte

Naming of ITs in maven-release

2019-07-14 Thread Clemens Quoss
Hello everyone, one more question regarding the name of the ITs in maven-release (or maybe generally): Seeing that the tests are named after the jira issues i am wondering if that would be the right thing to do. Shouldn't they be named after the functionality they are testing? I for my par