Re: MavenProject apparent inconsistencies

2024-09-23 Thread Elliotte Rusty Harold
One thing I "learned" when interviewing new grads was that all numbers are ints and all data structures are lists. :-) Any question that required a set, a map, or a floating point number would quickly weed out about 90% of candidates. On Mon, Sep 23, 2024 at 11:08 AM Martin Desruisseaux wrote: >

Re: MavenProject apparent inconsistencies

2024-09-23 Thread Martin Desruisseaux
Le 2024-09-23 à 12 h 53, Gary Gregory a écrit : Speaking of collections... In some code bases I review (not here) a List is often used when a Set would semantically correct. Is there an opportunity in m3 or m4 for such a change? Yes, I also though about that. Especially since I have seen cod

Re: MavenProject apparent inconsistencies

2024-09-23 Thread Gary Gregory
Speaking of collections... In some code bases I review (not here) a List is often used when a Set would semantically correct. Is there an opportunity in m3 or m4 for such a change? Gary On Mon, Sep 23, 2024, 6:32 AM Martin Desruisseaux < martin.desruisse...@geomatys.com> wrote: > Hello again > >

Re: MavenProject apparent inconsistencies

2024-09-23 Thread Martin Desruisseaux
Le 2024-09-23 à 12 h 32, Martin Desruisseaux a écrit : Would it be okay if I modify the implementation with the following goals? * All setter methods make a defensive copy of the given collection, preserving Set order. * All getter methods returns an unmodifiable (but not necessarily

MavenProject apparent inconsistencies

2024-09-23 Thread Martin Desruisseaux
Hello again In my attempt to add a List to Maven, I got hesitations about what to do with the following file: * https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/project/MavenProject.java This class contains many collections, but I'm not sure if they are