Looking only at the log, both writers existed before it was promoted from the
sandbox in 2007.
Counter was introduced by Karl Heinz while refactoring.
It could very well be there's a better solution for it right now.
I would expect enough coverage by ITs to confirm that.
Robert
On 9-8-2021 16:35:
Howdy,
re maven-shade-plugin's Java package org.apache.maven.plugins.shade.pom:
1. What is the goal of this code? As there are 3 classes in here, and
Counter is used only by MavenJDOMWriter, while MavenJDOMWriter is used only
by PomWriter, while PomWriter is used only by ShadeMojo (to write out d
Thanks for reviewing and committing the patch. Could you also deploy a new
snapshot build to the apache snapshot repository?
Thanks,
Trask
On Sun, Nov 20, 2011 at 10:12 AM, Trask Stalnaker wrote:
> Thanks so much for the response. I look forward to your review of the
> patch. I'm happy to re
Thanks so much for the response. I look forward to your review of the
patch. I'm happy to re-write it taking a different approach if you see
fit, so just shoot me your feedback.
Thanks again.
Trask
On Sun, Nov 20, 2011 at 5:00 AM, Benson Margulies wrote:
> Trask,
>
> No problem, but in the fu
Trask,
No problem, but in the future feel free to send such a thing to the
maven dev list.
I'll look at your patch. Honestly, there's no one who is very reliably
looking for new patches across many of the plugins, so a ping is a
good idea.
We generally don't release for only one patch, and we re
