Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-22 Thread Mark Struberg
lopers List > Cc: > Sent: Monday, May 21, 2012 10:30 PM > Subject: Re: Maven Plugins annotations support @Component role attribute to > Class > > On 5/21/12 7:03 AM, Olivier Lamy wrote: >> 2012/5/21 Brett Porter: >>> >>> On 21/05/2012, at 3:45 AM, Herv

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-21 Thread Hervé BOUTEMY
iginal Message - > > > From: Olivier Lamy > > To: Maven Developers List > > Cc: > > Sent: Monday, May 21, 2012 5:06 PM > > Subject: Re: Maven Plugins annotations support @Component role attribute > > to Class> > > 2012/5/21 Brett Porter : > >

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-21 Thread Hervé BOUTEMY
sage - > > > From: Brett Porter > > To: Maven Developers List > > Cc: > > Sent: Monday, May 21, 2012 7:22 AM > > Subject: Re: Maven Plugins annotations support @Component role attribute > > to Class> > > On 21/05/2012, at 3:45 AM, Hervé BOUTEMY

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-21 Thread John Casey
On 5/21/12 7:03 AM, Olivier Lamy wrote: 2012/5/21 Brett Porter: On 21/05/2012, at 3:45 AM, Hervé BOUTEMY wrote: here, the end-user is a plugin developer, then someone who should be able to create a (Plexus) component when necessary Yes, I liked @Component too but as soon as you write a compo

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-21 Thread Mark Struberg
strub - Original Message - > From: Olivier Lamy > To: Maven Developers List > Cc: > Sent: Monday, May 21, 2012 5:06 PM > Subject: Re: Maven Plugins annotations support @Component role attribute to > Class > > 2012/5/21 Brett Porter : >> >> On 21/05/2012, at

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-21 Thread Olivier Lamy
2012/5/21 Brett Porter : > > On 21/05/2012, at 9:03 PM, Olivier Lamy wrote: > >> 2012/5/21 Brett Porter : >>> >>> On 21/05/2012, at 3:45 AM, Hervé BOUTEMY wrote: >>> here, the end-user is a plugin developer, then someone who should be able to create a (Plexus) component when necessa

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-21 Thread Brett Porter
On 21/05/2012, at 9:03 PM, Olivier Lamy wrote: > 2012/5/21 Brett Porter : >> >> On 21/05/2012, at 3:45 AM, Hervé BOUTEMY wrote: >> >>> here, the end-user is a plugin developer, then someone who should be able to >>> create a (Plexus) component when necessary >>> >>> Yes, I liked @Component too

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-21 Thread Olivier Lamy
2012/5/21 Brett Porter : > > On 21/05/2012, at 3:45 AM, Hervé BOUTEMY wrote: > >> here, the end-user is a plugin developer, then someone who should be able to >> create a (Plexus) component when necessary >> >> Yes, I liked @Component too but as soon as you write a component and inject >> somponent

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Mark Struberg
ike a @Qualifier (kind of a typesafe bean 'name') which gets used on both? LieGrue, strub - Original Message - > From: Brett Porter > To: Maven Developers List > Cc: > Sent: Monday, May 21, 2012 7:22 AM > Subject: Re: Maven Plugins annotations support @Compon

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Brett Porter
On 21/05/2012, at 3:45 AM, Hervé BOUTEMY wrote: > here, the end-user is a plugin developer, then someone who should be able to > create a (Plexus) component when necessary > > Yes, I liked @Component too but as soon as you write a component and inject > somponents inside it, you discover the d

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Ansgar Konermann
Am 20.05.2012 19:46 schrieb "Hervé BOUTEMY" : > > here, the end-user is a plugin developer, then someone who should be able to > create a (Plexus) component when necessary > > Yes, I liked @Component too but as soon as you write a component and inject > somponents inside it, you discover the discre

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Hervé BOUTEMY
here, the end-user is a plugin developer, then someone who should be able to create a (Plexus) component when necessary Yes, I liked @Component too but as soon as you write a component and inject somponents inside it, you discover the discrepency: the more I work on this, the more I discover th

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Olivier Lamy
for sure you can use @Component( role = ArtifactMetadataSource.class, roleHint = "maven" ) protected Object artifactMetadataSource; :-) 2012/5/20 Mirko Friedenhagen : > Hello Olivier, > > hopefully the role and the type of the member are  not always redundant :-): > > --- snip --- > @Component(

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Olivier Lamy
Perso, I prefer @Component more "auto documented" name. IMHO The goal is to hide to end user what is used in core so why using plexus naming. 2012/5/20 Hervé BOUTEMY : > of course, +1 since we discussed it :) > > but thinking once more at it, I just found that @Component should be renamed > to @Re

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Hervé BOUTEMY
of course, +1 since we discussed it :) but thinking once more at it, I just found that @Component should be renamed to @Requirement, to match corresponding plexus annotation, isn't it? Regards, Hervé Le dimanche 20 mai 2012 09:00:05 Olivier Lamy a écrit : > Hi, > > After discussion on irc wit

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Mirko Friedenhagen
Hello Olivier, hopefully the role and the type of the member are not always redundant :-): --- snip --- @Component( role = ArtifactMetadataSource.class, roleHint = "maven" ) protected ArtifactMetadataSource artifactMetadataSource; --- snap --- Regards Mirko On Sun, May 20, 2012 at 10:56 AM, Ro

Re: Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Robert Scholte
+1 Robert Op Sun, 20 May 2012 09:00:05 +0200 schreef Olivier Lamy : Hi, After discussion on irc with Hervé, I think role attribute in @Component can be of type Class rather than String. @Component( role = ArtifactMetadataSource.class, roleHint = "maven" ) protected ArtifactMetadataSo

Maven Plugins annotations support @Component role attribute to Class

2012-05-20 Thread Olivier Lamy
Hi, After discussion on irc with Hervé, I think role attribute in @Component can be of type Class rather than String. @Component( role = ArtifactMetadataSource.class, roleHint = "maven" ) protected ArtifactMetadataSource artifactMetadataSource; Any objections on this change ? Thanks, --