[DISCUSS][MSC] Establish workflows and definitions for Apache Maven issue tracker

Hi all, as already mentioned, I will create a mail thread for each epic that we defined for the “Support & Care for Apache Maven” initiative (https://open-elements.com/support-care-maven/). All information about this specific epic can be found at https://github.com/OpenElements/maven-support-c

Re: Maven issue with JDK16 - javac and javadoc

Hi, sorry for the late reply… Enrico I think the latest version should work, and here is the IT (I just didn’t create a PR yet): https://github.com/apache/maven-compiler-plugin/pull/37 MCOMPILER-445/pom.xml succeeds, other tests fail because of an outdated groovy plugin. I will push another commi

Re: Maven issue with JDK16 - javac and javadoc

On 12 Nov 2020, at 14:50, Graham Leggett wrote: > I have been smashing my head against the javadoc plugin and > maven-release-plugin, which keeps failing releases over and over again on the > basis that the docs can’t be built. > > In the absence of a way to fix this, if there is a way to swit

Re: Maven issue with JDK16 - javac and javadoc

I am testing latest build of openjdk16, it seems to me that the problem has been resolved Benjamin, can you please try ? probably there is no need for a fix on Maven Enrico Il giorno lun 14 dic 2020 alle ore 22:12 Benjamin Marwell < bmarw...@apache.org> ha scritto: > > I'm pretty sure this

Re: Maven issue with JDK16 - javac and javadoc

> I'm pretty sure this can be solved without touching the maven startup scripts. > And I don't like the idea to hack the script Agreed. I did not like the idea either, and even worse, I was unable to reproduce the results I had. Am Mo., 14. Dez. 2020 um 21:58 Uhr schrieb Robert Scholte < rfscho

Re: Maven issue with JDK16 - javac and javadoc

I'm pretty sure this can be solved without touching the maven startup scripts. And I don't like the idea to hack the script because one plugin has issues. I expect good help on your question on the jigsaw mailinglist. Robert On 14-12-2020 15:21:04, Benjamin Marwell wrote: I was able to provide a

Re: Maven issue with JDK16 - javac and javadoc

Il giorno lun 14 dic 2020 alle ore 15:21 Benjamin Marwell < bmarw...@apache.org> ha scritto: > I was able to provide a test, but the only solution to the underlying I > found was to modify the mvn start script by adding the missing modules (or > maybe even better: all system modules). > I tried w

Re: Maven issue with JDK16 - javac and javadoc

I was able to provide a test, but the only solution to the underlying I found was to modify the mvn start script by adding the missing modules (or maybe even better: all system modules). >From what I could see from slack, plexus compiler would need to be a module, requiring jdk.javadoc. Thus, we

Re: Maven issue with JDK16 - javac and javadoc

JIRA issue (please kindly review): https://issues.apache.org/jira/browse/MCOMPILER-445 Am So., 13. Dez. 2020 um 14:07 Uhr schrieb Benjamin Marwell < bmarw...@apache.org>: > > If is has proven itself for jlink, then we know we can do the same for > all other tools. > > I tested my PR with a JavaF

Re: Maven issue with JDK16 - javac and javadoc

> If is has proven itself for jlink, then we know we can do the same for all other tools. I tested my PR with a JavaFX app and it did work. But there's no release yet, only the ITs and my test project. But adding a parameter to disable the ToolProvider as a fallback should not be a problem. A tes

Re: Maven issue with JDK16 - javac and javadoc

Yes, that makes a lot of sense. If is has proven itself for jlink, then we know we can do the same for all other tools. If we have a good feeling about the implementation, we could use it at reference for other plugins as some kind of pattern. Robert On 13-12-2020 11:39:02, Benjamin Marwell wro

Re: Maven issue with JDK16 - javac and javadoc

Il Dom 13 Dic 2020, 11:38 Benjamin Marwell ha scritto: > Robert already suggested to use ToolProvider for the JDK9+ builds. I > created such a patch for jlink and I could create s similar one for the > compiler and javadoc plugin. This would solve the underlying problem from > my understanding. >

Re: Maven issue with JDK16 - javac and javadoc

Robert already suggested to use ToolProvider for the JDK9+ builds. I created such a patch for jlink and I could create s similar one for the compiler and javadoc plugin. This would solve the underlying problem from my understanding. As fork mode and fork count would not apply, I would suggest that

Re: Maven issue with JDK16 - javac and javadoc

Is anyone interested in helping with this problem? Otherwise with the advent of jdk16 we will probably see people that need to switch to fork mode for javac, with slower builds, and we will see complaints from users The problem probably is is plexus compiler and the way we start javac, we should

Re: Maven issue with JDK16 - javac and javadoc

Yes, the problem is about javac with "no-fork + -Xdoclint" using no-fork is not a good option because it slows down a lot big multi module projects Enrico Il giorno gio 12 nov 2020 alle ore 13:55 Romain Manni-Bucau < rmannibu...@gmail.com> ha scritto: > @Graham I guess you can force the compile

Re: Maven issue with JDK16 - javac and javadoc

@Graham I guess you can force the compiler to fork and force doclint to none in javadoc plugin config (ensure to use a recent version). Romain Manni-Bucau @rmannibucau | Blog | Old Blog | Gith

Re: Maven issue with JDK16 - javac and javadoc

On 12 Nov 2020, at 14:03, Enrico Olivelli wrote: > I have fallen into this issue about Maven + Maven Compiler Plugin + JDK16 > > This is the issue on JDK issue tracking > https://bugs.openjdk.java.net/browse/JDK-8253996 > > Basically -Xdoclint:missing does not work anymore when you run javac in

Re: Maven issue with JDK16 - javac and javadoc

+1, got some weirdness on j11 too. We should really have a way to ignore these errors, it is too impacting, in particular when javadoc are only deployed to make central or our nexus happy. Romain Manni-Bucau @rmannibucau | Blog

Maven issue with JDK16 - javac and javadoc

Hi folks, I have fallen into this issue about Maven + Maven Compiler Plugin + JDK16 This is the issue on JDK issue tracking https://bugs.openjdk.java.net/browse/JDK-8253996 Basically -Xdoclint:missing does not work anymore when you run javac inside the same JVM as Maven core, because the JVM lack

[GitHub] maven issue #161: [MNG-6370] Fix typo in list filtering ConcurrencyDependenc...

Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/161 Sure, unit test are always funny part:) done --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional comm

[GitHub] maven issue #161: [MNG-6370] Fix typo in list filtering ConcurrencyDependenc...

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/161 @slachiewicz I am ready to merge, @rfscholte [requested a unit test](https://www.mail-archive.com/dev@maven.apache.org/msg116360.html). Can you add one and I will merge it with a smile= ---

[GitHub] maven issue #135: [MNG-6296] Parse properties before configuring the logging...

Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/135 Merged to master http://git-wip-us.apache.org/repos/asf/maven/commit/b2afafe5 --- - To unsubscribe, e-mail: dev-unsubscr...@ma

[GitHub] maven issue #158: [MNG-4347] Set the profiles on reecursive dependencyManage...

Github user clarkperkins commented on the issue: https://github.com/apache/maven/pull/158 Looks like there's a better solution out there for this, I'm going to close this. --- - To unsubscribe, e-mail: dev-unsubscr.

[GitHub] maven issue #158: [MNG-4347] Set the profiles on reecursive dependencyManage...

Github user clarkperkins commented on the issue: https://github.com/apache/maven/pull/158 I just found this issue in jira - looks like it's closed as a won't-fix... so sounds like there's a reason this hasn't been fixed before ---

[GitHub] maven issue #153: [MNG-6069] Migrate to non deprecated parts of Commons CLI

Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/153 I don't see that piece of code, but if it works, that's fine. Jason added a comment about exposing them as System properties. I don't think we should remove that right now, but with a major version.

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/151 Thank you for the explanation, I have seen previous discussions about the update - for sure the refreshment of the topic will be useful like MNG-6169 I have prepared fix for MNG-5992 and clossi

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/151 other topics: - MNG-5968 is closed - MNG-5968 is not about default plugins versions, but about Maven core build if you rework this PR to focus on MNG-5992, ie providing a more secure

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/151 I'm not a fan of default plugins updates in core: - depending on default versions is a bad practice, we expect users to explicitely choose their version through pluginManagement (and we display a

[GitHub] maven issue #151: [MNG-5968] Default plugin version updates

Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/151 I found this changes in abdoned 3.4 line. Should also fix MNG-5992 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.o

[GitHub] maven issue #149: Upgrade maven-checkstyle-plugin to 3.0.0 (Checkstyle 6.18)...

Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/149 Please verify after planned plugin release --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional comman

[GitHub] maven issue #148: [MNG-5600] Dependency management import should support exc...

Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/148 [Corresponding IT pull request.](https://github.com/apache/maven-integration-testing/pull/30) --- - To unsubscribe, e-mai

[GitHub] maven issue #147: [MNG-5527] Dependency management import should support rel...

Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/147 [Corresponding IT pull request.](https://github.com/apache/maven-integration-testing/pull/29) --- - To unsubscribe, e-mai

[GitHub] maven issue #146: [MNG-4463] Dependency management import should support ver...

Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/146 [Corresponding IT pull request.](https://github.com/apache/maven-integration-testing/pull/28) --- - To unsubscribe, e-mai

[GitHub] maven issue #143: [MNG-5359] Declared execution in PluginMgmt gets bound to ...

Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/143 [Corresponding IT pull request.](https://github.com/apache/maven-integration-testing/pull/27) --- - To unsubscribe, e-mai

[GitHub] maven issue #136: [MNG-6302] logging the module count

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/136 @hboutemy Tested your branch. Great improvement to the PR! +1 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For

[GitHub] maven issue #136: [MNG-6302] logging the module count

Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/136 merged as a branch in Maven git https://github.com/apache/maven/tree/MNG-6302_module-progress and reworked to avoid additional line "Module i/n" but have instead integrated at the end of "Buildin

[GitHub] maven issue #136: [MNG-6302] logging the module count

Github user stephenc commented on the issue: https://github.com/apache/maven/pull/136 👍 --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org

[GitHub] maven issue #136: [MNG-6302] logging the module count

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/136 Looks good to me. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/118 This one can be closed. --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h..

[GitHub] maven issue #109: Update Mockito to 2.x

Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/109 great, thank you --- - To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.ap

[GitHub] maven issue #109: Update Mockito to 2.x

Github user slachiewicz commented on the issue: https://github.com/apache/maven/pull/109 ok, MNG-6196 with slf4j was merged to master - i'm clossing this issue. Mockito will be in diffrent pull. --- - To unsubscribe

[GitHub] maven issue #129: [MNG-6282] jansi downgraded from 1.16 to 1.15 in order to ...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/129 Closed as per conversation with @hboutemy on JIRA, see this [comment](https://issues.apache.org/jira/browse/MNG-6282?focusedCommentId=16161977&page=com.atlassian.jira.plugin.system.issuetabpanels:com

[GitHub] maven issue #113: [MNG-6127] Fix plugin execution configuration interference

Github user mkrizmanic commented on the issue: https://github.com/apache/maven/pull/113 Merged to master: https://github.com/apache/maven/commit/f1ed6592b1c701834d1377fade6cdb382a63bbf4 --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] maven issue #87: [MNG-5457] Added the repository id to show which repository...

Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/87 @rajivpjs can you close this pullrequest? This open PR causes warnings for https://issues.apache.org/jira/browse/MNG-5457 on the release page. --- If your project is set up for it, you can reply to

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

Github user grkvlt commented on the issue: https://github.com/apache/maven/pull/127 ping? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] maven issue #114: MNG-6220 add color CLI option

Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 Great thanks @rfscholte ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] maven issue #114: MNG-6220 add color CLI option

Github user agudian commented on the issue: https://github.com/apache/maven/pull/114 @rfscholte: looks good! 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[GitHub] maven issue #114: MNG-6220 add color CLI option

Github user rfscholte commented on the issue: https://github.com/apache/maven/pull/114 Here's my proposal: https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=fd57754218e749305be1dd745fda9407960cf985 --- If your project is set up for it, you can reply to this email and hav

[GitHub] maven issue #114: MNG-6220 add color CLI option

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/114 I don't might to pick this up, but it won't happen before Sep for personal priorities. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] maven issue #114: MNG-6220 add color CLI option

Github user mryan43 commented on the issue: https://github.com/apache/maven/pull/114 I feel stuck until someone with more experience of the maven code base update the version of maven-shared-utils to 3.2.1-SNAPSHOT on the default branch, anyone up to the task ? --- If your project i

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

Github user grkvlt commented on the issue: https://github.com/apache/maven/pull/127 @Tunaki I will disable the *CR* test, then --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 Looks like we have a similar bug in `mvn.cmd`. The added `testJvmConfigFileCR` test fails on Windows: ``` testJvmConfigFileCR(org.apache.maven.it.MavenITmng6255FixConcatLines) Time elapse

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 No, sorry, I can't "assign" this to anyone, you just have to wait for somebody to review and merge this pull request. --- If your project is set up for it, you can reply to this email and have you

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

Github user dbmeneses commented on the issue: https://github.com/apache/maven/pull/125 @ifedorenko Ok, thanks for the help preparing the p/r. Is there anyone you could assign the review to? --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...

Github user etzelc commented on the issue: https://github.com/apache/maven/pull/128 Now in `mvn.cmd` the string parameter of the echo command is surrounded with double quotes, like in `mvn`. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...

Github user etzelc commented on the issue: https://github.com/apache/maven/pull/128 I will have a closer look next week, right now only tested with Windows (since only cmd script was modified). In the {{mvn}} script the string of the {{echo}} is already completely in double quotes, bu

[GitHub] maven issue #128: [MNG-6256] Surround variables in echo command with double ...

Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/128 Shouldn't there be the same fix for `mvn`, and not just `mvn.cmd`? [`${basedir}`](https://github.com/apache/maven/blob/707cff6ffdecbfb0e0356c70e3a7b490535e7ce4/apache-maven/src/bin/mvn#L150) and [`${a

[GitHub] maven issue #127: [MNG-6255] Fix concat_lines in mvn to deal with CRLF

Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 This looks OK, verified with `bash` and `dash` (on Ubuntu 16.04), `tcsh` and `sh` (on FreeBSD 11.0). Could you add an integration test for this (https://github.com/apache/maven-integration-testing)?

[GitHub] maven issue #127: Fix concat_lines in mvn to deal with CRLF

Github user grkvlt commented on the issue: https://github.com/apache/maven/pull/127 Good point, I reverted to the original `tr` command, but stripping out both *CR* and *LF* now, which will have the desired effect on files with any set of line endings. --- If your project is set up

[GitHub] maven issue #127: Fix concat_lines in mvn to deal with CRLF

Github user Tunaki commented on the issue: https://github.com/apache/maven/pull/127 This doesn't seem to work on CRLF files on Git Bash (or Ubuntu). Result is the same as with `tr`. ```sh $ echo -e "Foo\nBar" > test.txt $ cat -e test.txt Foo$ Bar$ $ paste

[GitHub] maven issue #127: Fix concat_lines in mvn to deal with CRLF

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/127 JIRA issue please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, o

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 The change looks reasonable but I don't use built-in multithreaded build support myself and do not feel comfortable merging this change without proper testing. I will have to defer to somebody more

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

Github user dbmeneses commented on the issue: https://github.com/apache/maven/pull/125 Ok my bad, I've managed to make them pass on my box as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 No, having IT failures are not normal, and [jenkins seems to be happy](https://builds.apache.org/view/M-R/view/Maven%20Core%20ITs/job/core-integration-testing-maven-3-embedded/). --- If your proje

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

Github user dbmeneses commented on the issue: https://github.com/apache/maven/pull/125 @ifedorenko I've updated my previous comment. I added a simple reproducer and I submitted a P/R to maven-integration-testing with an IT. BTW is it normal to have 100+ ITs failing with mvn 3.5.0?

[GitHub] maven issue #125: [MNG-5965] Parallel build multiplies work if multiple goal...

Github user ifedorenko commented on the issue: https://github.com/apache/maven/pull/125 Can you provide a regression test that demonstrates the problem and the fix? Semi-related, I recently fixed similar problem in [Takari Smart Builder](https://github.com/takari/takari-smart-

[GitHub] maven issue #107: Fixes to various JIRA issues.

Github user ChristianSchulte commented on the issue: https://github.com/apache/maven/pull/107 You'll need to merge the resolver bugfixes as well to make the IT work, of course. [MRESOLVER-8](https://github.com/ChristianSchulte/maven-resolver/commit/2813a8f9e290f8a6523486c0ca

[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/123 Just on more thing that recalled from my memory: I did tried to execute tests (http://maven.apache.org/core-its/core-it-suite) like this: `mvn clean test -Prun-its` but I received warning that prof

[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/123 Just for the record: somehow it slipped of my mind that `package` phase doesn't execute integration tests (http://maven.apache.org/ref/3.5.0/maven-core/lifecycles.html#default_Lifecycle) and hence

[GitHub] maven issue #112: Fix snapshot regular expression

Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/112 If you like to get your pull request being integrated it is required to open an [issue on jira](https://issues.apache.org/jira/browse/MNG) and change your commit message accordingly. Something like

[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...

Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/123 Second build after fixing the checkstyle issues has worked. Integration into master done. You can close the pull request. Thank for your help to make Maven better. --- If your project is set up f

[GitHub] maven issue #123: [MNG-6207] display deprecation build warning for dependenc...

Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/123 First build has failed based on [violated checkstyle rules](https://builds.apache.org/view/M-R/view/Maven/job/maven-3.x-jenkinsfile/job/MNG-6207/1/console). So best is before you open a pull reques

[GitHub] maven issue #121: [MNG-6206] display deprecation build warning in case when ...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/121 I'm happy to help ! Regards. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/119 @khmarbaise Ok, I'll open new PR then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...

Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/119 Sorry...Can please make the PR new based on the current master of the apache-maven, cause I didn't realized that this PR must be done before the other...Thanks in advance... --- If your project i

[GitHub] maven issue #121: [MNG-6206] display deprecation build warning in case when ...

Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/121 I have merged the pull request to Maven master. So you can close the pull request here on GitHub. Thanks for our help. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] maven issue #121: [MNG-6206] display deprecation build warning in case when ...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/121 @khmarbaise Integration tests passed as expected, that's nice. Commit message is altered just a little bit and force-pushed here. --- If your project is set up for it, you ca

[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/119 @khmarbaise done, I altered commit messaged (added note about tests). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...

Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/119 Could you make a real commit log message like: ``` [MNG-6207] Create WARNINGs in case of using system scope If needed more description/explanations here. ``` Otherwise I need to

[GitHub] maven issue #121: [MNG-6206] display deprecation build warning in case when ...

Github user khmarbaise commented on the issue: https://github.com/apache/maven/pull/121 Please make a complete commit message with reference to the appropriate ticket. ``` [MNG-6206] display deprecation build warning in case when dependencies use metaversions (LATEST or RELEAS

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 @jdillon Thank you for the contribution anyway! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 closing, https://github.com/apache/maven/commit/66fc74d6296ea0a33f8a9712dc5ed5eb3affd529 provides more comprehensive adjustments for JSR-330 annotations --- If your project is set up for it, you can

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 @jdillon Igor merged his PR contained your fix. This PR is obsolete now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 Thanks for the explanation. So it is not a prerequisite directly. I'd still insist for an JIRA because I need another committer to second this and have this in our release notes. Do you have a simpl

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Igor's change is the more correct/ideal change to avoid future mismatch between plexus-annotation configuration and JSR-330 annotations. The problem is that plexus @Requirement injects directly to th

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 Just to be clear, Igor's change is s prerequisite to your issue? If so, we need two tickets. The IT assures that nothing will break your fix -- no more, no less. --- If your project is set up for

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Igor already created https://issues.apache.org/jira/browse/MNG-6233 but if you really need another issue I can file one just to fix this specific problem. Seems a bit odd though that you want

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user michael-o commented on the issue: https://github.com/apache/maven/pull/116 @jdillon I'd like to merge this but need a JIRA issue. At best, an IT too. Can you provide a simple one? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] maven issue #116: Fix jsr-330 injection of DefaultArtifactDescriptorReader

Github user jdillon commented on the issue: https://github.com/apache/maven/pull/116 Hey folks can we get some movement on this and/or https://github.com/apache/maven/compare/MNG-6233_maven-resolver-provider-jsr330 ATM its broken, either of these fixes the issue. --- If your

[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/119 Just to narrow discussion to PR scope only and to eliminate bonus question: there is/was an initiative to increase validation level (**_MNG-6075_** Increase the model validation level to the next mi

[GitHub] maven issue #120: [MNG-6206] display deprecation build warning in case when ...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/120 My bad, I mistakenly pushed commit without testing; so sorry for that. I will close this merge request and create another. --- If your project is set up for it, you can reply to this email and

[GitHub] maven issue #119: [MNG-6207] display build WARNING if deprecated 'system' sc...

Github user dejan2609 commented on the issue: https://github.com/apache/maven/pull/119 New changes are pushed via new commit (all commits will be squashed into one eventually). Solution is tested across different Maven versions (**3.0.5**, **3.1.1**, **3.2.5**, **3.3.9*

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Github user ebourg commented on the issue: https://github.com/apache/maven/pull/118 Thank you. The add-source trick is a bit problematic for the Debian packaging because we don't build the source jars, but we can live with a Debian specific patch using the shade plugin instead. ---

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/118 ideas added to the MNG-6196 branch in https://github.com/apache/maven/commit/c2a8787eb7450cb28d7f08698788c5e58a3f8a02 : no monkey patch any more I kept dependency:unpack+build-helper:add-source i

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/118 great, I'll merge your ideas with https://github.com/apache/maven/commit/75b23eb01f913cf90d6ac4f9d2d5d7f6b9d69e1a : removing the patching part will be a be a good benefit issue tracked in ht

[GitHub] maven issue #109: Updated Mockito, slf4j and logback dependences to latest v...

Github user ebourg commented on the issue: https://github.com/apache/maven/pull/109 #118 also upgrades SLF4J but goes a bit further by removing the patching mechanism. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Github user ebourg commented on the issue: https://github.com/apache/maven/pull/118 It's better now, the levels and the exceptions are properly colored, and SLF4J no longer complains about the duplicate StaticLoggerBinder. --- If your project is set up for it, you can reply to this e

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Github user ebourg commented on the issue: https://github.com/apache/maven/pull/118 Understood, thank you. I've added a StaticLoggerBinder implementation but now SLF4J complains that there are two StaticLoggerBinder on the classpath (from maven-slf4j-provider and slf4j-simple). I'll t

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Github user hboutemy commented on the issue: https://github.com/apache/maven/pull/118 AFAIK, you have colors on messages, but not on levels: the specific logger is necessary for levels. It's also necessary for colored error rendering. Just look at MavenSimpleLogger and you'll s

[GitHub] maven issue #118: Upgrade SLF4J to 1.7.25

Github user ebourg commented on the issue: https://github.com/apache/maven/pull/118 Is the StaticLoggerBinder implementation necessary? I built Maven without and it seemed to work, the resulting version was able to build a couple of random projects and the console output was colored.

  1   2   3   4   >