Re: Maven3 with guice was Re: Maven 3 tests

2010-06-09 Thread Stuart McCulloch
On 9 June 2010 15:54, Olivier Lamy wrote: > Hi, > I have tested ( > http://code.google.com/p/maven-scm-provider-svnjava/wiki/UsingWithReleasePlugin > ) > and it works nice ! > I have only changed a company plugin to made it works : so it was a > bad maven usage !. > regarding the cnfde there is t

Re: Maven3 with guice was Re: Maven 3 tests

2010-06-09 Thread Jason van Zyl
I'll start with questions you should be asking yourself when suggesting merging in a non-trivial change. There is no change to users, the change is non-trivial from a development perspective. Do you know what it means to merge in that code? Did you have anything to do with the production of the

Re: Maven3 with guice was Re: Maven 3 tests

2010-06-09 Thread Stuart McCulloch
On 9 June 2010 18:08, nicolas de loof wrote: > I built and used it also on few projects without any issue, including some > custom plugins > > I'm +1 to switch to Guice, > > just a note : as Spice uses a modified Guice release, with patch proposed > to > Guice SVN, should we wait for a new Guice

Re: Maven3 with guice was Re: Maven 3 tests

2010-06-09 Thread Olivier Lamy
maybe more details ? 2010/6/9 Jason van Zyl : > > On Jun 9, 2010, at 12:54 AM, Olivier Lamy wrote: > >> Hi, >> I have tested >> (http://code.google.com/p/maven-scm-provider-svnjava/wiki/UsingWithReleasePlugin) >> and it works nice ! >> I have only changed a company plugin to made it works : so it

Re: Maven3 with guice was Re: Maven 3 tests

2010-06-09 Thread Jason van Zyl
On Jun 9, 2010, at 12:54 AM, Olivier Lamy wrote: > Hi, > I have tested > (http://code.google.com/p/maven-scm-provider-svnjava/wiki/UsingWithReleasePlugin) > and it works nice ! > I have only changed a company plugin to made it works : so it was a > bad maven usage !. > regarding the cnfde there

Re: Maven3 with guice was Re: Maven 3 tests

2010-06-09 Thread nicolas de loof
I built and used it also on few projects without any issue, including some custom plugins I'm +1 to switch to Guice, just a note : as Spice uses a modified Guice release, with patch proposed to Guice SVN, should we wait for a new Guice release with those changes included ? 2010/6/9 Olivier Lamy

Re: Maven3 with guice was Re: Maven 3 tests

2010-06-09 Thread Olivier Lamy
Hi, I have tested (http://code.google.com/p/maven-scm-provider-svnjava/wiki/UsingWithReleasePlugin) and it works nice ! I have only changed a company plugin to made it works : so it was a bad maven usage !. regarding the cnfde there is the issue : https://issues.sonatype.org/browse/SPICE-26 (do yo

Re: Maven 3 tests

2010-06-07 Thread Stuart McCulloch
On 7 June 2010 06:21, Jemos Infra wrote: > Hi all, > > I'm working on the Maven 3 branch created today by Olivier Lamy > > [email quote] > stuff is here : > http://svn.apache.org/repos/asf/maven/maven-3/branches/guice-support/ > > Thanks ! > [/email quote] > > This branch is supposed to have the

Re: Maven3 with guice was Re: Maven 3 tests

2010-06-07 Thread Stuart McCulloch
On 7 June 2010 07:25, Olivier Lamy wrote: > Hi, > I have tested some builds. > Some notes. > I have this issues currently : > > java.lang.UnsupportedOperationException >at java.util.AbstractMap.put(AbstractMap.java:186) >at > org.apache.maven.scm.manager.AbstractScmManager.setScmP

Maven3 with guice was Re: Maven 3 tests

2010-06-06 Thread Olivier Lamy
Hi, I have tested some builds. Some notes. I have this issues currently : java.lang.UnsupportedOperationException at java.util.AbstractMap.put(AbstractMap.java:186) at org.apache.maven.scm.manager.AbstractScmManager.setScmProvider(AbstractScmManager.java:93) Now the Map is not an

Maven 3 tests

2010-06-06 Thread Jemos Infra
Hi all, I'm working on the Maven 3 branch created today by Olivier Lamy [email quote] stuff is here : http://svn.apache.org/repos/asf/maven/maven-3/branches/guice-support/ Thanks ! [/email quote] This branch is supposed to have the Maven 3 version which uses Guice instead of Plexus (actually s